azure-sdk-for-python icon indicating copy to clipboard operation
azure-sdk-for-python copied to clipboard

Websocket async implementation must use pure async lib when available

Open rakshith91 opened this issue 3 years ago • 2 comments
trafficstars

Currently, we use websocket-client library which does not have a pure async implementation

websockets has one, but it does not support http proxy https://github.com/aaugustin/websockets/issues/364

When possible use a pure async library

rakshith91 avatar May 05 '22 20:05 rakshith91

aiohttp.ClientSession.ws_connect with aiohttp.ClientWebSocketResponse works quite well.

It has support for async, proxy, ssl settings, etc.

hansmbakker avatar Aug 06 '22 18:08 hansmbakker

Thanks for this input @hansmbakker! FYI @l0lawrence, @kashifkhan, @swathipil - we should look at this soon as we will need an async story for EH before GA.

annatisch avatar Aug 08 '22 04:08 annatisch

Thank you very much @hansmbakker for sharing about the websocket client in aiohttp , this worked out perfectly for us :)

kashifkhan avatar Sep 29 '22 15:09 kashifkhan