azure-sdk-for-net
azure-sdk-for-net copied to clipboard
Azure
Include NetworkCloud to the CodeOwner file
Thank you for your contribution @cn0238! We will review the pull request and get back to you soon.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Added reformatted label to match repository naming pattern for network subcategories. Will need to kick the linter again tomorrow after it refreshes the label list.
@JimSuplizio: The label that is being flagged by the linter exists in the repository with exact capitalization and spacing. Any idea why the linter is rejecting it?
![azure-pipelines[bot] avatar](https://avatars.githubusercontent.com/in/9426?v=4 "Published by a pub.dev verified publisher"){kind=small}
@JimSuplizio: The label that is being flagged by the linter exists in the repository with exact capitalization and spacing. Any idea why the linter is rejecting it?
@jsquire if you looked at the date on the failed run it was from yesterday. I reran it today and it passed. If the label was added yesterday it wouldn't be in the repo/label cache until this morning and that would explain this.
We are working to get the NetworkCloud PR Label registered.
This will be Network - Cloud and has been created in the .NET repository. There's a number of Network - labels, and we'll want this to follow that pattern.
//cc: @ronniegeraghty
@JimSuplizio: The label that is being flagged by the linter exists in the repository with exact capitalization and spacing. Any idea why the linter is rejecting it?
@jsquire if you looked at the date on the failed run it was from yesterday. I reran it today and it passed. If the label was added yesterday it wouldn't be in the repo/label cache until this morning and that would explain this.
Dang it. Sorry. I swore that I kicked that over again this morning.
No, we don't want to be incorporated under Network - Network Cloud as a subcategory, but wish to be NetworkCloud.
@cn0238: Repository labels are chosen by the Azure SDK team and generally are required to follow our patterns. @ronniegeraghty has final approval on label names and will request any adjustments based on branding concerns and likewise.