azure-sdk-for-net
azure-sdk-for-net copied to clipboard
Catch exceptions in QueueMetricsProvider and log errors
Contributing to the Azure SDK
Exceptions in queue metrics provider are currently swallowed by the caller of GetMetricsAsync. We should be logging all exceptions thrown in the extension, not just transient failures.
see here: https://msazure.visualstudio.com/Antares/_workitems/edit/29174215
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.
Thank you for your contribution @chiangvincent! We will review the pull request and get back to you soon.
API change check
APIView has identified API level changes in this PR and created following API reviews.
@chiangvincent: Would you please make your Microsoft and Azure GitHub organization memberships public, and request write permissions to the repository so that you're identified as an internal contributor? Details can be found in the Azure SDK onboarding documentation. Please use the associated Teams channel for support.
- Azure SDK onboarding (Microsoft internal)
- Azure SDK onboarding assistance (Microsoft internal)
You can verify the state of your account by running the Validate-AzsdkCodeOwner script from the Azure SDK tools repository.
Thanks!
@jsquire followed the steps, and got write access to the repos. looks like the powershell script to validate is failing, even though my memberships are public: