azure-sdk-for-net icon indicating copy to clipboard operation
azure-sdk-for-net copied to clipboard

Generate Microsoft.MobileNetwork 2024-04-01 API SDK

Open tompretty opened this issue 1 year ago • 5 comments
trafficstars

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

tompretty avatar May 30 '24 11:05 tompretty

Thank you for your contribution @tompretty! We will review the pull request and get back to you soon.

github-actions[bot] avatar May 30 '24 11:05 github-actions[bot]

@tompretty :

Your account lacks the required public GitHub organizations and permissions required of an internal contributor. Please review the Azure SDK onboarding documentation and use the associated Teams channel for support.

You can verify the state of your account by running the Validate-AzsdkCodeOwner script from the Azure SDK tools repository.

Please also be sure to add yourself to CODEOWNERS for this library, if you will be maintaining it going forward.

Ahh right - I've made myself public in both those groups and I've been added to the Azure SDK Partners group, but just waiting for permissions to sync up

tompretty avatar May 30 '24 15:05 tompretty

API change check

APIView has identified API level changes in this PR and created following API reviews.

Azure.ResourceManager.MobileNetwork

azure-sdk avatar May 30 '24 15:05 azure-sdk

As I will be OOF next week, I'm applying my suggestions directly to fix the CODEOWNERS labels/format. With those in place and permissions verified, I can remove my blocker. Please work with Arthur and team for review of the library code.

jsquire avatar May 31 '24 15:05 jsquire

Ahh right I see - I've accepted the suggestions 👍

tompretty avatar May 31 '24 17:05 tompretty

@tompretty : Arthur gave me a tap to take a look at the linter failure. The root of this is that your Azure/private-5g-core team doesn't have write permissions to the repository. For that to happen, it must be a child of the azure-sdk-write team.

If you still want to use that team, please reach out to @weshaggard for assistance with setting the parent.

jsquire avatar Jul 19 '24 12:07 jsquire