azure-sdk-for-net icon indicating copy to clipboard operation
azure-sdk-for-net copied to clipboard

Published 20 hours ago • verified publisher icon Azure

.NET SDK for Oracle.Database

Open v-jamcheung opened this issue 9 months ago • 1 comments

.NET SDK for Oracle.Database

v-jamcheung avatar May 17 '24 11:05 v-jamcheung

Thank you for your contribution @v-jamcheung! We will review the pull request and get back to you soon.

github-actions[bot] avatar May 17 '24 11:05 github-actions[bot]

@v-jamcheung:

Your account lacks the required public GitHub organizations and permissions required of an internal contributor. Please review the Azure SDK onboarding documentation and use the associated Teams channel for support.

You can verify the state of your account by running the Validate-AzsdkCodeOwner script from the Azure SDK tools repository.

Please also be sure to add yourself to CODEOWNERS for this library, if you will be maintaining it going forward.

Updated CODEOWNERS.

As for the permissions, I believe I will not need write permissions as someone else will be assigned this PR and will merge it once I have addressed all the comments and gotten the necessary approvals.

v-jamcheung avatar May 22 '24 10:05 v-jamcheung

@v-jamcheung: Your account lacks the required public GitHub organizations and permissions required of an internal contributor. Please review the Azure SDK onboarding documentation and use the associated Teams channel for support.

You can verify the state of your account by running the Validate-AzsdkCodeOwner script from the Azure SDK tools repository. Please also be sure to add yourself to CODEOWNERS for this library, if you will be maintaining it going forward.

Updated CODEOWNERS.

As for the permissions, I believe I will not need write permissions as someone else will be assigned this PR and will merge it once I have addressed all the comments and gotten the necessary approvals.

You cannot appear in CODEOWNERS without the proper memberships and rights. Whether you complete this PR or no, you'll need to request permissions.

jsquire avatar May 22 '24 13:05 jsquire

@ArthurMa1978 @KrzysztofCwalina @tg-msft @archerzz @ArcturusZhang @pallavit @ronniegeraghty

Hi team,

I am currently writing the tests for this .NET SDK. Meanwhile please could people review the SDK code and leave comments if there are any issues.

Thanks.

v-jamcheung avatar May 23 '24 15:05 v-jamcheung

Checking a couple of things here. If @v-jamcheung is an internal contributor, I'll remove the Community Contribution and customer-reported labels.

@v-jamcheung, can you tell me how the list of reviewers was added to this PR? Looking at our CODEOWNERS there is no specific listing for /sdk/oracle/* so it should have reverted to the owners for /sdk/ which are @jsquire and @pallavit. Did you manually add the other reviewers listed?

@jsquire is there an existing service label for this library or do we need a new one?

ronniegeraghty avatar May 23 '24 19:05 ronniegeraghty

@ronniegeraghty: It's a management library, which correctly routes to Arthur and team when there are no CODEOWNERS.

jsquire avatar May 23 '24 19:05 jsquire

New PR containing regenerated SDK code after typespec PR (https://github.com/Azure/azure-rest-api-specs/pull/29305) was merged: https://github.com/Azure/azure-sdk-for-net/pull/44499

Putting playback testing on hold, will add them before releasing stable version.

v-jamcheung avatar Jun 11 '24 08:06 v-jamcheung