azure-sdk-for-net
azure-sdk-for-net copied to clipboard
Azure
Reverting .net sdk
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.
Thank you for your contribution @jmegha123! We will review the pull request and get back to you soon.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
API change check
APIView has identified API level changes in this PR and created following API reviews.
FYI. Azure.ResourceManager.Network version 1.8.0 was not released. So, it's OK to update (not revert) the codes.
@jmegha123 as a stable release, can you please add tests for all new operations?
@jmegha123 as a stable release, can you please add tests for all new operations?
@ArthurMa1978 IMHO, This is simply a revert PR which doesn't need any unit test to be written. The ones which you are talking about seems to be long discussion between you and vertika gupta how and where unit tests needs to be written which can be done for future releases
@jmegha123 Please update the API signature. See the error log: https://dev.azure.com/azure-sdk/public/_build/results?buildId=3797673&view=logs&j=b70e5e73-bbb6-5567-0939-8415943fadb9&t=2102385d-609d-5572-64d2-932661c7902f&l=1701
Done ran this command .\eng\scripts\Export-Api.ps1 network
@jmegha123 :
Your account lacks the required public GitHub organizations and permissions required of an internal contributor. Please review the Azure SDK onboarding documentation and use the associated Teams channel for support.
- Azure SDK onboarding (Microsoft internal)
- Azure SDK onboarding assistance (Microsoft internal)
You can verify the state of your account by running the Validate-AzsdkCodeOwner script from the Azure SDK tools repository.
Please also be sure to add yourself to CODEOWNERS for this library, if you will be maintaining it going forward.
yes i think i joined the necessary group
@jmegha123 : Your account lacks the required public GitHub organizations and permissions required of an internal contributor. Please review the Azure SDK onboarding documentation and use the associated Teams channel for support.
- Azure SDK onboarding (Microsoft internal)
- Azure SDK onboarding assistance (Microsoft internal)
You can verify the state of your account by running the Validate-AzsdkCodeOwner script from the Azure SDK tools repository. Please also be sure to add yourself to CODEOWNERS for this library, if you will be maintaining it going forward.
yes i think i joined the necessary group
Permissions issues are confirmed to be resolved.
@ArthurMa1978: Will your team be owning/supporting this library going forward or do we need to have a CODEOWNERS entry with the correct contacts?
@jmegha123 : Your account lacks the required public GitHub organizations and permissions required of an internal contributor. Please review the Azure SDK onboarding documentation and use the associated Teams channel for support.
- Azure SDK onboarding (Microsoft internal)
- Azure SDK onboarding assistance (Microsoft internal)
You can verify the state of your account by running the Validate-AzsdkCodeOwner script from the Azure SDK tools repository. Please also be sure to add yourself to CODEOWNERS for this library, if you will be maintaining it going forward.
yes i think i joined the necessary group
Permissions issues are confirmed to be resolved.
@ArthurMa1978: Will your team be owning/supporting this library going forward or do we need to have a CODEOWNERS entry with the correct contacts?
Right we will continue supporting this lib