azure-sdk-for-net icon indicating copy to clipboard operation
azure-sdk-for-net copied to clipboard

Feature 2024 01 01 preview impl

Open jamesfan1 opened this issue 9 months ago • 8 comments

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

jamesfan1 avatar May 09 '24 15:05 jamesfan1

Thank you for your contribution @jamesfan1! We will review the pull request and get back to you soon.

github-actions[bot] avatar May 09 '24 15:05 github-actions[bot]

How is this different from #43462, and do we need both of these?

jsquire avatar May 09 '24 15:05 jsquire

hi @jsquire thank you for reviewing, we just need this one, I will close the last PR

jamesfan1 avatar May 09 '24 16:05 jamesfan1

I have fixed conflict and just had the Azure SDK Partners permission added

jamesfan1 avatar May 09 '24 17:05 jamesfan1

API change check

APIView has identified API level changes in this PR and created following API reviews.

Azure.ResourceManager.Nginx

azure-sdk avatar May 09 '24 17:05 azure-sdk

@jamesfan1: Account permissions and memberships look good. I made two small corrections to CODEOWNERS to ensure that it follows the expected pattern. Going forward, you'll need to work with @ArthurMa1978 and team on the review for the library.

jsquire avatar May 09 '24 21:05 jsquire

Hey @jamesfan1 please re-record all tests and update the records.

ArthurMa1978 avatar May 10 '24 09:05 ArthurMa1978

@ArthurMa1978

facing some issue when pushing the recording

Unhandled exception: Azure.Sdk.Tools.TestProxy.Common.Exceptions.HttpException: Invocation of "git push origin net/nginx/Azure.ResourceManager.Nginx_424be0482a" had a non-zero exit code -1. StdOut: StdErr: remote: The 'Azure' organization has enabled or enforced SAML SSO. remote: To access this repository, you must re-authorize the OAuth Application 'GitHub CLI'. fatal: unable to access 'https://github.com/Azure/azure-sdk-assets/': The requested URL returned error: 403

jamesfan1 avatar May 10 '24 22:05 jamesfan1

I have uploaded the recording, please check when available

jamesfan1 avatar May 13 '24 19:05 jamesfan1

@ArthurMa1978 all test passed, please help review and approve. Thank you

jamesfan1 avatar May 16 '24 21:05 jamesfan1