azure-sdk-for-net
azure-sdk-for-net copied to clipboard
Feature 2024 01 01 preview impl
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.
Thank you for your contribution @jamesfan1! We will review the pull request and get back to you soon.
How is this different from #43462, and do we need both of these?
hi @jsquire thank you for reviewing, we just need this one, I will close the last PR
I have fixed conflict and just had the Azure SDK Partners permission added
API change check
APIView has identified API level changes in this PR and created following API reviews.
@jamesfan1: Account permissions and memberships look good. I made two small corrections to CODEOWNERS to ensure that it follows the expected pattern. Going forward, you'll need to work with @ArthurMa1978 and team on the review for the library.
Hey @jamesfan1 please re-record all tests and update the records.
@ArthurMa1978
facing some issue when pushing the recording
Unhandled exception: Azure.Sdk.Tools.TestProxy.Common.Exceptions.HttpException: Invocation of "git push origin net/nginx/Azure.ResourceManager.Nginx_424be0482a" had a non-zero exit code -1. StdOut: StdErr: remote: The 'Azure' organization has enabled or enforced SAML SSO. remote: To access this repository, you must re-authorize the OAuth Application 'GitHub CLI'. fatal: unable to access 'https://github.com/Azure/azure-sdk-assets/': The requested URL returned error: 403
I have uploaded the recording, please check when available
@ArthurMa1978 all test passed, please help review and approve. Thank you