azure-sdk-for-net icon indicating copy to clipboard operation
azure-sdk-for-net copied to clipboard

Moving WCF Client/CoreWCF packages to extension-wcf folder to fix pipeline failure in Docx stage

Open subhra231 opened this issue 1 year ago • 41 comments
trafficstars

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

subhra231 avatar Apr 30 '24 04:04 subhra231

Please also update the comment here to reflect the new location.

jsquire avatar Apr 30 '24 13:04 jsquire

/azp run prepare-pipelines

jsquire avatar Apr 30 '24 13:04 jsquire

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Apr 30 '24 13:04 azure-pipelines[bot]

note: I've cleaned up the extensions - wcf pipelines from the previous directory.

jsquire avatar Apr 30 '24 13:04 jsquire

New pipelines have been created, classified, and enabled.

jsquire avatar Apr 30 '24 14:04 jsquire

/azp run net - extension-wcf - ci

jsquire avatar Apr 30 '24 14:04 jsquire

/azp run net - extension-wcf - tests

jsquire avatar Apr 30 '24 14:04 jsquire

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Apr 30 '24 14:04 azure-pipelines[bot]

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Apr 30 '24 14:04 azure-pipelines[bot]

Please also update the comment here to reflect the new location.

Updated this location.

subhra231 avatar May 01 '24 20:05 subhra231

API change check

APIView has identified API level changes in this PR and created following API reviews.

Microsoft.CoreWCF.Azure.StorageQueues Microsoft.WCF.Azure.StorageQueues

azure-sdk avatar May 02 '24 23:05 azure-sdk

/azp run net - extension-wcf - ci

jsquire avatar May 03 '24 14:05 jsquire

/azp run net - extension-wcf - tests

jsquire avatar May 03 '24 14:05 jsquire

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar May 03 '24 14:05 azure-pipelines[bot]

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar May 03 '24 14:05 azure-pipelines[bot]

LGTM. I kicked off the CI and Live pipelines. Once we've confirmed they're passing, we should be good to merge.

jsquire avatar May 03 '24 14:05 jsquire

Please add a CODEOWNERS section for this new path as well. I'll create the "Extension - WCF" label for it.

jsquire avatar May 03 '24 15:05 jsquire

/azp run net - extension-wcf - ci

jsquire avatar May 07 '24 15:05 jsquire

/azp run net - extension-wcf - tests

jsquire avatar May 07 '24 15:05 jsquire

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar May 07 '24 15:05 azure-pipelines[bot]

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar May 07 '24 15:05 azure-pipelines[bot]

@subhra231: Changes look good to me. I've kicked off the two pipelines. Once those are passing, I'll approve and merge.

jsquire avatar May 07 '24 15:05 jsquire

@subhra231: Looks like you've got some environmental issues with Azurite that you'll need to work through. Please let me know when you're ready and I'll kick the pipelines again.

jsquire avatar May 07 '24 18:05 jsquire

@subhra231: Looks like you've got some environmental issues with Azurite that you'll need to work through. Please let me know when you're ready and I'll kick the pipelines again.

@jsquire Thats right. We noticed the issue and we are taking a look. We will let you know when we have a fix. Thanks

subhra231 avatar May 07 '24 20:05 subhra231

/azp run prepare-pipelines

@subhra231: Looks like you've got some environmental issues with Azurite that you'll need to work through. Please let me know when you're ready and I'll kick the pipelines again.

@jsquire Thats right. We noticed the issue and we are taking a look. We will let you know when we have a fix. Thanks

@jsquire Looks like the azurite test template was missing from tests.yml file. Submitted the change. hopefully that fixes this failure

subhra231 avatar May 08 '24 01:05 subhra231

No pipelines are associated with this pull request.

azure-pipelines[bot] avatar May 08 '24 01:05 azure-pipelines[bot]

/azp run net - extension-wcf - ci

jsquire avatar May 08 '24 14:05 jsquire

/azp run net - extension-wcf - tests

jsquire avatar May 08 '24 14:05 jsquire

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar May 08 '24 14:05 azure-pipelines[bot]

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar May 08 '24 14:05 azure-pipelines[bot]