azure-sdk-for-net
azure-sdk-for-net copied to clipboard
Moving WCF Client/CoreWCF packages to extension-wcf folder to fix pipeline failure in Docx stage
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.
Please also update the comment here to reflect the new location.
/azp run prepare-pipelines
Azure Pipelines successfully started running 1 pipeline(s).
note: I've cleaned up the extensions - wcf pipelines from the previous directory.
New pipelines have been created, classified, and enabled.
/azp run net - extension-wcf - ci
/azp run net - extension-wcf - tests
Azure Pipelines successfully started running 1 pipeline(s).
Azure Pipelines successfully started running 1 pipeline(s).
API change check
APIView has identified API level changes in this PR and created following API reviews.
Microsoft.CoreWCF.Azure.StorageQueues Microsoft.WCF.Azure.StorageQueues
/azp run net - extension-wcf - ci
/azp run net - extension-wcf - tests
Azure Pipelines successfully started running 1 pipeline(s).
Azure Pipelines successfully started running 1 pipeline(s).
LGTM. I kicked off the CI and Live pipelines. Once we've confirmed they're passing, we should be good to merge.
Please add a CODEOWNERS section for this new path as well. I'll create the "Extension - WCF" label for it.
/azp run net - extension-wcf - ci
/azp run net - extension-wcf - tests
Azure Pipelines successfully started running 1 pipeline(s).
Azure Pipelines successfully started running 1 pipeline(s).
@subhra231: Changes look good to me. I've kicked off the two pipelines. Once those are passing, I'll approve and merge.
@subhra231: Looks like you've got some environmental issues with Azurite that you'll need to work through. Please let me know when you're ready and I'll kick the pipelines again.
@subhra231: Looks like you've got some environmental issues with Azurite that you'll need to work through. Please let me know when you're ready and I'll kick the pipelines again.
@jsquire Thats right. We noticed the issue and we are taking a look. We will let you know when we have a fix. Thanks
/azp run prepare-pipelines
@subhra231: Looks like you've got some environmental issues with Azurite that you'll need to work through. Please let me know when you're ready and I'll kick the pipelines again.
@jsquire Thats right. We noticed the issue and we are taking a look. We will let you know when we have a fix. Thanks
@jsquire Looks like the azurite test template was missing from tests.yml file. Submitted the change. hopefully that fixes this failure
No pipelines are associated with this pull request.
/azp run net - extension-wcf - ci
/azp run net - extension-wcf - tests
Azure Pipelines successfully started running 1 pipeline(s).
Azure Pipelines successfully started running 1 pipeline(s).