azure-sdk-for-net icon indicating copy to clipboard operation
azure-sdk-for-net copied to clipboard

Published 20 hours ago • verified publisher icon Azure

track2 .NET SDK generation for dataprotection for 2023-12

Open abhinitkumar01 opened this issue 9 months ago • 4 comments

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

abhinitkumar01 avatar Apr 29 '24 06:04 abhinitkumar01

Thank you for your contribution @abhinitkumar01! We will review the pull request and get back to you soon.

github-actions[bot] avatar Apr 29 '24 06:04 github-actions[bot]

API change check

APIView has identified API level changes in this PR and created following API reviews.

Azure.ResourceManager.DataProtectionBackup

azure-sdk avatar Apr 29 '24 06:04 azure-sdk

@archerzz , can you please review this.

abhinitkumar01 avatar May 01 '24 07:05 abhinitkumar01

Account issues have been resolved. Still requires CODEOWNERS updates to move forward.

jsquire avatar May 09 '24 14:05 jsquire

@abhinitkumar01 Please take a look at my comment. Thanks.

archerzz avatar May 19 '24 23:05 archerzz

@archerzz I have updated the changelog file for requesting a new release. Regarding CODEOWNERS, I will not necessarily be maintaining it going forwards, as other folks would be updating it as and when new features are pushed. Can you please help me with that part.

abhinitkumar01 avatar May 22 '24 09:05 abhinitkumar01

Account issues have been resolved. Still requires CODEOWNERS updates to move forward.

@jsquire Regarding CODEOWNERS, I will not be necessarily maintaining it going forward, as other folks would be updating it as and when new features are pushed. Can you please help me with that part.

abhinitkumar01 avatar May 22 '24 11:05 abhinitkumar01

Account issues have been resolved. Still requires CODEOWNERS updates to move forward.

@jsquire Regarding CODEOWNERS, I will not be necessarily maintaining it going forward, as other folks would be updating it as and when new features are pushed. Can you please help me with that part.

Which team owns this package? If that is not the Azure SDK team, then we'll need to add a set of owners responsible for support when customer issues are opened. If that is not you, directly, please work with your team to find the right contacts or to create a GitHub team to be added, which your team can update when owners change.

jsquire avatar May 22 '24 13:05 jsquire

@jsquire this library is owned by Azure BCDR team, specifically we own the swagger changes and create PRs to update the .NET SDK taking help from .NET SDK team. However, Azure .NET SDK team takes care of all the polishing or major issues which are SDK specific. Please suggest further

hiaga avatar May 23 '24 10:05 hiaga

if we need to add CODEOWNERS please add me (@hiaga ) and abhinit (@abhinitkumar01 ) for now as a github team. We'll add relevent folks as and when needed

hiaga avatar May 23 '24 10:05 hiaga

Hi @abhinitkumar01. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

github-actions[bot] avatar Jul 26 '24 05:07 github-actions[bot]