azure-sdk-for-net icon indicating copy to clipboard operation
azure-sdk-for-net copied to clipboard

New analyzer version to remove namespace analyzer

Open maririos opened this issue 1 year ago • 4 comments
trafficstars

The release pipelines have logic to block a release if the package name is not approved. At this point, .NET is the only repo that is doing an extra check so I am cleaning the process.

PR in tools repo: https://github.com/Azure/azure-sdk-tools/pull/8164

Tracking issue: https://github.com/Azure/azure-sdk-tools/issues/8105

maririos avatar Apr 26 '24 21:04 maririos

Why remove this check instead of providing an "allow list" of namespaces differently? How are we validating in our pipelines that non-approved namespaces won't be shipped?

This was the result of an email discussion with the architects agreeing that this is no longer necessary due to API View being the authoritative voice for approved namespaces and package names. The analyzer has been a consistent point of feedback from partners who found it causing friction while onboarding to .NET.

jsquire avatar Apr 29 '24 17:04 jsquire

Why remove this check instead of providing an "allow list" of namespaces differently? How are we validating in our pipelines that non-approved namespaces won't be shipped?

The release pipelines have logic to block a release if the package name is not approved. At this point, .NET is the only repo that is doing an extra check so I am cleaning the process. I will add you to the email thread where the discussion happened

maririos avatar Apr 29 '24 17:04 maririos

We can probably also clean-up all the existing references to this code https://github.com/search?q=repo%3AAzure%2Fazure-sdk-for-net%20AZC0001&type=code

weshaggard avatar Apr 29 '24 18:04 weshaggard

API change check

API changes are not detected in this pull request.

azure-sdk avatar Apr 29 '24 19:04 azure-sdk

/check-enforcer override

maririos avatar May 01 '24 17:05 maririos