azure-sdk-for-net icon indicating copy to clipboard operation
azure-sdk-for-net copied to clipboard

Published 20 hours ago • verified publisher icon Azure

Adding WebPubSubService provisioning

Open vicancy opened this issue 1 year ago • 6 comments
trafficstars

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

Adding WebPubSubService provisioning for https://github.com/dotnet/aspire/pull/2495

vicancy avatar Mar 27 '24 06:03 vicancy

@jsquire do we want to add this to the codeowners list too? I think it would be valuable but I usually see you gatekeep so wanted to check with you.

pallavit avatar Mar 27 '24 20:03 pallavit

@jsquire do we want to add this to the codeowners list too? I think it would be valuable but I usually see you gatekeep so wanted to check with you.

Yeah, it's past time that @JoshLove-msft and @tg-msft were added as owners for provisioning. I'll put out a PR for this tomorrow if Josh doesn't beat me to it.

jsquire avatar Mar 27 '24 21:03 jsquire

Hi @JoshLove-msft, could you provide guidance on running and testing the test? The CI throws with System.InvalidOperationException : WebPubSubData does not implement IPersistableModel however WebPubSubData does implement IPersistableModel, do you have any hints how to fix the test? Do I need to prepare something for the test?

https://github.com/Azure/azure-sdk-for-net/blob/47a7099bd35293a864a6bdcc6b7640bbad3fdbda/sdk/webpubsub/Azure.ResourceManager.WebPubSub/api/Azure.ResourceManager.WebPubSub.netstandard2.0.cs#L20C211-L20C228

vicancy avatar Apr 01 '24 05:04 vicancy

Hi @JoshLove-msft, could you provide guidance on running and testing the test? The CI throws with System.InvalidOperationException : WebPubSubData does not implement IPersistableModel however WebPubSubData does implement IPersistableModel, do you have any hints how to fix the test? Do I need to prepare something for the test?

https://github.com/Azure/azure-sdk-for-net/blob/47a7099bd35293a864a6bdcc6b7640bbad3fdbda/sdk/webpubsub/Azure.ResourceManager.WebPubSub/api/Azure.ResourceManager.WebPubSub.netstandard2.0.cs#L20C211-L20C228

Yes, we would need to generate the bicep serialization in the Azure.ResourceManager.WebPubSub library. Here is an example https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/servicebus/Azure.ResourceManager.ServiceBus/src/autorest.md showing the property that needs to be set:

enable-bicep-serialization: true

Once this property is set, you would need to regenerate that library, and then we would need to ship a new GA version with the bicep serialization.

JoshLove-msft avatar Apr 01 '24 15:04 JoshLove-msft

API change check

APIView has identified API level changes in this PR and created following API reviews.

Azure.Provisioning

azure-sdk avatar Apr 23 '24 09:04 azure-sdk

Looks like CI fails on unrelated tests image Hi @JoshLove-msft could you help review the PR?

vicancy avatar Apr 28 '24 06:04 vicancy