azure-sdk-for-net
azure-sdk-for-net copied to clipboard
Azure
Azure Programmable Connectivity .NET SDK
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.
First draft PR for .NET SDK
Samples have been written, tests written (not for async), changelog added.
This is our team's first PR into Azure/azure-sdk-for-net, apologies if I've missed anything.
![azure-pipelines[bot] avatar](https://avatars.githubusercontent.com/in/9426?v=4 "Published by a pub.dev verified publisher"){kind=small}
API change check
APIView has identified API level changes in this PR and created following API reviews.
Azure.Communication.ProgrammableConnectivity
@jsquire I've talked to folks at ACS, who have replied:
From an ACS perspective, I think we don't need to be reviewers for your SDKs - I looked at the shared files (.sln, ci.yml) and they look good.
They've also flagged concern about live tests, but APC have a plan in backlog to unblock that.
Can you please approve PR and have this merged?
@jsquire I've talked to folks at ACS, who have replied:
From an ACS perspective, I think we don't need to be reviewers for your SDKs - I looked at the shared files (.sln, ci.yml) and they look good.
They've also flagged concern about live tests, but APC have a plan in backlog to unblock that.
Can you please approve PR and have this merged?
The ACS team is self-contained and should be reviewing/approving all ACS-related libraries. If the other ACS teams are not interested in serving as reviewers/approvers here, you should have members of your immediate team onboard to the Azure SDK repository and provide reviews/merges.
To ensure that you're not blocked in the meantime, I'll approve/merge without further review once you're able to pass the CI and tests pipelines.
Only macOS tests failing now, but seems unrelated to code issues. @AndrewNivenMSFT can you do 1 final review and approve please?
Failed SimSwapRetrieveTest [5 s]
Error Message:
Azure.Identity.CredentialUnavailableException : DefaultAzureCredential failed to retrieve a token from the included credentials. See the troubleshooting guide for more information. https://aka.ms/azsdk/net/identity/defaultazurecredential/troubleshoot
- EnvironmentCredential authentication unavailable. Environment variables are not fully configured. See the troubleshooting guide for more information. https://aka.ms/azsdk/net/identity/environmentcredential/troubleshoot
- WorkloadIdentityCredential authentication unavailable. The workload options are not fully configured. See the troubleshooting guide for more information. https://aka.ms/azsdk/net/identity/workloadidentitycredential/troubleshoot
Only macOS tests failing now, but seems unrelated to code issues. @AndrewNivenMSFT can you do 1 final review and approve please?
Failed SimSwapRetrieveTest [5 s] Error Message: Azure.Identity.CredentialUnavailableException : DefaultAzureCredential failed to retrieve a token from the included credentials. See the troubleshooting guide for more information. https://aka.ms/azsdk/net/identity/defaultazurecredential/troubleshoot - EnvironmentCredential authentication unavailable. Environment variables are not fully configured. See the troubleshooting guide for more information. https://aka.ms/azsdk/net/identity/environmentcredential/troubleshoot - WorkloadIdentityCredential authentication unavailable. The workload options are not fully configured. See the troubleshooting guide for more information. https://aka.ms/azsdk/net/identity/workloadidentitycredential/troubleshoot
@jsquire is this a blocker? I've had a member of my team approve this PR, but I don't have permissions to merge.
Only macOS tests failing now, but seems unrelated to code issues. @AndrewNivenMSFT can you do 1 final review and approve please?
Failed SimSwapRetrieveTest [5 s] Error Message: Azure.Identity.CredentialUnavailableException : DefaultAzureCredential failed to retrieve a token from the included credentials. See the troubleshooting guide for more information. https://aka.ms/azsdk/net/identity/defaultazurecredential/troubleshoot - EnvironmentCredential authentication unavailable. Environment variables are not fully configured. See the troubleshooting guide for more information. https://aka.ms/azsdk/net/identity/environmentcredential/troubleshoot - WorkloadIdentityCredential authentication unavailable. The workload options are not fully configured. See the troubleshooting guide for more information. https://aka.ms/azsdk/net/identity/workloadidentitycredential/troubleshoot@jsquire is this a blocker? I've had a member of my team approve this PR, but I don't have permissions to merge.
I've noticed a teams thread that covers this, trying to fix. Sorry for the spam
@aronhegedusms : I've kicked off the pipelines for one last pass. Assuming all is well, I'll get this merged for you.