azure-sdk-for-net icon indicating copy to clipboard operation
azure-sdk-for-net copied to clipboard

fix: pass attributes defined in the ResourceBuilder along with azure monitor telemetry

Open mumby0168 opened this issue 6 months ago • 7 comments

Closes #40951 #40630 #35487

This is my first PR to this area, I have read the guide but anything I need to add please let me know :)

One question I do have, is that the idea of OTEL and the resource attributes are sent once per batch of signals, I know this PR sends it per telemetry item, is there another option or is this not supported by the azure monitor SDK?

mumby0168 avatar Feb 09 '24 08:02 mumby0168

Thank you for your contribution @mumby0168! We will review the pull request and get back to you soon.

github-actions[bot] avatar Feb 09 '24 08:02 github-actions[bot]

@mumby0168 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

mumby0168 avatar Feb 09 '24 08:02 mumby0168

Supporting Resource should be coordinated with other languages as well, and need some spec/mapping defined before implementing.

See previous PR which also details the need for design first : #36027

Hi, who is this sat with at the moment is this within Microsoft or in the wider OTEL community?

Is there an option to wrap this in an experimental feature or via configuration potentially so people can opt in at there own will?

Thanks, Billy

mumby0168 avatar Feb 12 '24 15:02 mumby0168

This is a pure Microsoft/Azure Monitor decision, nothing to do with OTel community.

cijothomas avatar Feb 12 '24 19:02 cijothomas

This is a pure Microsoft/Azure Monitor decision, nothing to do with OTel community.

Is this on-going and due anytime soon, or anything that can be done to get an ETA?

mumby0168 avatar Feb 15 '24 14:02 mumby0168

This is a pure Microsoft/Azure Monitor decision, nothing to do with OTel community.

Is this on-going and due anytime soon, or anything that can be done to get an ETA?

@mattmccleary Is there an ETA we can provide?

cijothomas avatar Feb 16 '24 23:02 cijothomas

This is a pure Microsoft/Azure Monitor decision, nothing to do with OTel community.

Is this on-going and due anytime soon, or anything that can be done to get an ETA?

@mattmccleary Is there an ETA we can provide?

No dates yet, it's on the agenda to discuss w/ our backend team to ensure we are aligned w/ upcoming changes to how resource metadata is stored in Log Analytics and used to power experiences in Azure Monitor. FYI - @OsvaldoRosado

mattmccleary avatar Feb 17 '24 00:02 mattmccleary

Hi @mumby0168. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

github-actions[bot] avatar Apr 19 '24 05:04 github-actions[bot]

Hi @mumby0168. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing /reopen if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the no-recent-activity label; otherwise, this is likely to be closed again with the next cleanup pass.

github-actions[bot] avatar Apr 26 '24 08:04 github-actions[bot]