azure-sdk-for-net icon indicating copy to clipboard operation
azure-sdk-for-net copied to clipboard

Published 20 hours ago • verified publisher icon Azure

Update Azure.Core shared for LRO rehydration

Open live1206 opened this issue 1 year ago • 5 comments

  • Construct RehydrationToken from multiple fields
    • HeaderSource: Needed to get final reuqest Uri, could be OperationLocation, AzureAsyncOperation, Location or None
    • NextRequestUri: The Uri to poll status of the operation
    • InitialUri: The initial Uri of the operation, needed to get final request Uri
    • RequestMethod: Http request method of the operation
    • LastKnownLocation: The last know location of the operation, used if the above flag is true
    • FinalStateVia
  • For fake delete LRO with 404, just return empty response with 200 because the delete succeeded

live1206 avatar Jan 09 '24 02:01 live1206

API change check

APIView has identified API level changes in this PR and created following API reviews.

Azure.Security.KeyVault.Certificates Azure.Security.KeyVault.Keys Azure.Security.KeyVault.Secrets Azure.AI.TextAnalytics Azure.AI.Translation.Document Azure.AI.FormRecognizer Azure.Communication.Email Azure.Core Azure.Core.Experimental Azure.Security.ConfidentialLedger Azure.AI.Translation.Text Azure.Communication.JobRouter Azure.Communication.CallAutomation Azure.Communication.CallingServer Azure.Communication.Chat Azure.Communication.Messages Azure.Communication.Sms Azure.Communication.Rooms Azure.Communication.Identity Azure.Communication.MediaComposition Azure.Communication.NetworkTraversal Azure.Communication.PhoneNumbers Azure.Communication.ShortCodes Azure.Communication.AlphaIds Azure.Data.Tables Azure.Template Azure.IoT.TimeSeriesInsights Azure.AI.Vision.ImageAnalysis Azure.Media.VideoAnalyzer.Edge Azure.Messaging.WebPubSub Azure.Messaging.WebPubSub.Client Azure.Security.KeyVault.Administration

azure-sdk avatar Jan 09 '24 02:01 azure-sdk

Can we eliminate some of the shared source files? We consider shared sources to be engineering debt.

KrzysztofCwalina avatar Jan 24 '24 19:01 KrzysztofCwalina

Pending on https://github.com/Azure/azure-sdk-for-net/pull/41655 and https://github.com/Azure/azure-sdk-for-net/pull/41659

live1206 avatar Jan 30 '24 15:01 live1206

Can we eliminate some of the shared source files? We consider shared sources to be engineering debt.

Removed the share core files.

live1206 avatar Jan 31 '24 00:01 live1206

API change check

APIView has identified API level changes in this PR and created following API reviews.

Azure.Core

live1206 avatar Jan 31 '24 12:01 live1206

I left a couple of minor nits, nothing that I'd consider blocking.
@m-nash: Would you please own the final review for approval? I'm not familiar enough with the design to feel comfortable doing so.

jsquire avatar Feb 28 '24 15:02 jsquire

Based on https://github.com/Azure/azure-sdk-for-net/pull/41088#discussion_r1523552344, we would like to expose the LRO rehydration functionality as static method, created https://github.com/Azure/azure-sdk-for-net/pull/42686 for it.

live1206 avatar Mar 14 '24 07:03 live1206

continue the work in https://github.com/Azure/azure-sdk-for-net/pull/42686

live1206 avatar Mar 29 '24 02:03 live1206