Add EASM .NET data plane SDK
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.
/azp run net - easm - ci
No pipelines are associated with this pull request.
/azp run prepare-pipelines
Azure Pipelines successfully started running 1 pipeline(s).
/azp run net - easm - ci
Azure Pipelines successfully started running 1 pipeline(s).
API change check
API changes are not detected in this pull request.
Given this is a new SDK - could you please share who has been helping you with the onboarding? Also could you add the correct owners to the https://github.com/Azure/azure-sdk-for-net/blob/main/.github/CODEOWNERS file.
/cc: @jsquire
@pallavit I have been working on this .NET sdk by myself
/azp run net - easm - ci
Pull request contains merge conflicts.
Hi @KrzysztofCwalina can you please review this PR?
@jsquire if we don't get the name for PR label by tomorrow, can we merge this PR without the code owners for now? I can have a follow up PR to add the code owner. I plan to release the SDK beta version on next week 03/05. I checked the release check list, the code owner isn't the list: https://microsoft.sharepoint.com/teams/AzureDeveloperExperience/_layouts/15/Doc.aspx?sourcedoc=%7Bad5cabd9-978a-4ae5-9a84-f4ab0ebdd76e%7D&action=edit&wd=target(Guidelines.one%7C2d826c9f-fb1d-4676-ada3-636c9afe09ef%2FRelease%20checklist%20for%20.NET%7C383e2aa7-e765-46c7-a735-99d4628465c6%2F)&wdorigin=NavigationUrl&share=IgHZq1ytipflSpqE9KsOvdduATYSaLtsZtX5JTiWByYsw1M
I also updated the CHANGELOG.md
/azp run net - easm - ci
Azure Pipelines successfully started running 1 pipeline(s).
/azp run net - easm - ci
Azure Pipelines successfully started running 1 pipeline(s).
@jsquire, I have updated the PRLabel and ServiceLabel to "Defender EASM", do you know why the test is still failing saying that there's no "Defender EASM" in this repository?
@jsquire, I have updated the PRLabel and ServiceLabel to "Defender EASM", do you know why the test is still failing saying that there's no "Defender EASM" in this repository?
That will continue to happen until tomorrow when the linter's sync job processes changes from each repository.
/azp run net - easm - ci
Azure Pipelines successfully started running 1 pipeline(s).
@jsquire I think you might need refresh browser/ clear caches. git pull request failed sync some of pushed commits
@jsquire I think you might need refresh browser/ clear caches. git pull request failed sync some of pushed commits
Yup. That looks right now.
@thang-bit : Looks like pushes with changes have slowed. If you're ready to merge, please let me know and I'll hit the button.
@jsquire The PR is ready to merge