azure-sdk-for-net icon indicating copy to clipboard operation
azure-sdk-for-net copied to clipboard

Add EASM .NET data plane SDK

Open thang-bit opened this issue 2 years ago • 12 comments

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

thang-bit avatar Dec 05 '23 20:12 thang-bit

/azp run net - easm - ci

thang-bit avatar Dec 08 '23 00:12 thang-bit

No pipelines are associated with this pull request.

azure-pipelines[bot] avatar Dec 08 '23 00:12 azure-pipelines[bot]

/azp run prepare-pipelines

thang-bit avatar Dec 08 '23 00:12 thang-bit

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Dec 08 '23 00:12 azure-pipelines[bot]

/azp run net - easm - ci

thang-bit avatar Dec 08 '23 00:12 thang-bit

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Dec 08 '23 00:12 azure-pipelines[bot]

API change check

API changes are not detected in this pull request.

azure-sdk avatar Dec 08 '23 00:12 azure-sdk

Given this is a new SDK - could you please share who has been helping you with the onboarding? Also could you add the correct owners to the https://github.com/Azure/azure-sdk-for-net/blob/main/.github/CODEOWNERS file.

/cc: @jsquire

pallavit avatar Dec 12 '23 05:12 pallavit

@pallavit I have been working on this .NET sdk by myself

thang-bit avatar Jan 18 '24 22:01 thang-bit

/azp run net - easm - ci

thang-bit avatar Feb 15 '24 16:02 thang-bit

Pull request contains merge conflicts.

azure-pipelines[bot] avatar Feb 15 '24 16:02 azure-pipelines[bot]

Hi @KrzysztofCwalina can you please review this PR?

thang-bit avatar Feb 20 '24 22:02 thang-bit

@jsquire if we don't get the name for PR label by tomorrow, can we merge this PR without the code owners for now? I can have a follow up PR to add the code owner. I plan to release the SDK beta version on next week 03/05. I checked the release check list, the code owner isn't the list: https://microsoft.sharepoint.com/teams/AzureDeveloperExperience/_layouts/15/Doc.aspx?sourcedoc=%7Bad5cabd9-978a-4ae5-9a84-f4ab0ebdd76e%7D&action=edit&wd=target(Guidelines.one%7C2d826c9f-fb1d-4676-ada3-636c9afe09ef%2FRelease%20checklist%20for%20.NET%7C383e2aa7-e765-46c7-a735-99d4628465c6%2F)&wdorigin=NavigationUrl&share=IgHZq1ytipflSpqE9KsOvdduATYSaLtsZtX5JTiWByYsw1M

I also updated the CHANGELOG.md

thang-bit avatar Feb 29 '24 17:02 thang-bit

/azp run net - easm - ci

thang-bit avatar Feb 29 '24 20:02 thang-bit

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Feb 29 '24 20:02 azure-pipelines[bot]

/azp run net - easm - ci

thang-bit avatar Feb 29 '24 21:02 thang-bit

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Feb 29 '24 21:02 azure-pipelines[bot]

@jsquire, I have updated the PRLabel and ServiceLabel to "Defender EASM", do you know why the test is still failing saying that there's no "Defender EASM" in this repository?

thang-bit avatar Feb 29 '24 21:02 thang-bit

@jsquire, I have updated the PRLabel and ServiceLabel to "Defender EASM", do you know why the test is still failing saying that there's no "Defender EASM" in this repository?

That will continue to happen until tomorrow when the linter's sync job processes changes from each repository.

jsquire avatar Feb 29 '24 21:02 jsquire

/azp run net - easm - ci

thang-bit avatar Mar 01 '24 14:03 thang-bit

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Mar 01 '24 14:03 azure-pipelines[bot]

@jsquire I think you might need refresh browser/ clear caches. git pull request failed sync some of pushed commits

thang-bit avatar Mar 01 '24 15:03 thang-bit

@jsquire I think you might need refresh browser/ clear caches. git pull request failed sync some of pushed commits

Yup. That looks right now.

jsquire avatar Mar 01 '24 15:03 jsquire

@thang-bit : Looks like pushes with changes have slowed. If you're ready to merge, please let me know and I'll hit the button.

jsquire avatar Mar 01 '24 17:03 jsquire

@jsquire The PR is ready to merge

thang-bit avatar Mar 01 '24 17:03 thang-bit