azure-sdk-for-net icon indicating copy to clipboard operation
azure-sdk-for-net copied to clipboard

Published 20 hours ago • verified publisher icon Azure

Enable customerizing webview for interactive authentication

Open msJinLei opened this issue 2 years ago • 2 comments

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

Purpose

Azure PowerShell replies on Azure. Identity to use MSAL. Currently, we are required to customize webview displayed after authentication, which requires Azure.Identity to open new properties that are already supported by MSAL.

msJinLei avatar Feb 12 '23 12:02 msJinLei

API change check

APIView has identified API level changes in this PR and created following API reviews.

Azure.Identity

azure-sdk avatar Feb 12 '23 12:02 azure-sdk

hi team, could you help to review the PR thanks

msJinLei avatar Feb 15 '23 10:02 msJinLei

@christothes @scottaddie I have addressed your comments. Please take a review. thanks.

msJinLei avatar Jul 14 '23 08:07 msJinLei

Looks good - let's just add a changelog entry for this.

@christothes Add a changelog entry, please help to review it.

msJinLei avatar Jul 19 '23 03:07 msJinLei

Thanks - LGTM!

Thanks @christothes for your help! One more question, when the PR can be merged?

msJinLei avatar Jul 19 '23 18:07 msJinLei