azure-sdk-for-net icon indicating copy to clipboard operation
azure-sdk-for-net copied to clipboard

Published 20 hours ago • verified publisher icon Azure

[Draft for discussion] Preliminary updates to Confidential Ledger samples to use DynamicJson

Open annelo-msft opened this issue 2 years ago • 2 comments
trafficstars

The DynamicJson type released in Azure.Core.Experimental 0.1.0-preview.24.

This draft PR illustrates what it would look like at this point to move the Confidential Ledger samples to use DynamicJson instead of JsonDocument.

annelo-msft avatar Feb 07 '23 00:02 annelo-msft

API change check

API changes are not detected in this pull request.

azure-sdk avatar Feb 07 '23 01:02 azure-sdk

That's a pretty large set of boilerplate removed. I think this makes a huge difference in readability.

jsquire avatar Feb 07 '23 14:02 jsquire

Hi @annelo-msft. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

github-actions[bot] avatar Apr 21 '23 05:04 github-actions[bot]

Hi @annelo-msft. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing /reopen if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the no-recent-activity label; otherwise, this is likely to be closed again with the next cleanup pass.

github-actions[bot] avatar Apr 28 '23 14:04 github-actions[bot]