azure-sdk-for-net
azure-sdk-for-net copied to clipboard
Azure
Add voiceservices sdk
This PR adds the Azure.ResourceManager.VoiceServices SDK for the "Microsoft.VoiceServices" ARM api defined here: https://github.com/Azure/azure-rest-api-specs/tree/main/specification/voiceservices/resource-manager/Microsoft.VoiceServices/stable/2023-01-31
I've followed the guidance here: https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/78/Mgmt-.NET-SDK-release-process?anchor=sdk-generation-from-scratch to create this PR.
The .NET namespace name has been approved in this issue: https://github.com/Azure/azure-sdk-pr/issues/842
I've used the EdgeOrder tests as a starting point for how to write the tests, as per the Wiki instructions. I think the tests I've written are sufficient.
These changes were previous reviewed within our team in a PR to our branch in the private repo: https://github.com/Azure/azure-sdk-for-net-pr/pull/1802, but since then I've regenerated it with the correct name and updated it to the latest stable API version.
The tests all pass locally. I've noticed that CI is failing, complaining that it doesn't have the VOICESERVICES_TENANT_ID or TENANT_ID env vars, but surely these aren't expected to be checked in? Is this CI failure expected in a PR off a fork? If not, what should I do to fix it up?
The ability to use the Microsoft.VoiceServices API is hidden behind AFEC flags, and we expect this to continue. So I'm not sure how I square this with the CI - do the .NET SDK team have a single subscription that CI uses? If so, I'll need to add the required AFEC flag for that subscription.
Hi @ArcturusZhang, we've hoping to get this released by the end of Februrary to meet our APEX commitment. Do you know when you'll be able to review this?
Thanks @ArcturusZhang , I've addressed all 3 of your suggestions now.
I've also updated the CHANGELOG in preparation for the SDK release, per the release instructions. I figured now that it has been reviewed I may as well perform the release changelog update in the same PR
Namespace has been approved here https://github.com/Azure/azure-sdk-pr/issues/842
![azure-pipelines[bot] avatar](https://avatars.githubusercontent.com/in/9426?v=4 "Published by a pub.dev verified publisher"){kind=small}
API change check
APIView has identified API level changes in this PR and created following API reviews.
Azure.ResourceManager.VoiceServices
Sorry, I was told to rebase off main to fix up the recorded tests, and doing so lost the commit you added in the meantime. I've reproduced it as the last commit on this branch
Sorry, I was told to rebase off
mainto fix up the recorded tests, and doing so lost the commit you added in the meantime. I've reproduced it as the last commit on this branch
please rerun dotnet build /t:GenerateTest to update samples (dotnet build /t:GenerateTests if you synced up with main).
Sorry, I was told to rebase off
mainto fix up the recorded tests, and doing so lost the commit you added in the meantime. I've reproduced it as the last commit on this branchplease rerun
dotnet build /t:GenerateTestto update samples (dotnet build /t:GenerateTestsif you synced up with main).
Ah, I didn't realise that would make a difference, I've now updated the samples