Eventhub with Cleanup Policy

[schaudhari6254888]

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

[azure-sdk]

API change check

APIView has identified API level changes in this PR and created following API reviews.

Azure.ResourceManager.EventHubs

[damodaravadhani]

Hey @Yao725, the build points to the obsolete MessageRetentionInDays. Should we suppress the build error or have I made a mistake here ?

[Yao725]

Hey @Yao725 Yao Kou FTE, the build points to the obsolete MessageRetentionInDays. Should we suppress the build error or have I made a mistake here ?

@damodaravadhani, in my understanding, this property MessageRetentionInDays should be removed in the swagger as you said, so I suggest you adding the customized code to avoid breaking change and build failure. However, it looks like this property still exists, so you should remove the customization and just let the generator generate the code. And I'm also wondering if I misunderstood something here.

[damodaravadhani]

@Yao725 , as far as I can see, the generation did remove the property after rendering it obsolete, not really sure what we need to do next. Do you have any suggestions ?

[schaudhari6254888]

This is PR which Contain eventhub cleanup policy feature i.e "delete" & "compact". Also has the alert for removal message of messageRetentionInDays as it is replaced with retentionTimeInHour in future. can someone please look into this & review this. Thank you in advance!