azure-sdk-for-net icon indicating copy to clipboard operation
azure-sdk-for-net copied to clipboard

Azure.Messaging.ServiceBus migration guide does not mention breaking changes to correlation

Open simonness opened this issue 2 years ago • 3 comments

The migration guide for migrating to Azure.Messaging.ServiceBus from Microsoft.Azure.ServiceBus, does not mention some important breaking changes to correlation, should this be mentioned and is there general advice how best to maintain this functionality?

In Microsoft.Azure.ServiceBus a Correlation-Context header flowed between sender and receiver, a list of key value pairs representing activity baggage (see Microsoft.Azure.ServiceBus/src/Extensions/MessageDiagnosticsExtensions.cs). This automatic behaviour was incredibly useful in distributed architectures that typically use Azure Service Bus as telemetry in the Application Insights for the message receiver would automatically have Custom Properties that give context to the message (any activity baggage items added upstream by the sender).

simonness avatar Dec 22 '22 08:12 simonness

Thank you for your feedback. Tagging and routing to the team member best able to assist. Please be aware that responses will be delayed due to the US holidays.

jsquire avatar Dec 22 '22 16:12 jsquire

@jsquire, @JoshLove-msft I hope you had a nice break. Any guidance you can give on this one would be most appreciated :)

simonness avatar Jan 09 '23 12:01 simonness

Hi @simonness, Thanks for raising this issue. In the new library, our plan is to adhere to the Open Telemetry semantics. As such, there are some changes to how telemetry works from the legacy library. We will update our migration guide to include this information.

JoshLove-msft avatar Jan 09 '23 19:01 JoshLove-msft