azure-sdk-for-js icon indicating copy to clipboard operation
azure-sdk-for-js copied to clipboard

Enable publishing for packages previously excluded from Docs MS

Open danieljurek opened this issue 1 year ago • 3 comments
trafficstars

Fixes #26770

I have tested and validated that these packages will work with the new type2docfx docs build system and this PR enables docs.ms publishing.

@xirzec -- When searching through ci.yml files I noticed two places where we intentionally skip publishing docs on docs.ms:

  • https://github.com/Azure/azure-sdk-for-js/blob/main/sdk/communication/ci.yml#L64-L69
  • https://github.com/Azure/azure-sdk-for-js/blob/main/sdk/test-utils/ci.yml#L32-L49

In both of these instances these are @azure-tools/___ packages. I left these untouched. Should docs be published for these on docs.microsoft.com whenever they release?

danieljurek avatar Sep 24 '24 22:09 danieljurek

I think the test-utils ones we can leave unpublished as those are internal /cc @HarshaNalluru to confirm

The ACS ones I'm less familiar with @akania do you have any thoughts here?

xirzec avatar Oct 03 '24 20:10 xirzec

I agree with @xirzec, test-utils should be left unpublished.

HarshaNalluru avatar Oct 04 '24 21:10 HarshaNalluru

@akania we're currently skipping docs publishing for @azure-tools/communication-recipient-verification and @azure-tools/communication-tiering... should those packages be published on docs.ms when they release preview or GA versions?

https://github.com/Azure/azure-sdk-for-js/blob/main/sdk/communication/ci.yml#L64-L69

danieljurek avatar Oct 17 '24 16:10 danieljurek