azure-sdk-for-js
azure-sdk-for-js copied to clipboard
Generate and implement Face SDK via TypeSpec
Packages impacted by this PR
@azure-rest/ai-vision-face
Issues associated with this PR
Describe the problem that is addressed by this PR
Generate and implement Face SDK via TypeSpec.
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
- [ ] Added a changelog (if necessary)
Thank you for your contribution @chungshengfu! We will review the pull request and get back to you soon.
/azp run prepare-pipelines
Azure Pipelines successfully started running 1 pipeline(s).
/azp run js - face - ci
Azure Pipelines successfully started running 1 pipeline(s).
should we have asset.json checked in after the test recordings are uploaded?
the ci is failing for various reasons, please follow the step here to make sure you have done everything after the generation. https://github.com/Azure/azure-sdk-for-js/blob/main/documentation/steps-after-generations.md. I notice this step is missing
And about the link verification, please finish the above step then follow the instructions here https://github.com/Azure/azure-sdk-for-js/blob/main/documentation/Troubleshoot-ci-failure.md#broken-links to fix the problem, thanks
should we have asset.json checked in after the test recordings are uploaded?
Thanks for reminder. I will check the process.
the ci is failing for various reasons, please follow the step here to make sure you have done everything after the generation.
The generated samples
was intentionally removed. Let me put it back.
There seems to be custom code mixed in with the generated code. Could you help me understand what is custom and the reasons we need it?
The customization includes the followings:
- Make
detectionModel
,recognitionModel
,returnFaceId
ofDetectFromUrlQueryParamProperties
andDetectQueryParamProperties
mandatory. API definition says they are optional, but we want the invocation to be more explicit. - Classify
FaceAttributeType
by the supporting detection/recognition models to reduce the cost of misusing these constants. - Give
filename
ofCreateLivenessWithVerifySessionContentVerifyImagePartDescriptor
a default value. It's required by backend but makes no sense to clients.
If we really need custom code, let's follow the customization guide. But I would like to make sure that we really need it, usually Rest Level Clients don't need customization
I didn't find the customization guide. Could you please share it with me? Thanks.
/azp run js - face - ci
Pull request contains merge conflicts.
/azp run js - face - ci
No pipelines are associated with this pull request.
/azp run prepare-pipelines
Azure Pipelines successfully started running 1 pipeline(s).
/azp run js - face - ci
Azure Pipelines successfully started running 1 pipeline(s).
API change check
APIView has identified API level changes in this PR and created following API reviews.
LGTM
Thanks for this pr! I left some comments and I think I could give the approval once them addressed.
@MaryGao @chungshengfu please checkout "extraFiles" in
"//sampleConfiguration"` section to see if it helps
https://github.com/Azure/azure-sdk-for-js/blob/4a102992b453f41e41977754966ece992eca4b87/sdk/formrecognizer/ai-form-recognizer/package.json#L149-L178