azure-sdk-for-js icon indicating copy to clipboard operation
azure-sdk-for-js copied to clipboard

[Recorder] Batch Sanitizers

Open HarshaNalluru opened this issue 9 months ago • 1 comments

Packages impacted by this PR

@azure-tools/test-recorder and all the tests in this repo.

Issues associated with this PR

Supporting this would reduce the number of requests to the test-proxy

  • speed up recording the tests
  • reduce the flakiness and timeouts with test-proxy .

Describe the problem that is addressed by this PR

Adds support for batch addition of sanitizers https://github.com/Azure/azure-sdk-tools/tree/main/tools/test-proxy/Azure.Sdk.Tools.TestProxy#passing-sanitizers-in-bulk

HarshaNalluru avatar Apr 30 '24 09:04 HarshaNalluru

I didn't know we could do this, this is way better than adding each sanitizer individually.

This feature was added more than six months after the JS recorder was built it seems. @timovv

In what order does the test proxy apply the sanitizers when using this bulk operation? Is it in the order they appear in the request?

Scott says yes.

HarshaNalluru avatar Apr 30 '24 22:04 HarshaNalluru