azure-sdk-for-js icon indicating copy to clipboard operation
azure-sdk-for-js copied to clipboard

[@azure/openai] Fix the Return Type of Error

Open sarangan12 opened this issue 1 year ago • 2 comments

Packages impacted by this PR

@azure/openai

Issues associated with this PR

NA

Describe the problem that is addressed by this PR

In @azure/openai package, when an error is returned, it must be of instance RestError. But, it is not returned like that. This needs to be fixed. It has to be fixed in the generator. Timo seems to be working on this already. In the meantime, we are fixing this on our end for 2 reasons. We need to fix it before GA. LangChain JS SDK is waiting for this fix.

What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?

No special design considerations.

Are there test cases added in this PR? (If not, why?)

No. Existing test cases handle the scenarios very well.

Provide a list of related PRs (if any)

NA

Command used to generate this PR:**(Applicable only to SDK release request PRs)

NA

Checklists

  • [X] Added impacted package name to the issue description
  • [ ] Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
  • [ ] Added a changelog (if necessary)

@deyaaeldeen @minhanh-phan Please review and approve.

@xirzec FYI....

sarangan12 avatar Feb 22 '24 23:02 sarangan12

API change check

API changes are not detected in this pull request.

azure-sdk avatar Feb 22 '24 23:02 azure-sdk

Hi @sarangan12. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

github-actions[bot] avatar May 03 '24 05:05 github-actions[bot]

Hi @sarangan12. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing /reopen if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the no-recent-activity label; otherwise, this is likely to be closed again with the next cleanup pass.

github-actions[bot] avatar May 10 '24 08:05 github-actions[bot]