azure-sdk-for-js icon indicating copy to clipboard operation
azure-sdk-for-js copied to clipboard

Published 20 hours ago • verified publisher icon Azure

[app-config] Migrate to new recorder

Open minhanh-phan opened this issue 2 years ago • 4 comments

Packages impacted by this PR

app-configuration

Issues associated with this PR

#18010

Describe the problem that is addressed by this PR

Migrate the services to the new unified recorder

What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?

Are there test cases added in this PR? (If not, why?)

Provide a list of related PRs (if any)

Command used to generate this PR:**(Applicable only to SDK release request PRs)

Checklists

  • [ ] Added impacted package name to the issue description
  • [ ] Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
  • [ ] Added a changelog (if necessary)

minhanh-phan avatar Oct 14 '22 17:10 minhanh-phan

API change check

API changes are not detected in this pull request.

azure-sdk avatar Oct 14 '22 18:10 azure-sdk

Formatting failures.. looks like, please update 🙂

HarshaNalluru avatar Oct 14 '22 20:10 HarshaNalluru

Looks like the playback tests are failing, can you check why?

HarshaNalluru avatar Oct 14 '22 20:10 HarshaNalluru

Looks like the playback tests are failing, can you check why?

I believe it has to do with updating the clients' additional options through recorder.configureClientOptions(). I'm working on it now.

minhanh-phan avatar Oct 14 '22 20:10 minhanh-phan