azure-sdk-for-js icon indicating copy to clipboard operation
azure-sdk-for-js copied to clipboard

Add Azure DevCenter Package

Open chrissmiller opened this issue 2 years ago • 14 comments

Packages impacted by this PR

@azure-rest/developer-devcenter

Issues associated with this PR

https://github.com/Azure/azure-sdk/issues/4702

Describe the problem that is addressed by this PR

There is not an existing package for the Azure DevCenter service :)

What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?

N/A

Are there test cases added in this PR? (If not, why?)

Yes, test coverage for service hero scenarios

Provide a list of related PRs (if any)

N/A

Command used to generate this PR:**(Applicable only to SDK release request PRs)

N/A

Checklists

  • [x] Added impacted package name to the issue description
  • [x] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the Autorest/typescript repository and link it here)_Yes: https://github.com/Azure/autorest.typescript/issues/1615 We also have an issue with testrecorder: https://github.com/Azure/azure-sdk-for-js/issues/23420.
  • [x] Added a changelog (if necessary)

chrissmiller avatar Oct 07 '22 02:10 chrissmiller

@MaryGao Let us know of any other issues we can resolve! Appreciate your feedback here :)

chrissmiller avatar Oct 11 '22 20:10 chrissmiller

@qiaozha Could you help provide your comments? Thanks!

MaryGao avatar Oct 14 '22 02:10 MaryGao

/azp run prepare-pipelines

MaryGao avatar Oct 17 '22 06:10 MaryGao

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Oct 17 '22 06:10 azure-pipelines[bot]

/azp run js - devcenter - ci

MaryGao avatar Oct 17 '22 06:10 MaryGao

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Oct 17 '22 06:10 azure-pipelines[bot]

/azp run js - devcenter - ci

If your package is the first time to enable pipeline pls run the above command to trigger it.

I notice there exists the ci error https://dev.azure.com/azure-sdk/public/_build/results?buildId=1922720&view=logs&j=b70e5e73-bbb6-5567-0939-8415943fadb9&t=a880e989-7d1a-5c96-a41f-d540b383cc43.

This is caused the unknown keyword devcenter and devboxes. @chrissmiller Could you confirm that these keywords are reviewed and agreed in arch board review?

If so please add them to file https://github.com/Azure/azure-sdk-for-js/blob/main/.vscode/cspell.json to bypass this check. You could read more here https://github.com/Azure/azure-sdk-tools/blob/main/doc/common/spellcheck.md.

MaryGao avatar Oct 17 '22 07:10 MaryGao

/azp run js - devcenter - ci

If your package is the first time to enable pipeline pls run the above command to trigger it.

I notice there exists the ci error https://dev.azure.com/azure-sdk/public/_build/results?buildId=1922720&view=logs&j=b70e5e73-bbb6-5567-0939-8415943fadb9&t=a880e989-7d1a-5c96-a41f-d540b383cc43.

This is caused the unknown keyword devcenter and devboxes. @chrissmiller Could you confirm that these keywords are reviewed and agreed in arch board review?

If so please add them to file https://github.com/Azure/azure-sdk-for-js/blob/main/.vscode/cspell.json to bypass this check. You could read more here https://github.com/Azure/azure-sdk-tools/blob/main/doc/common/spellcheck.md.

@MaryGao FYI, those terms were approved by Arch Board, so I will proceed with adding them to cspell.json. (cc @chrissmiller as well)

sebrenna avatar Oct 17 '22 18:10 sebrenna

/azp run js - devcenter - ci

chrissmiller avatar Oct 18 '22 03:10 chrissmiller

Pull request contains merge conflicts.

azure-pipelines[bot] avatar Oct 18 '22 03:10 azure-pipelines[bot]

/azp run js - devcenter - ci

chrissmiller avatar Oct 18 '22 04:10 chrissmiller

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Oct 18 '22 04:10 azure-pipelines[bot]

/azp run js - devcenter - ci

Please notice you don't need to run the pipeline manually if you set up them correctly (you only need to do this at the first time). The ci will be triggered automatically once you push any change into your pr.

MaryGao avatar Oct 18 '22 04:10 MaryGao

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-rest-developer-devcenter

azure-sdk avatar Oct 18 '22 04:10 azure-sdk