azure-sdk-for-js icon indicating copy to clipboard operation
azure-sdk-for-js copied to clipboard

Published 20 hours ago • verified publisher icon Azure

Move defaultLogPolicy to after Sign phase

Open dgetu opened this issue 2 years ago • 1 comments

This change pushes logging to the end of the pipeline, allowing for retried requests to be logged.

Fixes #20910

dgetu avatar Aug 17 '22 23:08 dgetu

API change check

API changes are not detected in this pull request.

azure-sdk avatar Aug 17 '22 23:08 azure-sdk

Good job on this clean change!

There is a test failure in the Browser test, the reason seems to be that we don't add all the policies when running in the browser

image

you may want to modify your expected policies based on isNode.

I forgot to put that in the commit message, but that's done. Hoping you could take another look before we merge this one.

dgetu avatar Aug 19 '22 18:08 dgetu