azure-sdk-for-js icon indicating copy to clipboard operation
azure-sdk-for-js copied to clipboard

Device Update for IoT Hub GA release updates

Open dpokluda opened this issue 2 years ago • 1 comments

Packages impacted by this PR

iot-device-update-rest

Issues associated with this PR

n/a

Describe the problem that is addressed by this PR

update service for GA release

What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?

n/a

Are there test cases added in this PR? (If not, why?)

Provide a list of related PRs (if any)

Command used to generate this PR:**(Applicable only to SDK release request PRs)

autorest --typescript ./README.md --use=@autorest/[email protected]

Checklists

  • [ ] Added impacted package name to the issue description
  • [ ] Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
  • [x] Added a changelog (if necessary)

dpokluda avatar Aug 15 '22 23:08 dpokluda

@dpokluda There's some build failure in samples-dev folder, Can you fix them and update the samples folder as well ? Thanks

qiaozha avatar Aug 17 '22 08:08 qiaozha

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-rest-iot-device-update

azure-sdk avatar Aug 24 '22 20:08 azure-sdk

The build issues (samples) were fixed.

dpokluda avatar Aug 24 '22 21:08 dpokluda

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: /check-enforcer evaluate Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command: /check-enforcer override Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment: /azp run prepare-pipelines This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment: /azp run js - [service] - ci

check-enforcer[bot] avatar Sep 01 '22 20:09 check-enforcer[bot]

Hello @joheredi!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

msftbot[bot] avatar Sep 09 '22 16:09 msftbot[bot]