azure-sdk-for-js icon indicating copy to clipboard operation
azure-sdk-for-js copied to clipboard

Published 20 hours ago • verified publisher icon Azure

[storage-blob] Escape path like dotnet for storage blob names (exclude path separator from encoding)

Open mwiedemeyer opened this issue 2 years ago • 3 comments

Packages impacted by this PR

storage-blob

Issues associated with this PR

#22568

Describe the problem that is addressed by this PR

Change the encoding of blobNames to exclude the path separator /.

Before:

https://mystorageaccount.blob.core.windows.net/my-container/folderA%2Fblob.txt

After:

https://mystorageaccount.blob.core.windows.net/my-container/folderA/blob.txt

mwiedemeyer avatar Jul 20 '22 09:07 mwiedemeyer

Thank you for your contribution mwiedemeyer! We will review the pull request and get back to you soon.

msftbot[bot] avatar Jul 20 '22 09:07 msftbot[bot]

@EmmaZhu please have a look

jeremymeng avatar Jul 26 '22 18:07 jeremymeng

There are some test failures due to record session not match. I'll update these test cases, then we can merge the PR.

EmmaZhu avatar Jul 28 '22 02:07 EmmaZhu

It seems that the checks are now running successfully. Just the last one failed with a timeout after 60minutes. Can you please check if it can be merged @EmmaZhu ?

mwiedemeyer avatar Sep 19 '22 12:09 mwiedemeyer

@mwiedemeyer

Seems browser cases failed due to outdated record session. Could you take this PR https://github.com/mwiedemeyer/azure-sdk-for-js/pull/2?

Apologize for the inconvenience.

EmmaZhu avatar Sep 21 '22 08:09 EmmaZhu

Thanks @EmmaZhu now the checks completed successfully. I would be more than happy if the PR will be merged soon 😉

mwiedemeyer avatar Sep 21 '22 09:09 mwiedemeyer

Thanks a lot @mwiedemeyer for the contribution.

EmmaZhu avatar Sep 22 '22 03:09 EmmaZhu