azure-sdk-for-js icon indicating copy to clipboard operation
azure-sdk-for-js copied to clipboard

Azure Cosmos Samples Issue

Open v-jiaodi opened this issue 4 years ago • 13 comments

Section link

image

Reason:
The query result still includes the given item which the indexingDirective is exclude. Some details are as follows:

image

Section link

image

Reason:
Expecting an exception on this query due to the fact that it includes paths /metaData/* that have been excluded. But there is no problem with the query results. Some details are as follows:

image

Section link:

image

Reason: nodejs does not support the export with export. Some details are as follows:

image

@lilyjma , @ramya-rao-a , @meeraharidasa , @mayurid @southpolesteve and @jongio for notification.

v-jiaodi avatar May 31 '21 06:05 v-jiaodi

@ramya-rao-a - Please help assign this issue to the corresponding member?

v-xuto avatar Jul 06 '21 06:07 v-xuto

Thanks @v-xuto

@zfoster, Can you please review the recommended fixes above? If you agree, then @v-xuto can send a PR to fix them

ramya-rao-a avatar Jul 08 '21 21:07 ramya-rao-a

I'll happily take a PR to fix them, I'm unsure on the issue in the first one but the latter 2 look pretty straightforward. I don't see the recommended fixes though, maybe it was edited?

zfoster avatar Jul 08 '21 22:07 zfoster

@zfoster The first issue is similar to the second one. Create an item and set indexingDirective : "exclude", we can query the items. But We don't expect to find any item. Is there anything else I need to offer on the first issue?

Besides, we don't have the recommended fixes, just describing this issue.

v-jiaodi avatar Jul 09 '21 06:07 v-jiaodi

Ah! sorry about the comment on recommended fixes in that case.

@zfoster What would your recommendation be?

ramya-rao-a avatar Jul 09 '21 06:07 ramya-rao-a

I think we need to investigate why the first and second directives aren't behaving as expected, for the last issue I think we can fix whatever ts-node doesn't like

zfoster avatar Jul 09 '21 12:07 zfoster

@zfoster Do you have any progress on this issue?

v-xuto avatar Aug 26 '21 08:08 v-xuto

Not yet, I don't have an ETA on this work at this time

zfoster avatar Aug 26 '21 12:08 zfoster

@zfoster Hello, I want to deep dive into this issues to fix - will share my pull request later but any sharing on recommendations would be appreciated!

binarybamboo avatar Oct 04 '21 06:10 binarybamboo

Sharing my test result for 1 - from my investigation, #1 is not an SDK issue - @zfoster: would you confirm whether it is a really SDK bug or not?

  • detail results: Data from link

    SELECT COUNT(c.foodGroup) FROM c ORDER BY c.foodGroup ASC, c.manufactureName ASC
    

    The investigation was conducted with the query statement above, and the result values are as follows.

    1. Original OUTPUT) count:8620, time:518.41 RUs

    2. After adding 8 values with option 'Include' OUTPUT) count:8628, time:516.05 RUs

    3. After adding 10 values with option 'Exclude' OUTPUT) count:8638, time:516.810 RUs

According to the above results, indexing seems to continue even if the 'Exclusive' option is given.

binarybamboo avatar Nov 23 '21 15:11 binarybamboo

@sajeetharan , @kushagraThapar , @simorenoh Is there any progress on this issue so far?

v-xuto avatar Mar 15 '22 08:03 v-xuto

@v-xuto Not yet, Thanks for notifying again, We will investigate and update the progress here

sajeetharan avatar Mar 15 '22 15:03 sajeetharan

@sajeetharan Is there any progress on this issue?

v-xuto avatar Oct 14 '22 09:10 v-xuto

@sajeetharan , @v1k1 Is there any progress on this issue?

v-xuto avatar Mar 10 '23 07:03 v-xuto

Hi @v-jiaodi, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

github-actions[bot] avatar Mar 15 '24 18:03 github-actions[bot]