azure-sdk-for-js icon indicating copy to clipboard operation
azure-sdk-for-js copied to clipboard

Published 20 hours ago • verified publisher icon Azure

[storage][recording] "sr" query parameter should added to the ignore list

Open jeremymeng opened this issue 4 years ago • 4 comments

Recording now saves it

image.png

https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/storage/storage-queue/test/utils/testutils.common.ts#L34

jeremymeng avatar Jul 17 '20 06:07 jeremymeng

Ignore iprange - sip as well?

ljian3377 avatar Nov 03 '20 08:11 ljian3377

@ljian3377 @EmmaZhu please ignore all new parameters so they don't cause mismatch when playing back.

jeremymeng avatar May 11 '21 22:05 jeremymeng

@jeremymeng

After recording, I'll run the call test cases again with playback mode. Are there any further actions needed to make sure the recording is correct?

Thanks Emma

EmmaZhu avatar May 12 '21 02:05 EmmaZhu

@EmmaZhu you shouldn't need to regenerate the recording I think? What I found was some connection string copied from the Azure portal would have sr but not all connection strings have them. It could be because of SKU difference, or service version difference. Our existing recordings don't have that, so we just need to ignore them in the queryParametersToSkip list

jeremymeng avatar May 12 '21 15:05 jeremymeng