azure-sdk-for-java icon indicating copy to clipboard operation
azure-sdk-for-java copied to clipboard

[o11y] Fix some attributes to match Otel Semantic Conventions

Open lloydmeta opened this issue 8 months ago • 2 comments

Description

  • Added azure.cosmosdb.response.sub_status_code to reflect this too since it's the non-deprecated label
  • Added azure.cosmosdb.operation.request_charge to reflect this too

Sources

  • https://github.com/open-telemetry/semantic-conventions/blob/723789b86a803492d03191b458138fff6e7a6b9f/docs/registry/attributes/db.md#db-cosmosdb-request-charge
  • https://opentelemetry.io/docs/specs/semconv/registry/attributes/azure/#azure-cosmosdb-operation-request-charge

All SDK Contribution checklist:

  • [x] The pull request does not introduce [breaking changes]
  • [x] CHANGELOG is updated for new features, bug fixes or other significant changes.
  • [x] I have read the contribution guidelines.

General Guidelines and Best Practices

  • [x] Title of the pull request is clear and informative.
  • [x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • [x] Pull request includes test coverage for the included changes.

Closes https://github.com/Azure/azure-sdk-for-java/issues/45752

lloydmeta avatar Jun 18 '25 13:06 lloydmeta

Thank you for your contribution @lloydmeta! We will review the pull request and get back to you soon.

github-actions[bot] avatar Jun 18 '25 13:06 github-actions[bot]

@microsoft-github-policy-service agree

lloydmeta avatar Jun 18 '25 13:06 lloydmeta

Thanks for reviewing @FabianMeiswinkel ; any idea when this can be merged? Would it require @kirankumarkolli to do so?

lloydmeta avatar Jun 21 '25 04:06 lloydmeta