azure-sdk-for-java icon indicating copy to clipboard operation
azure-sdk-for-java copied to clipboard

[App Configuration] Not log value of key

Open ivywei0125 opened this issue 1 year ago • 1 comments

Description

When content type is json, we'll check if the value is a valid json. If invalid, throw JsonProcessingException.

Before fix, for a key-value: test_key: test_value, the error message in the log is as the following, contains the value "test_value". "com.fasterxml.jackson.core.JsonParseException: Unrecognized token 'test_value_3': was expecting (JSON String, Number, Array, Object or token 'null', 'true' or 'false') at [Source: (String)"test_value_3"; line: 1, column: 13]"

We shouldn't include the value in logs to avoid any security issue. After fix, the error message is: "java.io.IOException: Invalid value of key '/foo/test_key_3'. Expected type: JSON String, Number, Array, Object or token 'null', 'true' or 'false'"

ivywei0125 avatar May 13 '24 08:05 ivywei0125

API change check

API changes are not detected in this pull request.

azure-sdk avatar May 13 '24 08:05 azure-sdk