azure-sdk-for-java icon indicating copy to clipboard operation
azure-sdk-for-java copied to clipboard

Radiology insights GA

Open koen-mertens opened this issue 10 months ago • 8 comments

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • [ ] The pull request does not introduce [breaking changes]
  • [ ] CHANGELOG is updated for new features, bug fixes or other significant changes.
  • [ ] I have read the contribution guidelines.

General Guidelines and Best Practices

  • [ ] Title of the pull request is clear and informative.
  • [ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • [ ] Pull request includes test coverage for the included changes.

koen-mertens avatar Apr 19 '24 06:04 koen-mertens

API change check

APIView has identified API level changes in this PR and created following API reviews.

com.azure:azure-health-insights-radiologyinsights

azure-sdk avatar Apr 22 '24 20:04 azure-sdk

There is FhirR4## classes that could be duplicated in future module from healthinsights (e.g. cancerprofiling, clinicalmatching, etc.). And it would be very hard to move them to shared lib, after GA.

Do we have a decision on this?

weidongxu-microsoft avatar May 08 '24 01:05 weidongxu-microsoft

There is FhirR4## classes that could be duplicated in future module from healthinsights (e.g. cancerprofiling, clinicalmatching, etc.). And it would be very hard to move them to shared lib, after GA.

Do we have a decision on this?

That has been discussed and the current decision was not to have a shared lib.

hvanhoe avatar May 08 '24 08:05 hvanhoe

There is discussion of the method signature of the LRO API in apiview https://apiview.dev/Assemblies/Conversation/c48b47bd12a6493aa27b2cec58f9e54e#46f262e257de451485c82b43abb61bb5

Please reach a decision (if possible in SDK review meeting, for cross-language agreement). I can help you customize this API whatever the decision be (the customize on method parameter should be very simple; the customize on method return would need some knowledge). Ping me when you need my help.

weidongxu-microsoft avatar May 09 '24 02:05 weidongxu-microsoft

/azp run java - healthinsights - ci

KarolGel avatar Jun 27 '24 12:06 KarolGel

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jun 27 '24 12:06 azure-pipelines[bot]

/azp run java - healthinsights - ci

KarolGel avatar Jun 28 '24 08:06 KarolGel

Pull request contains merge conflicts.

azure-pipelines[bot] avatar Jun 28 '24 08:06 azure-pipelines[bot]

The branch seems having problem. There's 2516 files

weidongxu-microsoft avatar Jul 09 '24 02:07 weidongxu-microsoft

The branch seems having problem. There's 2516 files There's also over 1200 Checks which pretty much amounts to the build storm that's happening. @koen-mertens I think the base way to sort this out is to rebase you branch on top of main.

JimSuplizio avatar Jul 09 '24 23:07 JimSuplizio

I'm going to close this to kill the build storm and I'm going to recommend recreating the PR after rebasing.

JimSuplizio avatar Jul 09 '24 23:07 JimSuplizio