azure-sdk-for-java icon indicating copy to clipboard operation
azure-sdk-for-java copied to clipboard

Published 20 hours ago • verified publisher icon Azure

Migrate spring data cosmos modules to sdk/spring dir

Open moarychan opened this issue 1 year ago • 5 comments

Description

Fixes https://github.com/Azure/azure-sdk-for-java/issues/30793 https://github.com/Azure/azure-sdk-for-java/issues/30458

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • [ ] The pull request does not introduce [breaking changes]
  • [ ] CHANGELOG is updated for new features, bug fixes or other significant changes.
  • [ ] I have read the contribution guidelines.

General Guidelines and Best Practices

  • [ ] Title of the pull request is clear and informative.
  • [ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • [ ] Pull request includes test coverage for the included changes.

moarychan avatar Sep 08 '22 10:09 moarychan

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-spring-data-cosmos spring-cloud-azure-autoconfigure spring-cloud-azure-core spring-messaging-azure-eventhubs spring-messaging-azure-servicebus

azure-sdk avatar Sep 08 '22 11:09 azure-sdk

/azp run java - spring - tests

moarychan avatar Sep 09 '22 08:09 moarychan

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Sep 09 '22 08:09 azure-pipelines[bot]

@kushagraThapar there are some test failures in the spring data auditable feature when enabling azure-spring-data-cosmos integration tests, the attribute value of the date type returned by the cosmos service is larger than the actual value, and the difference is a nanosecond deviation, this doesn't happen every time. Could you help follow up on this issue in the main branch first?

moarychan avatar Sep 20 '22 09:09 moarychan

The below failures will be fixed later:

  • Some broken links in branch 6.x, maybe a pipeline bug.
  • Cosmos IT failures, which may be fixed in main branch first.
  • Ignore the compatibility test for Spring Boot 3.0.0-M3, because the break changes in Spring Data from 3.0.0-M4 to 3.0.0-M5. This PR is ready to merge, @saragluna please help to review, thanks!

moarychan avatar Sep 20 '22 10:09 moarychan

Close this one, new PR is comming.

moarychan avatar Oct 09 '22 06:10 moarychan