azure-sdk-for-java
azure-sdk-for-java copied to clipboard
Loadtestservice - SDK initial version
Description
First time generated SDK for Azure Load Testing service (sdk/loadtestservice) using Swagger (https://github.com/Azure/azure-rest-api-specs/blob/9401446f22177696d920cf110893a0de7452ee9e/specification/loadtestservice/data-plane/readme.md)
- Auth using AADToken
- "multipart/form-data" file upload implemented manually using ByteStream.
- Has samples and tests for common champion scenario
- Uses BinaryData for all methods.
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
- [x] The pull request does not introduce [breaking changes]
- [ ] CHANGELOG is updated for new features, bug fixes or other significant changes.
- [x] I have read the contribution guidelines.
General Guidelines and Best Practices
- [x] Title of the pull request is clear and informative.
- [x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
Testing Guidelines
- [x] Pull request includes test coverage for the included changes.
- What is the recommended approach for implementing multipart/form-data in SDK? Currently, external dependencies are not allowed, hence cannot use apache.httpcomponents.httpmime package for generating multipart/form-data request body.
- Autorest generates BinaryData for all method. Is it expected/recommended to replace them with autogenerated models after removing "@generated" decorator?
cc// @JonathanGiles @conniey @joshfree
README, tests and samples will be updated after resolving the functionality issues caused by multipart/form-data and BinaryData requests. Commits will be squashed when PR is ready to be merged
API change check
APIView has identified API level changes in this PR and created following API reviews.
@samvaity is going to help shepherd this PR into the main branch
@samvaity Most of the changes regarding README, samples and test cases can be fixed once the functionality of the APIs are approved, since tests and samples would require changes if there are changes in client method names
@weidongxu-microsoft @samvaity Reverted back to DPG with samples and multipart upload. Test recordings are remaining
@samvaity @weidongxu-microsoft Test recordings for champion scenario are added. Requesting review.
The pipeline errors are due to links using "Azure/azure-sdk-java/main/" instead of my branch in README.md. Merging the PR fixes it
@samvaity @weidongxu-microsoft Changes for administration subclients have been done. Requesting review. However, the pipelines fail even though test recordings are present. Is there anything that needs to be done to make the pipelines pass (except the broken links which would be fixed when PR is merged)
@weidongxu-microsoft @samvaity APIView link for the current version of SDK: https://apiview.dev/Assemblies/Review/95fbc680963e4a40ad0edc4c956357c4
This pull request is protected by Check Enforcer.
What is Check Enforcer?
Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.
Why am I getting this message?
You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.
What should I do now?
If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).
What if I am onboarding a new service?
Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run java - [service] - ci
/azp run prepare-pipelines
Commenter does not have sufficient privileges for PR 30706 in repo Azure/azure-sdk-for-java
Latest APIView: https://apiview.dev/Assemblies/Review/95fbc680963e4a40ad0edc4c956357c4?revisionId=172bab5d058e46bcacb3f712c6802c72&doc=False
APIView: https://apiview.dev/Assemblies/Review/95fbc680963e4a40ad0edc4c956357c4?revisionId=0e728a89e9b547458c3c1aa69ebbbead&doc=False
APIView: https://apiview.dev/Assemblies/Review/95fbc680963e4a40ad0edc4c956357c4?revisionId=0bdf51079291442eb9bb393757f88747&doc=False
Pending to be resolved before GA
- method signature "uploadTestFile" (should we use
Path file
instead ofString fileName, BinaryDate file
) - client/subclient structure
- enable jacoco and confirm test coverage
Also, apparently need to switch api-version to stable.