azure-sdk-for-java icon indicating copy to clipboard operation
azure-sdk-for-java copied to clipboard

AsyncCacheNonBlocking - Improve availability during replica movement

Open aayush3011 opened this issue 2 years ago • 8 comments

Description

The current AsyncCache on force refreshes removes the value. It then creates a new value and all incoming requests are stuck waiting for the new task to complete.

Issue If a single replica moves only 1 of the 4 replicas URIs is stale. The current async cache is blocking all requests until the value is updated. The 3 other replicas could be used to successfully complete requests.

Solution AsyncCacheNonBlocking was created. This async cache does not block requests on refresh. It instead returns the stale value until the refresh is complete. Then the refresh value is used to update the cache. Any request using the forceRefresh to true will wait on the same refresh task.

All SDK Contribution checklist:

  • [ ] The pull request does not introduce [breaking changes]
  • [ ] CHANGELOG is updated for new features, bug fixes or other significant changes.
  • [ ] I have read the contribution guidelines.

General Guidelines and Best Practices

  • [x] Title of the pull request is clear and informative.
  • [ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • [x] Pull request includes test coverage for the included changes.
  • [x] Benchmark Tests
  • [x] Benchmark Tests:

RU: 100,000, Documents: 100,000, Region: South Central US

Throughput: image

P95 Latency image

P99 Latency image

P999 Latency image

Max Latency image

aayush3011 avatar Jun 09 '22 00:06 aayush3011

/azp run java - cosmos - tests

aayush3011 avatar Jul 07 '22 19:07 aayush3011

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jul 07 '22 19:07 azure-pipelines[bot]

/azp run java - cosmos - tests

aayush3011 avatar Jul 14 '22 01:07 aayush3011

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jul 14 '22 01:07 azure-pipelines[bot]

/azp run java - cosmos - tests

aayush3011 avatar Jul 19 '22 18:07 aayush3011

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jul 19 '22 18:07 azure-pipelines[bot]

/azp run java - cosmos - tests

aayush3011 avatar Jul 20 '22 16:07 aayush3011

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jul 20 '22 16:07 azure-pipelines[bot]

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: /check-enforcer evaluate Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command: /check-enforcer override Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment: /azp run prepare-pipelines This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment: /azp run java - [service] - ci

check-enforcer[bot] avatar Aug 21 '22 20:08 check-enforcer[bot]