azure-sdk-for-go
azure-sdk-for-go copied to clipboard
Bug: `no Host in request URL` when trying to list billing periods
Bug Report
-
import path of package in question:
github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/billing/armbilling -
SDK version:
github.com/Azure/azure-sdk-for-go/sdk/azcore v1.6.0github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/billing/armbilling v0.5.0
-
output of
go version:go version go1.21.0 darwin/arm64 -
What happened?
Listing billing periods fails with no Host in request URL
- What did you expect or want to happen?
No error should happen
- How can we reproduce it?
Example code in https://github.com/cloudquery/cloudquery/blob/72e71a0fa3ca2ab4a97c1fa172e58c6bb6f75002/plugins/source/azure/client/client.go#L156
I think it only happens if there's more than 1 page
- Anything we should know about your environment.
Original issue in https://github.com/cloudquery/cloudquery/issues/13870. This seems to be similar to https://github.com/Azure/azure-sdk-for-go/issues/19415 as the billing periods client doesn't join NextLink with the endpoint, see https://github.com/Azure/azure-sdk-for-go/blob/eaef0e4e7118bdc95973e3cb9bef7af7d0e65492/sdk/resourcemanager/billing/armbilling/periods_client.go#L119
Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @cabbpt.
The returned nextLink from service should contain the host part. Involved service team to help.
Hi 👋 When are we expected to receive an update on the issue?
Hi @erezrokah, we deeply appreciate your input into this project. Regrettably, this issue has remained unresolved for over 2 years and inactive for 30 days, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.