azure-sdk-for-go icon indicating copy to clipboard operation
azure-sdk-for-go copied to clipboard

Data fields are missing from VirtualMachineScaleSetVMInstanceView data model

Open yewmsft opened this issue 2 years ago • 5 comments

Bug Report

  • import path of package: ".../services/compute/mgmt/2021-12-01/compute"

  • SDK version: all versions including master

  • output of go version: go version go1.18 darwin/arm64

  • What happened? VirtualMachineScaleSetVMInstanceView data model does not include all data fields return by http response. When calling REST API: GET https://management.azure.com/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/virtualMachineScaleSets/{vmScaleSetName}/virtualMachines/{instanceId}/instanceView?api-version=2022-03-01 We are receiving the following from http response body: { "placementGroupId": "21fc0ad4-8f8e-45ee-9633-e750670e71ec", "platformFaultDomain": 0, "computerName": "aks-agentpool-26843202-vmss000000", "osName": "ubuntu", "osVersion": "18.04", "vmAgent": {...}, "disks": [...], "extensions": [...], "hyperVGeneration": "V2", "statuses": [...] }

However, there is no hyperVGeneration, computerName, osName, osVersion properties in data model VirtualMachineScaleSetVMInstanceView image

  • What did you expect or want to happen? VirtualMachineScaleSetVMInstanceView data model to include the missing fields hyperVGeneration, computerName, osName, osVersion

  • How can we reproduce it? Call REST API GET https://management.azure.com/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/virtualMachineScaleSets/{vmScaleSetName}/virtualMachines/{instanceId}/instanceView?api-version=2022-03-01 and compare the http response with the VirtualMachineScaleSetVMInstanceView data model

  • Anything we should know about your environment. This applies to all environments and both track 1 and track 2 APIs

yewmsft avatar Sep 15 '22 22:09 yewmsft

The packages under /services are from the legacy SDK and no longer updated. Can you try module github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/compute/armcompute/v3, I believe this has the content you're looking for.

jhendrixMSFT avatar Sep 16 '22 15:09 jhendrixMSFT

Thanks @jhendrixMSFT. Currently, there are some gaps (such as cross-tenant auth, interface for mock unit testing, and etc.) for AKS to fully migrate to Track 2 SDK clients, especially vmss clients. Is it possible we could get this fix in a special release for track 1 SDK? +@haitch

yewmsft avatar Sep 16 '22 18:09 yewmsft

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @Drewm3, @avirishuv, @vaibhav-agar, @amjads1.

Issue Details

Bug Report

  • import path of package: ".../services/compute/mgmt/2021-12-01/compute"

  • SDK version: all versions including master

  • output of go version: go version go1.18 darwin/arm64

  • What happened? VirtualMachineScaleSetVMInstanceView data model does not include all data fields return by http response. When calling REST API: GET https://management.azure.com/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/virtualMachineScaleSets/{vmScaleSetName}/virtualMachines/{instanceId}/instanceView?api-version=2022-03-01 We are receiving the following from http response body: { "placementGroupId": "21fc0ad4-8f8e-45ee-9633-e750670e71ec", "platformFaultDomain": 0, "computerName": "aks-agentpool-26843202-vmss000000", "osName": "ubuntu", "osVersion": "18.04", "vmAgent": {...}, "disks": [...], "extensions": [...], "hyperVGeneration": "V2", "statuses": [...] }

However, there is no hyperVGeneration, computerName, osName, osVersion properties in data model VirtualMachineScaleSetVMInstanceView image

  • What did you expect or want to happen? VirtualMachineScaleSetVMInstanceView data model to include the missing fields hyperVGeneration, computerName, osName, osVersion

  • How can we reproduce it? Call REST API GET https://management.azure.com/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/virtualMachineScaleSets/{vmScaleSetName}/virtualMachines/{instanceId}/instanceView?api-version=2022-03-01 and compare the http response with the VirtualMachineScaleSetVMInstanceView data model

  • Anything we should know about your environment. This applies to all environments and both track 1 and track 2 APIs

Author: yewmsft
Assignees: lirenhe
Labels:

question, Compute, Service Attention, Mgmt

Milestone: -

ghost avatar Sep 19 '22 06:09 ghost

From the swagger definition of 2022-03-01, I could not find the properties hyperVGeneration, computerName, osName, osVersion either. I'll let service team to have a look.

tadelesh avatar Sep 19 '22 06:09 tadelesh

I will work with @am4234m and the VMSS swagger owners to get the swagger files updated so that this issue will be fixed in the SDKs.

Drewm3 avatar Sep 20 '22 00:09 Drewm3

This issue will be addressed in the new swagger version (2022-11-01), expected Dec 23rd, 2022

hilaryw29 avatar Dec 13 '22 02:12 hilaryw29

Swagger fix above has been merged, closing issue as resolved.

hilaryw29 avatar Mar 23 '23 20:03 hilaryw29