azure-sdk-for-cpp icon indicating copy to clipboard operation
azure-sdk-for-cpp copied to clipboard

Updated OpenTelemetry tests to use their own `SpanExporter` rather than depend on the `InMemorySpanExporter`.

Open LarryOsterman opened this issue 2 years ago • 1 comments

When discussing the recent break with the OpenTelemetry folks, they rather strongly recommended that I stop using the InMemorySpanExporter type (which apparently is an internal test hook).

This change updates the OpenTelemetry test collateral to use a custom SpanExporter used by the tests.

Pull Request Checklist

Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:

See the detailed list in the contributing guide.

  • [ ] C++ Guidelines
  • [ ] Doxygen docs
  • [ ] Unit tests
  • [ ] No unwanted commits/changes
  • [ ] Descriptive title/description
    • [ ] PR is single purpose
    • [ ] Related issue listed
  • [ ] Comments in source
  • [ ] No typos
  • [ ] Update changelog
  • [ ] Not work-in-progress
  • [ ] External references or docs updated
  • [ ] Self review of PR done
  • [ ] Any breaking changes?

LarryOsterman avatar Oct 20 '22 18:10 LarryOsterman

Ping :).

LarryOsterman avatar Oct 21 '22 20:10 LarryOsterman

Ping2 :)

LarryOsterman avatar Oct 24 '22 17:10 LarryOsterman