[BUG][Android][2.0.0-beta.1] Proguard obfuscation crashes the app

[bogdanmunteanu]

Describe the bug The app crashes when ACS SDK is instantiated on production environment ( code is obfuscated)

Exception or Stack Trace Same as https://github.com/Azure/Communication/issues/69

To Reproduce Steps to reproduce the behavior Deploy ACS SDK on a project and obfuscate the code and run.

Expected behavior The ACS SDK should not crash

Question Are the rules below enough for this not to happen or we require additional rules ?

-keep class com.skype.rt.** {*;}
-keep class com.azure.** {*;}
-keep class com.skype.android.** {*;}
-keep class com.microsoft.media.** {*;}
-keep class com.microsoft.dl.** {*;}

These rules should be on the main page of the Android repository or in any other form of documentation.

[vcolin7]

Hi @bogdanmunteanu, thanks for reporting this issue. Would you mind taking a look @jsaurezlee-msft? As reported, it looks like a similar issue was reported a while ago and a using the proposed ProGuard rules solved it. I guess it could be possible there's more packages to include.

On another note, I agree that documentation should mention this configuration if requiring it is a common occurrence. Do you know how often developers would need to do this @jsaurezlee-msft? If the answer is "all of them" we should look into modifying our own ProGuard config so this doesn't trickle down to end-users, unless making that change ends up break peoples builds.

[github-actions[bot]]

Hi @bogdanmunteanu, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.