azure-rest-api-specs icon indicating copy to clipboard operation
azure-rest-api-specs copied to clipboard

add 2024-10-01-preview version for soft delete types on ms resources

Open vivektherala opened this issue 1 year ago • 3 comments

ARM (Control Plane) API Specification Update Pull Request

[!TIP] Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • [ ] New resource provider.
  • [ ] New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • [ ] Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • [ ] Update existing version to fix OpenAPI spec quality issues in S360.
  • [ ] Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
  • [ ] Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood and followed the instructions by checking all the boxes:

  • [x] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • [ ] I have reviewed following Resource Provider guidelines, including ARM resource provider contract and REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run. This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

vivektherala avatar Oct 30 '24 18:10 vivektherala

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This is the public specs repo main branch which is not intended for iterative development.
    You must acknowledge that you understand that after this PR is merged, you won't be able to stop your changes from being published to Azure customers.
    If this is what you intend, add PublishToCustomers label to your PR.
    Otherwise, retarget this PR onto a feature branch, i.e. with prefix release- (see aka.ms/azsdk/api-versions#release--branches).
  • ❌ The required check named Automated merging requirements met has failed. This is the final check that must pass. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide. In addition, refer to step 4 in the PR workflow diagram

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/resources/armchanges There is no API change compared with the previous version
Go sdk/resourcemanager/databoundaries/armdataboundaries https://apiview.dev/Assemblies/Review/3b27b75210404b5dbf9ebc3f9c788414?revisionId=2466d9945a284a289118be9684ac76d4
Go sdk/resourcemanager/resources/armdeploymentscripts https://apiview.dev/Assemblies/Review/7baaae1d269a4ed7912f863425ad71a0?revisionId=04a20675a30a49b9bf034e28d484709a
Go sdk/resourcemanager/resources/armdeploymentstacks There is no API change compared with the previous version
Go sdk/resourcemanager/resources/armfeatures There is no API change compared with the previous version
Go sdk/resourcemanager/resources/armlinks There is no API change compared with the previous version
.Net Azure.ResourceManager.Resources There is no API change compared with the previous version
Go sdk/resourcemanager/resources/armlocks There is no API change compared with the previous version
Go sdk/resourcemanager/resources/armmanagedapplications There is no API change compared with the previous version
Go sdk/resourcemanager/resources/armpolicy https://apiview.dev/Assemblies/Review/307c195eccc840d1b92e75be6564ba10?revisionId=07c403a2d2e04cc5849c69f75f2deef3
Go sdk/resourcemanager/resources/armresources https://apiview.dev/Assemblies/Review/12843540e3a1467ea73d364496b55308?revisionId=a6ae4f2597d748cbab12bac5e3d752b5
Go sdk/resourcemanager/resources/armtemplatespecs There is no API change compared with the previous version
Java azure-resourcemanager-resources-generated https://apiview.dev/Assemblies/Review/69d90a3c09dd41d388271d10f46fbed8?revisionId=f96116fd2df1470295516422a8694ff2
JavaScript @azure/arm-changes https://apiview.dev/Assemblies/Review/357d9a1c28c440e8a1bd4912e73149e7?revisionId=fb9271cd5ddc46cba59fa6dbb4785c78
JavaScript @azure/arm-databoundaries https://apiview.dev/Assemblies/Review/f3358ffd08e0441faf640392a862557f?revisionId=fa092d8b64d341b887f23cc770313bf8
JavaScript @azure/arm-features https://apiview.dev/Assemblies/Review/cdac4d1c1fa1462bb53e5df0b43b1fd8?revisionId=a757f8991682425da56c79ce66d6b1fd
JavaScript @azure/arm-links https://apiview.dev/Assemblies/Review/fab6f39d3aa4438bbcf44202497c232d?revisionId=f6cb54fcafa547d5a64ccf92f23cb9c1
JavaScript @azure/arm-locks https://apiview.dev/Assemblies/Review/5032ea8e14d64cd0adc264676495aba7?revisionId=208f839fb409410c8910d434a15d2ee1
JavaScript @azure/arm-managedapplications https://apiview.dev/Assemblies/Review/13cbf64f04e64947ba72af718bdd91bf?revisionId=6b866f079f0c4c86beae30761a2e9579
JavaScript @azure/arm-policy https://apiview.dev/Assemblies/Review/cda5950570364aba98f6c682240aed30?revisionId=2eb8884f5c58460784bd1df1b2955241
JavaScript @azure/arm-resources-subscriptions There is no API change compared with the previous version
JavaScript @azure/arm-resources https://apiview.dev/Assemblies/Review/2afa29187fb74b96ba17874edd55e007?revisionId=899c6a7c6278448e82332934d04d2ba2
JavaScript @azure/arm-resourcesdeploymentstacks There is no API change compared with the previous version
JavaScript @azure/arm-templatespecs https://apiview.dev/Assemblies/Review/fc04625bf7df4e6e97f03f7aae3c05b7?revisionId=22d78042a897498f92198a5e4672cace

@microsoft-github-policy-service agree company="Microsoft"


From: microsoft-github-policy-service[bot] @.> Sent: Wednesday, October 30, 2024 4:58 PM To: Azure/azure-rest-api-specs @.> Cc: Vivek Therala @.>; Mention @.> Subject: Re: [Azure/azure-rest-api-specs] add 2024-10-01-preview version for soft delete types on ms resources (PR #31338)

@vivektheralahttps://github.com/vivektherala please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.

@microsoft-github-policy-service agree

  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.

@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement Contribution License Agreement

This Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”), and conveys certain license rights to Microsoft Corporation and its affiliates (“Microsoft”) for Your contributions to Microsoft open source projects. This Agreement is effective as of the latest signature date below.

  1. Definitions. “Code” means the computer software code, whether in human-readable or machine-executable form, that is delivered by You to Microsoft under this Agreement. “Project” means any of the projects owned or managed by Microsoft and offered under a license approved by the Open Source Initiative (www.opensource.orghttp://www.opensource.org/). “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any Project, including but not limited to communication on electronic mailing lists, source code control systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of discussing and improving that Project, but excluding communication that is conspicuously marked or otherwise designated in writing by You as “Not a Submission.” “Submission” means the Code and any other copyrightable material Submitted by You, including any associated comments and documentation.
  2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any Project. This Agreement covers any and all Submissions that You, now or in the future (except as described in Section 4 below), Submit to any Project.
  3. Originality of Work. You represent that each of Your Submissions is entirely Your original work. Should You wish to Submit materials that are not Your original work, You may Submit them separately to the Project if You (a) retain all copyright and license information that was in the materials as You received them, (b) in the description accompanying Your Submission, include the phrase “Submission containing materials of a third party:” followed by the names of the third party and any licenses or other restrictions of which You are aware, and (c) follow any other instructions in the Project’s written guidelines concerning Submissions.
  4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your Submission is made in the course of Your work for an employer or Your employer has intellectual property rights in Your Submission by contract or applicable law, You must secure permission from Your employer to make the Submission before signing this Agreement. In that case, the term “You” in this Agreement will refer to You and the employer collectively. If You change employers in the future and desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement and secure permission from the new employer before Submitting those Submissions.
  5. Licenses.
  • Copyright License. You grant Microsoft, and those who receive the Submission directly or indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third parties.
  • Patent License. You grant Microsoft, and those who receive the Submission directly or indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under Your patent claims that are necessarily infringed by the Submission or the combination of the Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and import or otherwise dispose of the Submission alone or with the Project.
  • Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement. No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are granted by implication, exhaustion, estoppel or otherwise.
  1. Representations and Warranties. You represent that You are legally entitled to grant the above licenses. You represent that each of Your Submissions is entirely Your original work (except as You may have disclosed under Section 3). You represent that You have secured permission from Your employer to make the Submission in cases where Your Submission is made in the course of Your work for Your employer or Your employer has intellectual property rights in Your Submission by contract or applicable law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You have the necessary authority to bind the listed employer to the obligations contained in this Agreement. You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.
  2. Notice to Microsoft. You agree to notify Microsoft in writing of any facts or circumstances of which You later become aware that would make Your representations in this Agreement inaccurate in any respect.
  3. Information about Submissions. You agree that contributions to Projects and information about contributions may be maintained indefinitely and disclosed publicly, including Your name and other information that You submit with Your Submission.
  4. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County, Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all defenses of lack of personal jurisdiction and forum non-conveniens.
  5. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and supersedes any and all prior agreements, understandings or communications, written or oral, between the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft.

— Reply to this email directly, view it on GitHubhttps://github.com/Azure/azure-rest-api-specs/pull/31338#issuecomment-2448367141, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BMRRZMSCXPH3H7NXJEJAFX3Z6FB7JAVCNFSM6AAAAABQ4WQFU2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBYGM3DOMJUGE. You are receiving this because you were mentioned.Message ID: @.***>

vivektherala avatar Oct 31 '24 18:10 vivektherala

can you please fix the swagger lint errors : https://github.com/Azure/azure-rest-api-specs/pull/31338/checks?check_run_id=32683026548

raosuhas avatar Nov 08 '24 00:11 raosuhas

can you please fix the swagger lint errors : https://github.com/Azure/azure-rest-api-specs/pull/31338/checks?check_run_id=32683026548

fixed lint errors

vivektherala avatar Nov 14 '24 03:11 vivektherala

can you please fix the swagger lint errors : https://github.com/Azure/azure-rest-api-specs/pull/31338/checks?check_run_id=32683026548

fixed lint errors

vivektherala avatar Nov 14 '24 03:11 vivektherala

/azp run

razvanbadea-msft avatar Nov 14 '24 07:11 razvanbadea-msft

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Nov 14 '24 07:11 azure-pipelines[bot]

API change check

APIView has identified API level changes in this PR and created following API reviews.

Microsoft.Authorization

azure-sdk avatar Nov 14 '24 07:11 azure-sdk

PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts.

Hi, @vivektherala. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

Hi, @vivektherala. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.