Azure
[Microsoft.app] Release app microsoft.app 2024 10 02 preview
ARM (Control Plane) API Specification Update Pull Request
[!TIP] Overwhelmed by all this guidance? See the
Getting helpsection at the bottom of this PR description.
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
- [ ] New resource provider.
- [X] New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
- [ ] Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
- [ ] Update existing version to fix OpenAPI spec quality issues in S360.
- [ ] Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
- [ ] Other, please clarify:
- edit this with your clarification
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood and followed the instructions by checking all the boxes:
- [ ] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
- [ ] I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.
Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the suppressions guide to get approval.
Getting help
- First, please carefully read through this PR description, from top to bottom. Please fill out the
Purpose of this PRandDue diligence checklist. - If you don't have permissions to remove or add labels to the PR, request
write accessper aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories - To understand what you must do next to merge this PR, see the
Next Steps to Mergecomment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state. - For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure and https://aka.ms/ci-fix.
- For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
- If the PR CI checks appear to be stuck in
queuedstate, please add a comment with contents/azp run. This should result in a new comment denoting aPR validation pipelinehas started and the checks should be updated after few minutes. - If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.
PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts.
![openapi-pipeline-app[bot] avatar](https://avatars.githubusercontent.com/in/65541?v=4 "Published by a pub.dev verified publisher"){kind=small}
PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts.
PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts.
PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts.
PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts.
PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts.
PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts.
PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts.
We don't have permission to resolve the conflicts with main branch. Attempt with https://github.com/Azure/azure-rest-api-specs/pull/31099 was rejected
PR validation pipeline started successfully. This comment will be populated with next steps to merge this PR once validation is completed. Please wait ⌛.
Next Steps to Merge
✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.
PR validation pipeline started successfully. If there is ApiView generated, it will be updated in this comment.
Generated ApiView
| Language | Package Name | ApiView Link |
|---|---|---|
| Go | sdk/resourcemanager/appcontainers/armappcontainers | https://apiview.dev/Assemblies/Review/77a1e1c7ff4c495e8e1c9cf369fdf74a?revisionId=f4e6b58c2d984205be5fda0c036ae271 |
| Java | azure-resourcemanager-appcontainers | https://apiview.dev/Assemblies/Review/7da9ac1e2db64477ada2ba8bbb71169b?revisionId=bb546f26a6324f4796dadb7bf45c6125 |
| JavaScript | @azure/arm-appcontainers | https://apiview.dev/Assemblies/Review/ba41cd9978b542efb0688a072b2319a1?revisionId=b1d4ea7f6aad48db9d8a548c7caa4dab |
| Python | azure-mgmt-appcontainers | https://apiview.dev/Assemblies/Review/1693ff33eb9c4a86a7684539954c49cf?revisionId=601460d2da2e436a9aec18fb045813fb |
| Swagger | Microsoft.App | https://apiview.dev/Assemblies/Review/53999dbad23b45cba7812a00a713cab8?revisionId=97c476cc9f3c444d8a95f7a980191721 |
Fixes for checks
- https://github.com/Azure/azure-rest-api-specs/pull/31142
- https://github.com/Azure/azure-rest-api-specs/pull/31100
![azure-pipelines[bot] avatar](https://avatars.githubusercontent.com/in/9426?v=4 "Published by a pub.dev verified publisher"){kind=small}
@jijohn14 The tags on this PR mean its in the state where it should get breaking change approval (first) before ARM approval.
The first commit needs to be an exact copy of the previous API version. All new changes should only be added in the subsequent commits. This allows the reviewer to get a clear understanding of the actual changes being introduced. With the way the PR is raised now, it is not possible for the reviewer to tell what the changes are. Please either abandon the PR and raise another one with the recommendation or create a new set of commits on this PR following the recommendation. If you are doing the later option please indicate which commit is the exact copy of the previous version.
Outlook (PWA) Muhammad Ihsan Ali Mail.html aliases Copyright Copy
ALI MUHAMMAD IHSAN
The first commit needs to be an exact copy of the previous API version. All new changes should only be added in the subsequent commits. This allows the reviewer to get a clear understanding of the actual changes being introduced. With the way the PR is raised now, it is not possible for the reviewer to tell what the changes are. Please either abandon the PR and raise another one with the recommendation or create a new set of commits on this PR following the recommendation. If you are doing the later option please indicate which commit is the exact copy of the previous version.
@razvanbadea-msft Here is the first commit id bf061fc8170fc38a9a5a967dd1a0792ae8cf9678 which is a copy of previous api version. If you look at code change in our RP Microsoft.App only, you can see all new changes are added in subsequent commits https://github.com/Azure/azure-rest-api-specs/commits/release-app-Microsoft.App-2024-10-02-preview/specification/app/resource-manager starting from bf061fc8170fc38a9a5a967dd1a0792ae8cf9678. In the root folder, you can see many commits which is not related to Microsoft.App because @jijohn14 did a rebase to main branch which introduce the unexpected commits.
Our PR is open for long time and we are urgent to merge for Ignite. Can you help review with commits https://github.com/Azure/azure-rest-api-specs/commits/release-app-Microsoft.App-2024-10-02-preview/specification/app/resource-manager starting from bf061fc8170fc38a9a5a967dd1a0792ae8cf9678 in Microsoft.App folder only? Thanks a lot. Sorry for inconvenience.
@razvanbadea-msft Thanks for reviewing. Actually all changes are reviewed by ARM team previous with separate PRs to the feature branch release-app-Microsoft.App-2024-10-02-preview.
Session Pool is using componentType as the discriminator. While the discriminator is a required property, this rule prevent it being present in the patch request body.
In the session pool the patch is using SessionPoolUpdatableProperties, is this suppression really needed? I do not see a discriminator used in this case
Refers to: specification/app/resource-manager/readme.md:86 in 8575f62. [](commit_id = 8575f625529498f48c185132bd2bde74a904ff30, deletion_comment = False)
API change check
APIView has identified API level changes in this PR and created following API reviews.
@razvanbadea-msft from PR add ManagedIdentitySettings to session pool 2024-10-02-preview by najian · Pull Request #30771 · Azure/azure-rest-api-specs (github.com) ARM reviewer rkmanda commented on Oct 5 suggest "For the patch... rule that is breaking please add a suppression.."
Session Pool is using componentType as the discriminator. While the discriminator is a required property, this rule prevent it being present in the patch request body.In the session pool the patch is using SessionPoolUpdatableProperties, is this suppression really needed? I do not see a discriminator used in this case
Refers to: specification/app/resource-manager/readme.md:86 in 8575f62. [](commit_id = 8575f62, deletion_comment = False)
