azure-rest-api-specs icon indicating copy to clipboard operation
azure-rest-api-specs copied to clipboard

Changes for new API Version 2024-11-01-preview

Open viveksheelsingh opened this issue 1 year ago • 3 comments

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

viveksheelsingh avatar Oct 15 '24 07:10 viveksheelsingh

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This PR targets either the main branch of the public specs repo or the RPSaaSMaster branch of the private specs repo. These branches are not intended for iterative development. Therefore, you must acknowledge you understand that after this PR is merged, the APIs are considered shipped to Azure customers. Any further attempts at in-place modifications to the APIs will be subject to Azure's versioning and breaking change policies. Additionally, for control plane APIs, you must acknowledge that you are following all the best practices documented by ARM at aka.ms/armapibestpractices. If you do intend to release the APIs to your customers by merging this PR, add the PublishToCustomers label to your PR in acknowledgement of the above. Otherwise, retarget this PR onto a feature branch, i.e. with prefix release- (see aka.ms/azsdk/api-versions#release--branches).
  • ❌ This PR is in purview of the ARM review (label: ARMReview). This PR must get ARMSignedOff label from an ARM reviewer.
    This PR is not ready for ARM review (label: NotReadyForARMReview). This PR will not be reviewed by ARM until relevant problems are fixed. Consult the rest of this Next Steps to Merge comment for details.
    Once the blocking problems are addressed, add to the PR a comment with contents /azp run. Automation will re-evaluate this PR and if everything looks good, it will add WaitForARMFeedback label which will put this PR on the ARM review queue.
    For details of the ARM review, see aka.ms/azsdk/pr-arm-review
  • ❌ This PR is NotReadyForARMReview because it has the BreakingChangeReviewRequired label.
  • ❌ This PR has at least one breaking change (label: BreakingChangeReviewRequired).
    To unblock this PR, follow the process at aka.ms/brch.
  • ❌ The required check named Swagger Avocado has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/recoveryservices/armrecoveryservicesbackup Create ApiView timeout. Package is too large and we cannot create ApiView for it.
Java azure-resourcemanager-recoveryservicesbackup https://apiview.dev/Assemblies/Review/a4a183e5963645238761f94a38ed47e9?revisionId=779a6a1d6eb944eb8b1ea75df1a5c09d
JavaScript @azure/arm-recoveryservicesbackup https://apiview.dev/Assemblies/Review/859c2af295154fe6816f57a966fd8dee?revisionId=fd404a09a7aa4480b89a599a155dcddb
Python azure-mgmt-recoveryservicesbackup https://apiview.dev/Assemblies/Review/0a14b8362f694541b56cb19ab03710bd?revisionId=06bb7ab322cf4aadb96b951e31280bb7

Azure Pipelines successfully started running 2 pipeline(s).

azure-pipelines[bot] avatar Oct 28 '24 15:10 azure-pipelines[bot]

      "$ref": "#/definitions/AzureWorkloadPointInTimeRecoveryPoint"

nit: I observed that all non point in time structure also inherit properties from AzureWorkloadPointInTimeRecoveryPoint which has additional timerange property. Wanted to confirm that you want to bring this structure instead of AzureWorkloadRecoveryPoint


Refers to: specification/recoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/preview/2024-11-01-preview/bms.json:6677 in 2fa8bdf. [](commit_id = 2fa8bdf78e32a9b69ff9700f9ca0c03a558bc34c, deletion_comment = False)

krdhruva avatar Nov 08 '24 12:11 krdhruva

PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts.

Added ARMSignedOff on behalf of Krupesh (who reviewed the PR, but somehow isnt able to add the label.

viveksheelsingh avatar Nov 12 '24 03:11 viveksheelsingh

PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts.

/azp run

viveksheelsingh avatar Mar 20 '25 06:03 viveksheelsingh

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

azure-pipelines[bot] avatar Mar 20 '25 06:03 azure-pipelines[bot]

API change check

APIView has identified API level changes in this PR and created following API reviews.

Microsoft.RecoveryServices

azure-sdk avatar Mar 20 '25 06:03 azure-sdk

Hi, @@viveksheelsingh. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

Hi, @@viveksheelsingh. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.