azure-rest-api-specs icon indicating copy to clipboard operation
azure-rest-api-specs copied to clipboard

Migration of transfer APIs to Public

Open abdulgagit opened this issue 1 year ago • 10 comments

Migration of transfer APIs to Public

[!TIP] Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

This PR includes APIs related to create subscription transfers to given destination email id and get details of already created transfer.

  • [ ] New resource provider.
  • [X] New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • [ ] Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • [ ] Update existing version to fix OpenAPI spec quality issues in S360.
  • [ ] Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
  • [X] Other, please clarify:
    • Additional of new API spec for new feature DNS Security Policy that will reside alongside our existing API DNS resolver

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood and followed the instructions by checking all the boxes:

  • [X] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • [X] I have reviewed following Resource Provider guidelines, including ARM resource provider contract and REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run. This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

abdulgagit avatar Oct 14 '24 21:10 abdulgagit

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This PR targets either the main branch of the public specs repo or the RPSaaSMaster branch of the private specs repo. These branches are not intended for iterative development. Therefore, you must acknowledge you understand that after this PR is merged, the APIs are considered shipped to Azure customers. Any further attempts at in-place modifications to the APIs will be subject to Azure's versioning and breaking change policies. Additionally, for control plane APIs, you must acknowledge that you are following all the best practices documented by ARM at aka.ms/armapibestpractices. If you do intend to release the APIs to your customers by merging this PR, add the PublishToCustomers label to your PR in acknowledgement of the above. Otherwise, retarget this PR onto a feature branch, i.e. with prefix release- (see aka.ms/azsdk/api-versions#release--branches).
  • ❌ This PR is in purview of the ARM review (label: ARMReview). This PR must get ARMSignedOff label from an ARM reviewer.
    This PR has ARMChangesRequested label. Please address or respond to feedback from the ARM API reviewer.
    When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
    Automation should then add WaitForARMFeedback label.
    ❗If you don't have permissions to remove the label, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories.
    For details of the ARM review, see aka.ms/azsdk/pr-arm-review
  • ❌ The required check named Swagger PrettierCheck has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide

/azp run

abdulgagit avatar Oct 14 '24 23:10 abdulgagit

Commenter does not have sufficient privileges for PR 31015 in repo Azure/azure-rest-api-specs

azure-pipelines[bot] avatar Oct 14 '24 23:10 azure-pipelines[bot]

@abdulgagit Could you please tell what is this PR trying to achieve.

Comparing this 2024-10-01-preview to 2024-08-01-preview, I see some APIs removed like '/subscriptions/{subscriptionId}/providers/Microsoft.Subscription/changeTenantRequest/default' .

The first commit should be an exact copy of existing API version in new folder ( that is meant for new API version ). And then the following commits can have your changes. This will help the reviewer to check what exactly changed. Currently this is hard to review this code. Can you also update the initial commit if possible ? You can choose to abondon this PR and create a new one following the guidelines.

ramoka178 avatar Oct 22 '24 20:10 ramoka178

/azp run

abdulgagit avatar Oct 31 '24 10:10 abdulgagit

Commenter does not have sufficient privileges for PR 31015 in repo Azure/azure-rest-api-specs

azure-pipelines[bot] avatar Oct 31 '24 10:10 azure-pipelines[bot]

/azp run

abdulgagit avatar Oct 31 '24 10:10 abdulgagit

Commenter does not have sufficient privileges for PR 31015 in repo Azure/azure-rest-api-specs

azure-pipelines[bot] avatar Oct 31 '24 10:10 azure-pipelines[bot]

API change check

APIView has identified API level changes in this PR and created following API reviews.

Microsoft.Subscription

azure-sdk avatar Feb 07 '25 08:02 azure-sdk

There is a comment from the previous reviewer that

@abdulgagit Could you please tell what is this PR trying to achieve.

Comparing this 2024-10-01-preview to 2024-08-01-preview, I see some APIs removed like '/subscriptions/{subscriptionId}/providers/Microsoft.Subscription/changeTenantRequest/default' .

The first commit should be an exact copy of existing API version in new folder ( that is meant for new API version ). And then the following commits can have your changes. This will help the reviewer to check what exactly changed. Currently this is hard to review this code. Can you also update the initial commit if possible ? You can choose to abondon this PR and create a new one following the guidelines.

Please respond to this.. I am also facing difficulty understanding what the real changes are

image

rkmanda avatar Mar 21 '25 04:03 rkmanda

There is a comment from the previous reviewer that

@abdulgagit Could you please tell what is this PR trying to achieve. Comparing this 2024-10-01-preview to 2024-08-01-preview, I see some APIs removed like '/subscriptions/{subscriptionId}/providers/Microsoft.Subscription/changeTenantRequest/default' . The first commit should be an exact copy of existing API version in new folder ( that is meant for new API version ). And then the following commits can have your changes. This will help the reviewer to check what exactly changed. Currently this is hard to review this code. Can you also update the initial commit if possible ? You can choose to abondon this PR and create a new one following the guidelines.

Please respond to this.. I am also facing difficulty understanding what the real changes are

image

Let me keep top two commits -> One as initial commit and another one as with changes. There are comments given by our internal team member, would like to keep them intact.

I will push one commit as "Initial Commit -> without new changes" and "next commit with changes". I will take care of this from next PR to ensure this rule is followed.

abdulgagit avatar Mar 21 '25 05:03 abdulgagit

Hi, @@abdulgagit. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

Hi, @@abdulgagit. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.