azure-rest-api-specs icon indicating copy to clipboard operation
azure-rest-api-specs copied to clipboard

NFS Share Snapshot

Open seanmcc-msft opened this issue 11 months ago • 5 comments

seanmcc-msft avatar Mar 21 '24 01:03 seanmcc-msft

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️❌Breaking Change(Cross-Version): 51 Errors, 51 Warnings failed [Detail]
Compared specs (v0.10.5) new version base version
file.json 2024-08-04(bbb7986) 2024-05-04(main)
file.json 2024-08-04(bbb7986) 2024-05-04(main)

The following breaking changes are detected by comparison with the latest stable version:

Only 30 items are listed, please refer to log for more details.

Rule Message
1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/stable/2024-05-04/file.json#L46:9
1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/stable/2024-05-04/file.json#L93:9
1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/stable/2024-05-04/file.json#L164:9
1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/stable/2024-05-04/file.json#L240:9
1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/stable/2024-05-04/file.json#L313:9
1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/stable/2024-05-04/file.json#L491:9
1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/stable/2024-05-04/file.json#L566:9
1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/stable/2024-05-04/file.json#L689:9
1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/stable/2024-05-04/file.json#L804:9
1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/stable/2024-05-04/file.json#L927:9
1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/stable/2024-05-04/file.json#L1047:9
1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/stable/2024-05-04/file.json#L1175:9
1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/stable/2024-05-04/file.json#L1271:9
1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/stable/2024-05-04/file.json#L1334:9
1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/stable/2024-05-04/file.json#L1419:9
1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/stable/2024-05-04/file.json#L1516:9
1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/stable/2024-05-04/file.json#L1607:9
1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/stable/2024-05-04/file.json#L1671:9
1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/stable/2024-05-04/file.json#L1762:9
1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/stable/2024-05-04/file.json#L1853:9
1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/stable/2024-05-04/file.json#L1952:9
1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/stable/2024-05-04/file.json#L2077:9
1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/stable/2024-05-04/file.json#L2190:9
1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/stable/2024-05-04/file.json#L2265:9
1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/stable/2024-05-04/file.json#L2420:9
1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/stable/2024-05-04/file.json#L2517:9
1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/stable/2024-05-04/file.json#L2630:9
1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/stable/2024-05-04/file.json#L2724:9
1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/stable/2024-05-04/file.json#L2826:9
1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/stable/2024-05-04/file.json#L3002:9


The following breaking changes are detected by comparison with the latest preview version:

Only 30 items are listed, please refer to log for more details.

Rule Message
:warning: 1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/preview/2024-05-04/file.json#L46:9
:warning: 1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/preview/2024-05-04/file.json#L93:9
:warning: 1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/preview/2024-05-04/file.json#L164:9
:warning: 1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/preview/2024-05-04/file.json#L240:9
:warning: 1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/preview/2024-05-04/file.json#L313:9
:warning: 1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/preview/2024-05-04/file.json#L491:9
:warning: 1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/preview/2024-05-04/file.json#L566:9
:warning: 1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/preview/2024-05-04/file.json#L689:9
:warning: 1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/preview/2024-05-04/file.json#L804:9
:warning: 1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/preview/2024-05-04/file.json#L927:9
:warning: 1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/preview/2024-05-04/file.json#L1047:9
:warning: 1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/preview/2024-05-04/file.json#L1175:9
:warning: 1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/preview/2024-05-04/file.json#L1271:9
:warning: 1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/preview/2024-05-04/file.json#L1334:9
:warning: 1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/preview/2024-05-04/file.json#L1419:9
:warning: 1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/preview/2024-05-04/file.json#L1516:9
:warning: 1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/preview/2024-05-04/file.json#L1607:9
:warning: 1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/preview/2024-05-04/file.json#L1671:9
:warning: 1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/preview/2024-05-04/file.json#L1762:9
:warning: 1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/preview/2024-05-04/file.json#L1853:9
:warning: 1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/preview/2024-05-04/file.json#L1952:9
:warning: 1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/preview/2024-05-04/file.json#L2077:9
:warning: 1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/preview/2024-05-04/file.json#L2190:9
:warning: 1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/preview/2024-05-04/file.json#L2265:9
:warning: 1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/preview/2024-05-04/file.json#L2420:9
:warning: 1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/preview/2024-05-04/file.json#L2517:9
:warning: 1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/preview/2024-05-04/file.json#L2630:9
:warning: 1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/preview/2024-05-04/file.json#L2724:9
:warning: 1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/preview/2024-05-04/file.json#L2826:9
:warning: 1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/preview/2024-05-04/file.json#L3002:9
️⚠️LintDiff: 4 Warnings warning [Detail]
Compared specs (v2.2.0) new version base version
package-2024-08 package-2024-08(bbb7986) package-2024-08(feature/storage/stg94base)

[must fix]The following errors/warnings are introduced by current PR:

Rule Message Related RPC [For API reviewers]
:warning: EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: Microsoft.FileStorage/stable/2024-08-04/file.json#L472
:warning: EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: Microsoft.FileStorage/stable/2024-08-04/file.json#L6443
:warning: PropertyDescription Property should have a description.
Location: Microsoft.FileStorage/stable/2024-08-04/file.json#L6443
:warning: EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: Microsoft.FileStorage/stable/2024-08-04/file.json#L6826


The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule Message
HostParametersValidation The host parameter must be called 'endpoint'.
Location: Microsoft.FileStorage/stable/2024-08-04/file.json#L16
HostParametersValidation The host parameter must be typed 'type 'string', format 'url''.
Location: Microsoft.FileStorage/stable/2024-08-04/file.json#L16
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/stable/2024-08-04/file.json#L135
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/stable/2024-08-04/file.json#L145
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/stable/2024-08-04/file.json#L221
IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
Location: Microsoft.FileStorage/stable/2024-08-04/file.json#L364
IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
Location: Microsoft.FileStorage/stable/2024-08-04/file.json#L369
IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
Location: Microsoft.FileStorage/stable/2024-08-04/file.json#L374
IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
Location: Microsoft.FileStorage/stable/2024-08-04/file.json#L379
IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
Location: Microsoft.FileStorage/stable/2024-08-04/file.json#L390
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/stable/2024-08-04/file.json#L555
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/stable/2024-08-04/file.json#L652
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/stable/2024-08-04/file.json#L678
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/stable/2024-08-04/file.json#L767
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/stable/2024-08-04/file.json#L793
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/stable/2024-08-04/file.json#L890
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/stable/2024-08-04/file.json#L916
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/stable/2024-08-04/file.json#L1010
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/stable/2024-08-04/file.json#L1036
IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
Location: Microsoft.FileStorage/stable/2024-08-04/file.json#L1088
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/stable/2024-08-04/file.json#L1138
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/stable/2024-08-04/file.json#L1164
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/stable/2024-08-04/file.json#L1247
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/stable/2024-08-04/file.json#L1257
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/stable/2024-08-04/file.json#L1398
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/stable/2024-08-04/file.json#L1408
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/stable/2024-08-04/file.json#L1498
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/stable/2024-08-04/file.json#L1508
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/stable/2024-08-04/file.json#L1589
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/stable/2024-08-04/file.json#L1599
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
 Please click here to preview with your @microsoft account. 
Posted by Swagger Pipeline | How to fix these errors?

Generated ApiView

Language Package Name ApiView Link
Swagger Microsoft.FileStorage https://apiview.dev/Assemblies/Review/a4e81fa81cae4aee9435e6d8b39e6a9f?revisionId=462f2e84ee644aa794613bced8108ab7

Hi, @seanmcc-msft. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.