azure-rest-api-specs icon indicating copy to clipboard operation
azure-rest-api-specs copied to clipboard

Added AuthenticationErrorDetail to StorageError

Open seanmcc-msft opened this issue 11 months ago • 5 comments

seanmcc-msft avatar Mar 21 '24 01:03 seanmcc-msft

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️❌Breaking Change(Cross-Version): 48 Errors, 48 Warnings failed [Detail]
Compared specs (v0.10.5) new version base version
file.json 2024-08-04(12e0cee) 2024-05-04(main)
file.json 2024-08-04(12e0cee) 2024-05-04(main)

The following breaking changes are detected by comparison with the latest stable version:

Only 30 items are listed, please refer to log for more details.

Rule Message
1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/stable/2024-05-04/file.json#L46:9
1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/stable/2024-05-04/file.json#L93:9
1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/stable/2024-05-04/file.json#L164:9
1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/stable/2024-05-04/file.json#L240:9
1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/stable/2024-05-04/file.json#L313:9
1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/stable/2024-05-04/file.json#L491:9
1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/stable/2024-05-04/file.json#L566:9
1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/stable/2024-05-04/file.json#L689:9
1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/stable/2024-05-04/file.json#L804:9
1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/stable/2024-05-04/file.json#L927:9
1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/stable/2024-05-04/file.json#L1047:9
1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/stable/2024-05-04/file.json#L1175:9
1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/stable/2024-05-04/file.json#L1271:9
1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/stable/2024-05-04/file.json#L1334:9
1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/stable/2024-05-04/file.json#L1419:9
1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/stable/2024-05-04/file.json#L1516:9
1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/stable/2024-05-04/file.json#L1607:9
1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/stable/2024-05-04/file.json#L1671:9
1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/stable/2024-05-04/file.json#L1762:9
1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/stable/2024-05-04/file.json#L1853:9
1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/stable/2024-05-04/file.json#L1952:9
1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/stable/2024-05-04/file.json#L2077:9
1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/stable/2024-05-04/file.json#L2190:9
1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/stable/2024-05-04/file.json#L2265:9
1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/stable/2024-05-04/file.json#L2420:9
1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/stable/2024-05-04/file.json#L2517:9
1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/stable/2024-05-04/file.json#L2630:9
1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/stable/2024-05-04/file.json#L2724:9
1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/stable/2024-05-04/file.json#L2826:9
1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/stable/2024-05-04/file.json#L3002:9


The following breaking changes are detected by comparison with the latest preview version:

Only 30 items are listed, please refer to log for more details.

Rule Message
:warning: 1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/preview/2024-05-04/file.json#L46:9
:warning: 1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/preview/2024-05-04/file.json#L93:9
:warning: 1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/preview/2024-05-04/file.json#L164:9
:warning: 1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/preview/2024-05-04/file.json#L240:9
:warning: 1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/preview/2024-05-04/file.json#L313:9
:warning: 1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/preview/2024-05-04/file.json#L491:9
:warning: 1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/preview/2024-05-04/file.json#L566:9
:warning: 1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/preview/2024-05-04/file.json#L689:9
:warning: 1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/preview/2024-05-04/file.json#L804:9
:warning: 1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/preview/2024-05-04/file.json#L927:9
:warning: 1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/preview/2024-05-04/file.json#L1047:9
:warning: 1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/preview/2024-05-04/file.json#L1175:9
:warning: 1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/preview/2024-05-04/file.json#L1271:9
:warning: 1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/preview/2024-05-04/file.json#L1334:9
:warning: 1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/preview/2024-05-04/file.json#L1419:9
:warning: 1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/preview/2024-05-04/file.json#L1516:9
:warning: 1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/preview/2024-05-04/file.json#L1607:9
:warning: 1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/preview/2024-05-04/file.json#L1671:9
:warning: 1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/preview/2024-05-04/file.json#L1762:9
:warning: 1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/preview/2024-05-04/file.json#L1853:9
:warning: 1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/preview/2024-05-04/file.json#L1952:9
:warning: 1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/preview/2024-05-04/file.json#L2077:9
:warning: 1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/preview/2024-05-04/file.json#L2190:9
:warning: 1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/preview/2024-05-04/file.json#L2265:9
:warning: 1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/preview/2024-05-04/file.json#L2420:9
:warning: 1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/preview/2024-05-04/file.json#L2517:9
:warning: 1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/preview/2024-05-04/file.json#L2630:9
:warning: 1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/preview/2024-05-04/file.json#L2724:9
:warning: 1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/preview/2024-05-04/file.json#L2826:9
:warning: 1019 - RemovedEnumValue The new version is removing enum value(s) '2024-05-04' from the old version.
Old: Microsoft.FileStorage/preview/2024-05-04/file.json#L3002:9
️⚠️LintDiff: 1 Warnings warning [Detail]
Compared specs (v2.2.0) new version base version
package-2024-08 package-2024-08(12e0cee) package-2024-08(feature/storage/stg94base)

[must fix]The following errors/warnings are introduced by current PR:

Rule Message Related RPC [For API reviewers]
:warning: PropertyDescription Property should have a description.
Location: Microsoft.FileStorage/stable/2024-08-04/file.json#L6313


The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule Message
HostParametersValidation The host parameter must be called 'endpoint'.
Location: Microsoft.FileStorage/stable/2024-08-04/file.json#L16
HostParametersValidation The host parameter must be typed 'type 'string', format 'url''.
Location: Microsoft.FileStorage/stable/2024-08-04/file.json#L16
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/stable/2024-08-04/file.json#L135
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/stable/2024-08-04/file.json#L145
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/stable/2024-08-04/file.json#L221
IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
Location: Microsoft.FileStorage/stable/2024-08-04/file.json#L361
IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
Location: Microsoft.FileStorage/stable/2024-08-04/file.json#L366
IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
Location: Microsoft.FileStorage/stable/2024-08-04/file.json#L371
IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
Location: Microsoft.FileStorage/stable/2024-08-04/file.json#L376
IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
Location: Microsoft.FileStorage/stable/2024-08-04/file.json#L387
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/stable/2024-08-04/file.json#L547
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/stable/2024-08-04/file.json#L644
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/stable/2024-08-04/file.json#L670
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/stable/2024-08-04/file.json#L759
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/stable/2024-08-04/file.json#L785
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/stable/2024-08-04/file.json#L882
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/stable/2024-08-04/file.json#L908
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/stable/2024-08-04/file.json#L1002
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/stable/2024-08-04/file.json#L1028
IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
Location: Microsoft.FileStorage/stable/2024-08-04/file.json#L1080
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/stable/2024-08-04/file.json#L1130
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/stable/2024-08-04/file.json#L1156
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/stable/2024-08-04/file.json#L1239
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/stable/2024-08-04/file.json#L1249
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/stable/2024-08-04/file.json#L1390
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/stable/2024-08-04/file.json#L1400
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/stable/2024-08-04/file.json#L1487
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/stable/2024-08-04/file.json#L1497
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/stable/2024-08-04/file.json#L1578
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/stable/2024-08-04/file.json#L1588
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
 Please click here to preview with your @microsoft account. 
Posted by Swagger Pipeline | How to fix these errors?

Generated ApiView

Language Package Name ApiView Link
Swagger Microsoft.FileStorage https://apiview.dev/Assemblies/Review/a4e81fa81cae4aee9435e6d8b39e6a9f?revisionId=73c0ce3d04d54430a91028b166a7bfdf

Hi, @seanmcc-msft. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.