…ent - 2023-11-02-preview

ARM (Control Plane) API Specification Update Pull Request

[!TIP] Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

[!NOTE] As of January 2024 there is no PR assignee. This is expected. See https://aka.ms/azsdk/pr-arm-review.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

diagram

Click here to see the details of Step 1

Breaking changes review (Diagram Step 1)

If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you, you must follow the breaking changes process.
IMPORTANT This applies even if:

The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
You believe there is no need for you to request breaking change approval, for any reason. Such claims must be reviewed, and the process is the same.

Click here to see the details of Step 2

ARM API changes review (Diagram Step 2)

For help with Step 2 / "ARM review", see https://aka.ms/azsdk/pr-arm-review.

Click here to see the diagram footnotes

Diagram footnotes

[1] See ARM review queue (for PR merge queues, see [2]).
[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
The ARM reviewer on-call engineer visits the merge queue twice a day, so the approximate ETA for merges is 12 - 24 hours.

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

[ ] New resource provider.
[ ] New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been generated using OpenAPI Hub).
[ ] Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
[ ] Update existing version to fix OpenAPI spec quality issues in S360.
[x] Other, please clarify:
- Update existing version for an existing feature to remove an enum type we don't need anymore and that was never used.

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood and followed the instructions by checking all the boxes:

[x] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
[x] I have reviewed following Resource Provider guidelines, including ARM resource provider contract and REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the suppressions guide to get approval.

Getting help

First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure and https://aka.ms/ci-fix.
For help with PR workflow diagram Step 2 (ARM review), see https://aka.ms/azsdk/pr-arm-review.
If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run. This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

Mar 06 '24 01:03 daniv-msft

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Mar 06 '24 01:03 openapi-pipeline-app[bot]

Swagger Validation Report

️❌BreakingChange: 1 Errors, 0 Warnings failed [Detail]

Compared specs (v0.10.5)	new version	base version
DotNetComponents.json	2023-11-02-preview(e1e02d6)	2023-11-02-preview(main)

Rule	Message
`❌` 1019 - RemovedEnumValue	The new version is removing enum value(s) 'AspireResourceServerApi' from the old version. New: Microsoft.App/preview/2023-11-02-preview/DotNetComponents.json#L405:13 Old: Microsoft.App/preview/2023-11-02-preview/DotNetComponents.json#L405:13

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️LintDiff: 0 Warnings warning [Detail]

Compared specs (v2.2.0)	new version	base version
package-preview-2023-11	package-preview-2023-11(e1e02d6)	package-preview-2023-11(main)

The following errors/warnings exist before current PR submission:

Rule	Message
:warning: MissingSegmentsInNestedResourceListOperation	A nested resource type's List operation must include all the parent segments in its api path. Location: Microsoft.App/preview/2023-11-02-preview/DotNetComponents.json#L36
:warning: SummaryAndDescriptionMustNotBeSame	The summary and description values should not be same. Location: Microsoft.App/preview/2023-11-02-preview/DotNetComponents.json#L297
:warning: LatestVersionOfCommonTypesMustBeUsed	Use the latest version v5 of types.json. Location: Microsoft.App/preview/2023-11-02-preview/DotNetComponents.json#L397

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

️️✔️Automated merging requirements met succeeded [Detail] [Expand]

_{Posted by Swagger Pipeline | How to fix these errors?}

Mar 06 '24 01:03 openapi-pipeline-app[bot]

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️⚠️ azure-sdk-for-python warning [Detail]

⚠️Warning [Logs] Generate from 2dde1e9e0016ba32596945057784e6e67c1b4e38. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh]  New minor version of npm available! 10.2.4 -> 10.5.0
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.5.0>
cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-appcontainers [View full logs] [Preview SDK Changes]
- azure_mgmt_appcontainers-1.0.0b1-py3-none-any.whl
- azure-mgmt-appcontainers-1.0.0b1.zip

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs] Generate from 2dde1e9e0016ba32596945057784e6e67c1b4e38. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 24.0
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 24.0
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] ferd  Average Speed   Time    Time     Time  Current
cmderr	[init.sh]                                  Dload  Upload   Total   Spent    Left  Speed
cmderr	[init.sh] 
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0     0  99475      0 --:--:-- --:--:-- --:--:-- 99475
cmderr	[init.sh]  notice
cmderr	[init.sh] npm notice New minor version of npm available! 10.2.4 -> 10.5.0
cmderr	[init.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.5.0>
cmderr	[init.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[init.sh] npm notice
cmderr	[init.sh] Downloading https://nodejs.org/dist/v18.15.0/node-v18.15.0-linux-x64.tar.xz...
cmderr	[init.sh] ################################# 100.0%
cmderr	[init.sh] Computing checksum with sha256sum
cmderr	[init.sh] Checksums matched!
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-appcontainers [View full logs] [Preview SDK Changes]

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 2dde1e9e0016ba32596945057784e6e67c1b4e38. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/appcontainers/armappcontainers [View full logs] [Preview SDK Changes]

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 2dde1e9e0016ba32596945057784e6e67c1b4e38. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-appcontainers [View full logs] [Preview SDK Changes]
- azure-arm-appcontainers-2.1.0-beta.1.tgz

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs] Generate from 2dde1e9e0016ba32596945057784e6e67c1b4e38. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] npm notice
cmderr	[initScript.sh] npm notice New minor version of npm available! 10.2.4 -> 10.5.0
cmderr	[initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.5.0>
cmderr	[initScript.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[initScript.sh] npm notice
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

️✔️app [View full logs] [Preview Schema Changes]

️️✔️ azure-powershell succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 2dde1e9e0016ba32596945057784e6e67c1b4e38. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json

️✔️Az.app.DefaultTag [View full logs] [Preview SDK Changes]
- Az.ContainerAppsApi.0.1.0.nupkg

_{Posted by Swagger Pipeline | How to fix these errors?}

Mar 06 '24 01:03 openapi-pipeline-app[bot]

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/appcontainers/armappcontainers	https://apiview.dev/Assemblies/Review/c5375c6f5a4443168e64c981277b8377?revisionId=9b38ab94745d403c83b80bf26cd03722
Java	azure-resourcemanager-appcontainers	https://apiview.dev/Assemblies/Review/7da9ac1e2db64477ada2ba8bbb71169b?revisionId=da1f50bb5c314b19bd9805c5889f3b56
JavaScript	@azure/arm-appcontainers	https://apiview.dev/Assemblies/Review/ba41cd9978b542efb0688a072b2319a1?revisionId=2818f4f8de8946c0a6a9f5ad54a0eb31
Swagger	Microsoft.App	https://apiview.dev/Assemblies/Review/53999dbad23b45cba7812a00a713cab8?revisionId=d8a4167d7a734e7f9066cdd687088bbf

Mar 06 '24 01:03 openapi-pipeline-app[bot]

PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts.

Mar 06 '24 02:03 openapi-pipeline-app[bot]

Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
Please include [ARM Query] in the title of your question to indicate that it is ARM-related.

Mar 06 '24 02:03 openapi-workflow-bot[bot]

Created this breaking change review request item: https://msazure.visualstudio.com/One/_workitems/edit/27071821

Mar 06 '24 02:03 daniv-msft

@mushmal, @bexxx, Could you please remove the ARMChangesRequested label? For some reasons I cannot remove it myself from the PR.

Mar 08 '24 19:03 daniv-msft

@MushMal, @bexxx, Could you please remove the ARMChangesRequested label? For some reasons I cannot remove it myself from the PR.

@MushMal, @bexxx > Sorry for the early ping but I want to make sure I don't forget about this. Could you please remove the ARMChangesRequested label from this PR? I don't seem to have the permissions to do this myself.

Mar 11 '24 19:03 daniv-msft

@MushMal, @bexxx, Could you please remove the ARMChangesRequested label? For some reasons I cannot remove it myself from the PR.

@MushMal, @bexxx > Sorry for the early ping but I want to make sure I don't forget about this. Could you please remove the ARMChangesRequested label from this PR? I don't seem to have the permissions to do this myself.

@MushMal, @bexxx > Could you please try to remove the ARMChangesRequested label? I'm not able to do it myself and need it to be removed so that this PR can be merged.

Mar 15 '24 22:03 daniv-msft

@daniv-msft

Your PR should now be pending ARM review:

https://aka.ms/azsdk/pr-arm-review

Mar 21 '24 00:03 konrad-jamrozik

Hi, @daniv-msft. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

Apr 29 '24 00:04 microsoft-github-policy-service[bot]

Hi, @daniv-msft. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.

May 13 '24 13:05 microsoft-github-policy-service[bot]

azure-rest-api-specs
azure-rest-api-specs copied to clipboard

[Container Apps] Remove AspireResourceServerApi type for DotNetCompon…

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Breaking changes review (Diagram Step 1)

ARM API changes review (Diagram Step 2)

Diagram footnotes

Purpose of this PR

Due diligence checklist

Additional information

Getting help

Next Steps to Merge

Swagger Validation Report

Swagger Generation Artifacts

Generated ApiView

azure-rest-api-specs azure-rest-api-specs copied to clipboard

[Container Apps] Remove AspireResourceServerApi type for DotNetCompon…

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Breaking changes review (Diagram Step 1)

ARM API changes review (Diagram Step 2)

Diagram footnotes

Purpose of this PR

Due diligence checklist

Additional information

Getting help

Next Steps to Merge

Swagger Validation Report

Swagger Generation Artifacts

Generated ApiView

azure-rest-api-specs
azure-rest-api-specs copied to clipboard