Azure
Review request for Microsoft.RecoveryServices to add version stable/2024-02-01
ARM (Control Plane) API Specification Update Pull Request
[!TIP] Overwhelmed by all this guidance? See the
Getting helpsection at the bottom of this PR description.
[!NOTE] As of January 2024 there is no PR assignee. This is expected. See https://aka.ms/azsdk/pr-arm-review.
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Click here to see the details of Step 1
Breaking changes review (Diagram Step 1)
If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:
- The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
- You believe there is no need for you to request breaking change approval, for any reason. Such claims must be reviewed, and the process is the same.
Click here to see the details of Step 2
ARM API changes review (Diagram Step 2)
- For help with Step 2 / "ARM review", see https://aka.ms/azsdk/pr-arm-review.
Click here to see the diagram footnotes
Diagram footnotes
[1] See ARM review queue (for PR merge queues, see [2]).
[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
The ARM reviewer on-call engineer visits the merge queue twice a day, so the approximate ETA for merges is 12 - 24 hours.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
- [ ] New resource provider.
- [x] New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been generated using OpenAPI Hub).
- [ ] Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
- [ ] Update existing version to fix OpenAPI spec quality issues in S360.
- [ ] Other, please clarify:
- edit this with your clarification
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood and followed the instructions by checking all the boxes:
- [x] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
- [x] I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.
Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the suppressions guide to get approval.
Getting help
- First, please carefully read through this PR description, from top to bottom. Please fill out the
Purpose of this PRandDue diligence checklist. - To understand what you must do next to merge this PR, see the
Next Steps to Mergecomment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state. - For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure and https://aka.ms/ci-fix.
- For help with PR workflow diagram Step 2 (ARM review), see https://aka.ms/azsdk/pr-arm-review.
- If the PR CI checks appear to be stuck in
queuedstate, please add a comment with contents/azp run. This should result in a new comment denoting aPR validation pipelinehas started and the checks should be updated after few minutes. - If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.
Next Steps to Merge
Next steps that must be taken to merge this PR:- ❌ Your PR has at least one breaking change from a previous GA version (label:
BreakingChangeReviewRequired). See the PR description for help. - ❌ The required check named
Breaking Change(Cross-Version)has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it. In addition, refer to step 1 in the PR workflow diagram (even if your PR is for data plane, not ARM).
![openapi-pipeline-app[bot] avatar](https://avatars.githubusercontent.com/in/65541?v=4 "Published by a pub.dev verified publisher"){kind=small}
Swagger Validation Report
️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️❌Breaking Change(Cross-Version): 2 Errors, 0 Warnings failed [Detail]
| compared swaggers (via Oad v0.10.5)] | new version | base version |
|---|---|---|
| service.json | 2024-02-01(08922b0) | 2023-08-01(main) |
The following breaking changes are detected by comparison with the latest stable version:
| Rule | Message |
|---|---|
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{resourceName}/replicationFabrics/{fabricName}/removeInfra' removed or restructured? Old: Microsoft.RecoveryServices/stable/2023-08-01/service.json#L914:5 |
|
The new version is missing a property found in the old version. Was 'autoProtectionOfDataDisk' renamed or removed? New: Microsoft.RecoveryServices/stable/2024-02-01/service.json#L9729:7 Old: Microsoft.RecoveryServices/stable/2023-08-01/service.json#L8531:7 |
️❌CredScan: 0 Errors, 0 Warnings failed [Detail]
️🔄LintDiff inProgress [Detail]
️❌Avocado: 140 Errors, 0 Warnings failed [Detail]
Only 30 items are listed, please refer to log for more details.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
️️✔️ApiDocPreview succeeded [Detail] [Expand]
Please click here to preview with your @microsoft account.
️❌SDK Breaking Change Tracking failed [Detail]
Breaking Changes Tracking
❌azure-sdk-for-js - @azure/arm-recoveryservices-siterecovery - 6.0.0+ Class SiteRecoveryManagementClient has a new signature
❌azure-sdk-for-python-track2 - track2_azure-mgmt-recoveryservicessiterecovery - 1.2.0+ Model A2AEnableProtectionInput no longer has parameter auto_protection_of_data_disk + Removed operation ReplicationFabricsOperations.begin_remove_infra
️❌ azure-sdk-for-net-track2 failed [Detail]
❌Failed [Logs] Generate from 3b70b517ff02eb1a7f9095fef86821f42b9c738e. SDK Automation 14.0.0command pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json command pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json cmderr [Invoke-GenerateAndBuildV2.ps1] [31;1mGeneratePackage: [0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714[0m cmderr [Invoke-GenerateAndBuildV2.ps1] [31;1m[0m[36;1mLine |[0m cmderr [Invoke-GenerateAndBuildV2.ps1] [31;1m[0m[36;1m[36;1m 714 | [0m [36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s[0m …[0m cmderr [Invoke-GenerateAndBuildV2.ps1] [31;1m[0m[36;1m[36;1m[0m[36;1m[0m[36;1m | [31;1m ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~[0m cmderr [Invoke-GenerateAndBuildV2.ps1] [31;1m[0m[36;1m[36;1m[0m[36;1m[0m[36;1m[31;1m[31;1m[36;1m | [31;1mFailed to generate sdk. exit code: False[0m cmderr [Invoke-GenerateAndBuildV2.ps1] [31;1mGet-ChildItem: [0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:807[0m cmderr [Invoke-GenerateAndBuildV2.ps1] [31;1m[0m[36;1mLine |[0m cmderr [Invoke-GenerateAndBuildV2.ps1] [31;1m[0m[36;1m[36;1m 807 | [0m … rtifacts += [36;1mGet-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s[0m …[0m cmderr [Invoke-GenerateAndBuildV2.ps1] [31;1m[0m[36;1m[36;1m[0m[36;1m[0m[36;1m | [31;1m ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~[0m cmderr [Invoke-GenerateAndBuildV2.ps1] [31;1m[0m[36;1m[36;1m[0m[36;1m[0m[36;1m[31;1m[31;1m[36;1m | [31;1mCannot find path[0m cmderr [Invoke-GenerateAndBuildV2.ps1] [31;1m[0m[36;1m[36;1m[0m[36;1m[0m[36;1m[31;1m[31;1m[36;1m[31;1m[36;1m | [31;1m'/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because[0m cmderr [Invoke-GenerateAndBuildV2.ps1] [31;1m[0m[36;1m[36;1m[0m[36;1m[0m[36;1m[31;1m[31;1m[36;1m[31;1m[36;1m[31;1m[36;1m | [31;1mit does not exist.[0m cmderr [Invoke-GenerateAndBuildV2.ps1] [31;1mGeneratePackage: [0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714[0m cmderr [Invoke-GenerateAndBuildV2.ps1] [31;1m[0m[36;1mLine |[0m cmderr [Invoke-GenerateAndBuildV2.ps1] [31;1m[0m[36;1m[36;1m 714 | [0m [36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s[0m …[0m cmderr [Invoke-GenerateAndBuildV2.ps1] [31;1m[0m[36;1m[36;1m[0m[36;1m[0m[36;1m | [31;1m ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~[0m cmderr [Invoke-GenerateAndBuildV2.ps1] [31;1m[0m[36;1m[36;1m[0m[36;1m[0m[36;1m[31;1m[31;1m[36;1m | [31;1mFailed to generate sdk artifact[0m
❌Azure.ResourceManager.RecoveryServicesSiteRecovery [View full logs] [Preview SDK Changes]info [Changelog]
️⚠️ azure-sdk-for-python-track2 warning [Detail]
⚠️Warning [Logs] Generate from 3b70b517ff02eb1a7f9095fef86821f42b9c738e. SDK Automation 14.0.0command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools' cmderr [automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools' cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed. command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json cmderr [automation_generate.sh] cmderr [automation_generate.sh] npm notice New minor version of npm available! 10.2.4 -> 10.4.0 cmderr [automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.4.0> cmderr [automation_generate.sh] npm notice Run `npm install -g [email protected]` to update! cmderr [automation_generate.sh] npm notice
️✔️track2_azure-mgmt-recoveryservicessiterecovery [View full logs] [Preview SDK Changes] Breaking Change Detected- azure_mgmt_recoveryservicessiterecovery-1.0.0b1-py3-none-any.whl
- azure-mgmt-recoveryservicessiterecovery-1.0.0b1.zip
info [Changelog] ### Features Added info [Changelog] info [Changelog] - Added operation ReplicationProtectionContainersOperations.begin_switch_cluster_protection info [Changelog] - Added operation group ClusterRecoveryPointOperations info [Changelog] - Added operation group ClusterRecoveryPointsOperations info [Changelog] - Added operation group ReplicationProtectionClustersOperations info [Changelog] - Model A2AEnableProtectionInput has a new parameter protection_cluster_id info [Changelog] - Model A2AReplicationDetails has a new parameter is_cluster_infra_ready info [Changelog] - Model A2AReplicationDetails has a new parameter protection_cluster_id info [Changelog] info [Changelog] ### Breaking Changes info [Changelog] info [Changelog] - Model A2AEnableProtectionInput no longer has parameter auto_protection_of_data_disk info [Changelog] - Removed operation ReplicationFabricsOperations.begin_remove_infra
️⚠️ azure-sdk-for-java warning [Detail]
⚠️Warning [Logs] Generate from 3b70b517ff02eb1a7f9095fef86821f42b9c738e. SDK Automation 14.0.0command ./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json cmderr [init.sh] [notice] A new release of pip is available: 23.0.1 -> 24.0 cmderr [init.sh] [notice] To update, run: pip install --upgrade pip cmderr [init.sh] [notice] A new release of pip is available: 23.0.1 -> 24.0 cmderr [init.sh] [notice] To update, run: pip install --upgrade pip cmderr [init.sh] Time Current cmderr [init.sh] Dload Upload Total Spent Left Speed cmderr [init.sh] 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 00 0 597k 0 --:--:-- --:--:-- --:--:-- 597k cmderr [init.sh] Downloading https://nodejs.org/dist/v18.15.0/node-v18.15.0-linux-x64.tar.xz... cmderr [init.sh] ############## 100.0% cmderr [init.sh] Computing checksum with sha256sum cmderr [init.sh] Checksums matched! cmderr [init.sh] npm notice cmderr [init.sh] npm notice New major version of npm available! 9.5.0 -> 10.4.0 cmderr [init.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.4.0> cmderr [init.sh] npm notice Run `npm install -g [email protected]` to update! cmderr [init.sh] npm notice command ./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
️✔️azure-resourcemanager-recoveryservicessiterecovery [View full logs] [Preview SDK Changes]
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
️✔️Succeeded [Logs] Generate from 3b70b517ff02eb1a7f9095fef86821f42b9c738e. SDK Automation 14.0.0command sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json command generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
️✔️sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery [View full logs] [Preview SDK Changes]info [Changelog] ### Features Added info [Changelog] info [Changelog] - New enum type `ClusterRecoveryPointType` with values `ClusterRecoveryPointTypeApplicationConsistent`, `ClusterRecoveryPointTypeCrashConsistent`, `ClusterRecoveryPointTypeNotSpecified` info [Changelog] - New function `*A2AApplyClusterRecoveryPointInput.GetApplyClusterRecoveryPointProviderSpecificInput() *ApplyClusterRecoveryPointProviderSpecificInput` info [Changelog] - New function `*A2AClusterRecoveryPointDetails.GetClusterProviderSpecificRecoveryPointDetails() *ClusterProviderSpecificRecoveryPointDetails` info [Changelog] - New function `*A2AClusterTestFailoverInput.GetClusterTestFailoverProviderSpecificInput() *ClusterTestFailoverProviderSpecificInput` info [Changelog] - New function `*A2AClusterUnplannedFailoverInput.GetClusterUnplannedFailoverProviderSpecificInput() *ClusterUnplannedFailoverProviderSpecificInput` info [Changelog] - New function `*A2AReplicationProtectionClusterDetails.GetReplicationClusterProviderSpecificSettings() *ReplicationClusterProviderSpecificSettings` info [Changelog] - New function `*A2ASharedDiskReplicationDetails.GetSharedDiskReplicationProviderSpecificSettings() *SharedDiskReplicationProviderSpecificSettings` info [Changelog] - New function `*A2ASwitchClusterProtectionInput.GetSwitchClusterProtectionProviderSpecificInput() *SwitchClusterProtectionProviderSpecificInput` info [Changelog] - New function `*ApplyClusterRecoveryPointProviderSpecificInput.GetApplyClusterRecoveryPointProviderSpecificInput() *ApplyClusterRecoveryPointProviderSpecificInput` info [Changelog] - New function `*ClientFactory.NewClusterRecoveryPointClient() *ClusterRecoveryPointClient` info [Changelog] - New function `*ClientFactory.NewClusterRecoveryPointsClient() *ClusterRecoveryPointsClient` info [Changelog] - New function `*ClientFactory.NewReplicationProtectionClustersClient() *ReplicationProtectionClustersClient` info [Changelog] - New function `*ClusterFailoverJobDetails.GetJobDetails() *JobDetails` info [Changelog] - New function `*ClusterProviderSpecificRecoveryPointDetails.GetClusterProviderSpecificRecoveryPointDetails() *ClusterProviderSpecificRecoveryPointDetails` info [Changelog] - New function `NewClusterRecoveryPointClient(string, string, string, string, string, azcore.TokenCredential, *arm.ClientOptions) (*ClusterRecoveryPointClient, error)` info [Changelog] - New function `*ClusterRecoveryPointClient.Get(context.Context, string, string, *ClusterRecoveryPointClientGetOptions) (ClusterRecoveryPointClientGetResponse, error)` info [Changelog] - New function `NewClusterRecoveryPointsClient(string, string, string, string, string, azcore.TokenCredential, *arm.ClientOptions) (*ClusterRecoveryPointsClient, error)` info [Changelog] - New function `*ClusterRecoveryPointsClient.NewListByReplicationProtectionClusterPager(string, *ClusterRecoveryPointsClientListByReplicationProtectionClusterOptions) *runtime.Pager[ClusterRecoveryPointsClientListByReplicationProtectionClusterResponse]` info [Changelog] - New function `*ClusterSwitchProtectionJobDetails.GetJobDetails() *JobDetails` info [Changelog] - New function `*ClusterTestFailoverJobDetails.GetJobDetails() *JobDetails` info [Changelog] - New function `*ClusterTestFailoverProviderSpecificInput.GetClusterTestFailoverProviderSpecificInput() *ClusterTestFailoverProviderSpecificInput` info [Changelog] - New function `*ClusterUnplannedFailoverProviderSpecificInput.GetClusterUnplannedFailoverProviderSpecificInput() *ClusterUnplannedFailoverProviderSpecificInput` info [Changelog] - New function `*ReplicationClusterProviderSpecificSettings.GetReplicationClusterProviderSpecificSettings() *ReplicationClusterProviderSpecificSettings` info [Changelog] - New function `NewReplicationProtectionClustersClient(string, string, string, string, string, azcore.TokenCredential, *arm.ClientOptions) (*ReplicationProtectionClustersClient, error)` info [Changelog] - New function `*ReplicationProtectionClustersClient.BeginApplyRecoveryPoint(context.Context, string, ApplyClusterRecoveryPointInput, *ReplicationProtectionClustersClientBeginApplyRecoveryPointOptions) (*runtime.Poller[ReplicationProtectionClustersClientApplyRecoveryPointResponse], error)` info [Changelog] - New function `*ReplicationProtectionClustersClient.BeginCreate(context.Context, string, string, ReplicationProtectionCluster, *ReplicationProtectionClustersClientBeginCreateOptions) (*runtime.Poller[ReplicationProtectionClustersClientCreateResponse], error)` info [Changelog] - New function `*ReplicationProtectionClustersClient.BeginFailoverCommit(context.Context, string, *ReplicationProtectionClustersClientBeginFailoverCommitOptions) (*runtime.Poller[ReplicationProtectionClustersClientFailoverCommitResponse], error)` info [Changelog] - New function `*ReplicationProtectionClustersClient.Get(context.Context, string, *ReplicationProtectionClustersClientGetOptions) (ReplicationProtectionClustersClientGetResponse, error)` info [Changelog] - New function `*ReplicationProtectionClustersClient.GetOperationResults(context.Context, string, string, *ReplicationProtectionClustersClientGetOperationResultsOptions) (ReplicationProtectionClustersClientGetOperationResultsResponse, error)` info [Changelog] - New function `*ReplicationProtectionClustersClient.NewListByReplicationProtectionContainersPager(string, *ReplicationProtectionClustersClientListByReplicationProtectionContainersOptions) *runtime.Pager[ReplicationProtectionClustersClientListByReplicationProtectionContainersResponse]` info [Changelog] - New function `*ReplicationProtectionClustersClient.NewListPager(string, *ReplicationProtectionClustersClientListOptions) *runtime.Pager[ReplicationProtectionClustersClientListResponse]` info [Changelog] - New function `*ReplicationProtectionClustersClient.BeginPurge(context.Context, string, string, *ReplicationProtectionClustersClientBeginPurgeOptions) (*runtime.Poller[ReplicationProtectionClustersClientPurgeResponse], error)` info [Changelog] - New function `*ReplicationProtectionClustersClient.BeginRepairReplication(context.Context, string, *ReplicationProtectionClustersClientBeginRepairReplicationOptions) (*runtime.Poller[ReplicationProtectionClustersClientRepairReplicationResponse], error)` info [Changelog] - New function `*ReplicationProtectionClustersClient.BeginTestFailover(context.Context, string, ClusterTestFailoverInput, *ReplicationProtectionClustersClientBeginTestFailoverOptions) (*runtime.Poller[ReplicationProtectionClustersClientTestFailoverResponse], error)` info [Changelog] - New function `*ReplicationProtectionClustersClient.BeginTestFailoverCleanup(context.Context, string, ClusterTestFailoverCleanupInput, *ReplicationProtectionClustersClientBeginTestFailoverCleanupOptions) (*runtime.Poller[ReplicationProtectionClustersClientTestFailoverCleanupResponse], error)` info [Changelog] - New function `*ReplicationProtectionClustersClient.BeginUnplannedFailover(context.Context, string, ClusterUnplannedFailoverInput, *ReplicationProtectionClustersClientBeginUnplannedFailoverOptions) (*runtime.Poller[ReplicationProtectionClustersClientUnplannedFailoverResponse], error)` info [Changelog] - New function `*ReplicationProtectionContainersClient.BeginSwitchClusterProtection(context.Context, string, SwitchClusterProtectionInput, *ReplicationProtectionContainersClientBeginSwitchClusterProtectionOptions) (*runtime.Poller[ReplicationProtectionContainersClientSwitchClusterProtectionResponse], error)` info [Changelog] - New function `*SharedDiskReplicationProviderSpecificSettings.GetSharedDiskReplicationProviderSpecificSettings() *SharedDiskReplicationProviderSpecificSettings` info [Changelog] - New function `*SwitchClusterProtectionProviderSpecificInput.GetSwitchClusterProtectionProviderSpecificInput() *SwitchClusterProtectionProviderSpecificInput` info [Changelog] - New struct `A2AApplyClusterRecoveryPointInput` info [Changelog] - New struct `A2AClusterRecoveryPointDetails` info [Changelog] - New struct `A2AClusterTestFailoverInput` info [Changelog] - New struct `A2AClusterUnplannedFailoverInput` info [Changelog] - New struct `A2AProtectedItemDetail` info [Changelog] - New struct `A2AReplicationProtectionClusterDetails` info [Changelog] - New struct `A2ASharedDiskIRErrorDetails` info [Changelog] - New struct `A2ASharedDiskReplicationDetails` info [Changelog] - New struct `A2ASwitchClusterProtectionInput` info [Changelog] - New struct `ApplyClusterRecoveryPointInput` info [Changelog] - New struct `ApplyClusterRecoveryPointInputProperties` info [Changelog] - New struct `ClusterFailoverJobDetails` info [Changelog] - New struct `ClusterRecoveryPoint` info [Changelog] - New struct `ClusterRecoveryPointCollection` info [Changelog] - New struct `ClusterRecoveryPointProperties` info [Changelog] - New struct `ClusterSwitchProtectionJobDetails` info [Changelog] - New struct `ClusterTestFailoverCleanupInput` info [Changelog] - New struct `ClusterTestFailoverCleanupInputProperties` info [Changelog] - New struct `ClusterTestFailoverInput` info [Changelog] - New struct `ClusterTestFailoverInputProperties` info [Changelog] - New struct `ClusterTestFailoverJobDetails` info [Changelog] - New struct `ClusterUnplannedFailoverInput` info [Changelog] - New struct `ClusterUnplannedFailoverInputProperties` info [Changelog] - New struct `ErrorAdditionalInfo` info [Changelog] - New struct `ErrorDetail` info [Changelog] - New struct `ErrorResponse` info [Changelog] - New struct `RegisteredClusterNodes` info [Changelog] - New struct `ReplicationProtectionCluster` info [Changelog] - New struct `ReplicationProtectionClusterCollection` info [Changelog] - New struct `ReplicationProtectionClusterProperties` info [Changelog] - New struct `ServiceDefaultError` info [Changelog] - New struct `ServiceDefaultErrorError` info [Changelog] - New struct `SharedDiskReplicationItemProperties` info [Changelog] - New struct `SwitchClusterProtectionInput` info [Changelog] - New struct `SwitchClusterProtectionInputProperties` info [Changelog] - New field `ProtectionClusterID` in struct `A2AEnableProtectionInput` info [Changelog] - New field `IsClusterInfraReady`, `ProtectionClusterID` in struct `A2AReplicationDetails` info [Changelog] info [Changelog] Total 0 breaking change(s), 121 additive change(s).
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
️✔️Succeeded [Logs] Generate from 3b70b517ff02eb1a7f9095fef86821f42b9c738e. SDK Automation 14.0.0command sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json warn File azure-sdk-for-js_tmp/initOutput.json not found to read command sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
️✔️@azure/arm-recoveryservices-siterecovery [View full logs] [Preview SDK Changes] Breaking Change Detectedinfo [Changelog] **Features** info [Changelog] info [Changelog] - Added operation group ClusterRecoveryPointOperations info [Changelog] - Added operation group ClusterRecoveryPoints info [Changelog] - Added operation group ReplicationProtectionClusters info [Changelog] - Added operation ReplicationProtectionContainers.beginSwitchClusterProtection info [Changelog] - Added operation ReplicationProtectionContainers.beginSwitchClusterProtectionAndWait info [Changelog] - Added Interface A2AApplyClusterRecoveryPointInput info [Changelog] - Added Interface A2AClusterRecoveryPointDetails info [Changelog] - Added Interface A2AClusterTestFailoverInput info [Changelog] - Added Interface A2AClusterUnplannedFailoverInput info [Changelog] - Added Interface A2AProtectedItemDetail info [Changelog] - Added Interface A2AReplicationProtectionClusterDetails info [Changelog] - Added Interface A2ASharedDiskIRErrorDetails info [Changelog] - Added Interface A2ASharedDiskReplicationDetails info [Changelog] - Added Interface A2ASwitchClusterProtectionInput info [Changelog] - Added Interface ApplyClusterRecoveryPointInput info [Changelog] - Added Interface ApplyClusterRecoveryPointInputProperties info [Changelog] - Added Interface ApplyClusterRecoveryPointProviderSpecificInput info [Changelog] - Added Interface ClusterFailoverJobDetails info [Changelog] - Added Interface ClusterProviderSpecificRecoveryPointDetails info [Changelog] - Added Interface ClusterRecoveryPoint info [Changelog] - Added Interface ClusterRecoveryPointCollection info [Changelog] - Added Interface ClusterRecoveryPointGetOptionalParams info [Changelog] - Added Interface ClusterRecoveryPointProperties info [Changelog] - Added Interface ClusterRecoveryPointsListByReplicationProtectionClusterNextOptionalParams info [Changelog] - Added Interface ClusterRecoveryPointsListByReplicationProtectionClusterOptionalParams info [Changelog] - Added Interface ClusterSwitchProtectionJobDetails info [Changelog] - Added Interface ClusterTestFailoverCleanupInput info [Changelog] - Added Interface ClusterTestFailoverCleanupInputProperties info [Changelog] - Added Interface ClusterTestFailoverInput info [Changelog] - Added Interface ClusterTestFailoverInputProperties info [Changelog] - Added Interface ClusterTestFailoverJobDetails info [Changelog] - Added Interface ClusterTestFailoverProviderSpecificInput info [Changelog] - Added Interface ClusterUnplannedFailoverInput info [Changelog] - Added Interface ClusterUnplannedFailoverInputProperties info [Changelog] - Added Interface ClusterUnplannedFailoverProviderSpecificInput info [Changelog] - Added Interface ErrorAdditionalInfo info [Changelog] - Added Interface ErrorDetail info [Changelog] - Added Interface ErrorResponse info [Changelog] - Added Interface RegisteredClusterNodes info [Changelog] - Added Interface ReplicationClusterProviderSpecificSettings info [Changelog] - Added Interface ReplicationProtectionCluster info [Changelog] - Added Interface ReplicationProtectionClusterCollection info [Changelog] - Added Interface ReplicationProtectionClusterProperties info [Changelog] - Added Interface ReplicationProtectionClustersApplyRecoveryPointHeaders info [Changelog] - Added Interface ReplicationProtectionClustersApplyRecoveryPointOptionalParams info [Changelog] - Added Interface ReplicationProtectionClustersCreateOptionalParams info [Changelog] - Added Interface ReplicationProtectionClustersFailoverCommitHeaders info [Changelog] - Added Interface ReplicationProtectionClustersFailoverCommitOptionalParams info [Changelog] - Added Interface ReplicationProtectionClustersGetOperationResultsOptionalParams info [Changelog] - Added Interface ReplicationProtectionClustersGetOptionalParams info [Changelog] - Added Interface ReplicationProtectionClustersListByReplicationProtectionContainersNextOptionalParams info [Changelog] - Added Interface ReplicationProtectionClustersListByReplicationProtectionContainersOptionalParams info [Changelog] - Added Interface ReplicationProtectionClustersListNextOptionalParams info [Changelog] - Added Interface ReplicationProtectionClustersListOptionalParams info [Changelog] - Added Interface ReplicationProtectionClustersPurgeHeaders info [Changelog] - Added Interface ReplicationProtectionClustersPurgeOptionalParams info [Changelog] - Added Interface ReplicationProtectionClustersRepairReplicationHeaders info [Changelog] - Added Interface ReplicationProtectionClustersRepairReplicationOptionalParams info [Changelog] - Added Interface ReplicationProtectionClustersTestFailoverCleanupHeaders info [Changelog] - Added Interface ReplicationProtectionClustersTestFailoverCleanupOptionalParams info [Changelog] - Added Interface ReplicationProtectionClustersTestFailoverHeaders info [Changelog] - Added Interface ReplicationProtectionClustersTestFailoverOptionalParams info [Changelog] - Added Interface ReplicationProtectionClustersUnplannedFailoverHeaders info [Changelog] - Added Interface ReplicationProtectionClustersUnplannedFailoverOptionalParams info [Changelog] - Added Interface ReplicationProtectionContainersSwitchClusterProtectionHeaders info [Changelog] - Added Interface ReplicationProtectionContainersSwitchClusterProtectionOptionalParams info [Changelog] - Added Interface ReplicationProtectionContainersSwitchProtectionHeaders info [Changelog] - Added Interface ServiceDefaultError info [Changelog] - Added Interface ServiceDefaultErrorError info [Changelog] - Added Interface SharedDiskReplicationItemProperties info [Changelog] - Added Interface SharedDiskReplicationProviderSpecificSettings info [Changelog] - Added Interface SwitchClusterProtectionInput info [Changelog] - Added Interface SwitchClusterProtectionInputProperties info [Changelog] - Added Interface SwitchClusterProtectionProviderSpecificInput info [Changelog] - Added Type Alias ApplyClusterRecoveryPointProviderSpecificInputUnion info [Changelog] - Added Type Alias ClusterProviderSpecificRecoveryPointDetailsUnion info [Changelog] - Added Type Alias ClusterRecoveryPointGetResponse info [Changelog] - Added Type Alias ClusterRecoveryPointsListByReplicationProtectionClusterNextResponse info [Changelog] - Added Type Alias ClusterRecoveryPointsListByReplicationProtectionClusterResponse info [Changelog] - Added Type Alias ClusterRecoveryPointType info [Changelog] - Added Type Alias ClusterTestFailoverProviderSpecificInputUnion info [Changelog] - Added Type Alias ClusterUnplannedFailoverProviderSpecificInputUnion info [Changelog] - Added Type Alias ReplicationClusterProviderSpecificSettingsUnion info [Changelog] - Added Type Alias ReplicationProtectionClustersApplyRecoveryPointResponse info [Changelog] - Added Type Alias ReplicationProtectionClustersCreateResponse info [Changelog] - Added Type Alias ReplicationProtectionClustersFailoverCommitResponse info [Changelog] - Added Type Alias ReplicationProtectionClustersGetOperationResultsResponse info [Changelog] - Added Type Alias ReplicationProtectionClustersGetResponse info [Changelog] - Added Type Alias ReplicationProtectionClustersListByReplicationProtectionContainersNextResponse info [Changelog] - Added Type Alias ReplicationProtectionClustersListByReplicationProtectionContainersResponse info [Changelog] - Added Type Alias ReplicationProtectionClustersListNextResponse info [Changelog] - Added Type Alias ReplicationProtectionClustersListResponse info [Changelog] - Added Type Alias ReplicationProtectionClustersPurgeResponse info [Changelog] - Added Type Alias ReplicationProtectionClustersRepairReplicationResponse info [Changelog] - Added Type Alias ReplicationProtectionClustersTestFailoverCleanupResponse info [Changelog] - Added Type Alias ReplicationProtectionClustersTestFailoverResponse info [Changelog] - Added Type Alias ReplicationProtectionClustersUnplannedFailoverResponse info [Changelog] - Added Type Alias ReplicationProtectionContainersSwitchClusterProtectionResponse info [Changelog] - Added Type Alias SharedDiskReplicationProviderSpecificSettingsUnion info [Changelog] - Added Type Alias SwitchClusterProtectionProviderSpecificInputUnion info [Changelog] - Interface A2AEnableProtectionInput has a new optional parameter protectionClusterId info [Changelog] - Interface A2AReplicationDetails has a new optional parameter isClusterInfraReady info [Changelog] - Interface A2AReplicationDetails has a new optional parameter protectionClusterId info [Changelog] - Type of parameter instanceType of interface JobDetails is changed from "AsrJobDetails" | "ExportJobDetails" | "FailoverJobDetails" | "SwitchProtectionJobDetails" | "TestFailoverJobDetails" to "AsrJobDetails" | "ClusterFailoverJobDetails" | "ClusterSwitchProtectionJobDetails" | "ClusterTestFailoverJobDetails" | "ExportJobDetails" | "FailoverJobDetails" | "SwitchProtectionJobDetails" | "TestFailoverJobDetails" info [Changelog] - Added Enum KnownClusterRecoveryPointType info [Changelog] info [Changelog] **Breaking Changes** info [Changelog] info [Changelog] - Class SiteRecoveryManagementClient has a new signature
️⚠️ azure-resource-manager-schemas warning [Detail]
⚠️Warning [Logs] Generate from 3b70b517ff02eb1a7f9095fef86821f42b9c738e. Schema Automation 14.0.0command .sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json cmderr [initScript.sh] notice cmderr [initScript.sh] npm notice New minor version of npm available! 10.2.4 -> 10.4.0 cmderr [initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.4.0> cmderr [initScript.sh] npm notice Run `npm install -g [email protected]` to update! cmderr [initScript.sh] npm notice warn File azure-resource-manager-schemas_tmp/initOutput.json not found to read command .sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
️✔️recoveryservicessiterecovery [View full logs] [Preview Schema Changes]
️️✔️ azure-powershell succeeded [Detail] [Expand]
️✔️Succeeded [Logs] Generate from 3b70b517ff02eb1a7f9095fef86821f42b9c738e. SDK Automation 14.0.0command sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json command pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
️✔️Az.recoveryservicessiterecovery.DefaultTag [View full logs] [Preview SDK Changes]
Generated ApiView
| Language | Package Name | ApiView Link |
|---|---|---|
| Go | sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery | https://apiview.dev/Assemblies/Review/002d4025b23b4299a8d5ac660d16826d?revisionId=bc837af511b849c08153ba1007f52979 |
| Java | azure-resourcemanager-recoveryservicessiterecovery | https://apiview.dev/Assemblies/Review/56a0cbaa5df94d7b8fd51641094fb1f3?revisionId=85d3c6d07c784c9f9c5e515dcb3af584 |
| JavaScript | @azure/arm-recoveryservices-siterecovery | Create ApiView timeout. Package is too large and we cannot create ApiView for it. |
| Swagger | Microsoft.RecoveryServices | https://apiview.dev/Assemblies/Review/87cb55db6e9f4146a1f242e528aece8b?revisionId=55449120b8a347488700a81e8e44bc30 |
Hi @midhunpramod19! For review efficiency consideration, when creating a new API version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version.
For more details refer to the wiki.
![openapi-workflow-bot[bot] avatar](https://avatars.githubusercontent.com/in/81125?v=4 "Published by a pub.dev verified publisher"){kind=small}
Can you please fix the newly introduced Lint errors here : https://github.com/Azure/azure-rest-api-specs/pull/27514/checks?check_run_id=20809370624
Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
Please include [ARM Query] in the title of your question to indicate that it is ARM-related.
Can you please fix the newly introduced Lint errors here : https://github.com/Azure/azure-rest-api-specs/pull/27514/checks?check_run_id=20809370624
Have resolved all link errors, could not resolve the last linting error(AvoidAdditionalProperties) as we are inheriting an existing model. The existing model has the additionProperties field in it. What is the guidance to fix this? As it is already existing and we just inherited it.
Please fix all the issues like Linter errors, Model Validation errors, Breaking changes etc. in your PR here.
Can you please fix the newly introduced Lint errors here : https://github.com/Azure/azure-rest-api-specs/pull/27514/checks?check_run_id=20809370624
Have resolved all link errors, could not resolve the last linting error(AvoidAdditionalProperties) as we are inheriting an existing model. The existing model has the additionProperties field in it. What is the guidance to fix this? As it is already existing and we just inherited it.
Have fixed all issues except this. Need guidance on this.
Can you please fix the newly introduced Lint errors here : https://github.com/Azure/azure-rest-api-specs/pull/27514/checks?check_run_id=20809370624
Have resolved all link errors, could not resolve the last linting error(AvoidAdditionalProperties) as we are inheriting an existing model. The existing model has the additionProperties field in it. What is the guidance to fix this? As it is already existing and we just inherited it.
Have fixed all issues except this. Need guidance on this.
Got it. Please apply for suppression for this particular one. See Additional information section above in this PR.
"type": "string"
Are these VM nodes? If yes, please use https://github.com/Azure/autorest/blob/main/docs/extensions/readme.md#x-ms-arm-id-details here.
Refers to: specification/recoveryservicessiterecovery/resource-manager/Microsoft.RecoveryServices/stable/2024-02-01/service.json:9516 in 845372a. [](commit_id = 845372a7ce28f2989aefddd8704343449fce7a10, deletion_comment = False)
"type": "string"
Use https://github.com/Azure/autorest/blob/main/docs/extensions/readme.md#x-ms-arm-id-details here if it is an ARM Resource.
Refers to: specification/recoveryservicessiterecovery/resource-manager/Microsoft.RecoveryServices/stable/2024-02-01/service.json:9547 in 845372a. [](commit_id = 845372a7ce28f2989aefddd8704343449fce7a10, deletion_comment = False)
"type": "string"
Use https://github.com/Azure/autorest/blob/main/docs/extensions/readme.md#x-ms-arm-id-details here if it is an ARM Resource.
Refers to: specification/recoveryservicessiterecovery/resource-manager/Microsoft.RecoveryServices/stable/2024-02-01/service.json:9553 in 845372a. [](commit_id = 845372a7ce28f2989aefddd8704343449fce7a10, deletion_comment = False)
"type": "string",
Why is it not enum then?
Refers to: specification/recoveryservicessiterecovery/resource-manager/Microsoft.RecoveryServices/stable/2024-02-01/service.json:11177 in 845372a. [](commit_id = 845372a7ce28f2989aefddd8704343449fce7a10, deletion_comment = False)
"type": "string",
Should this be an array here?
Refers to: specification/recoveryservicessiterecovery/resource-manager/Microsoft.RecoveryServices/stable/2024-02-01/service.json:11187 in 845372a. [](commit_id = 845372a7ce28f2989aefddd8704343449fce7a10, deletion_comment = False)
"type": "string"
Should this be an enum here?
Refers to: specification/recoveryservicessiterecovery/resource-manager/Microsoft.RecoveryServices/stable/2024-02-01/service.json:12022 in 845372a. [](commit_id = 845372a7ce28f2989aefddd8704343449fce7a10, deletion_comment = False)
"ClusterRecoveryPoint": {
[ARMBlockingComment] Please use the definition of resource from here: https://github.com/Azure/azure-rest-api-specs/blob/main/specification/common-types/resource-management/v5/types.json, instead of defining all properties here.
Refers to: specification/recoveryservicessiterecovery/resource-manager/Microsoft.RecoveryServices/stable/2024-02-01/service.json:12390 in 845372a. [](commit_id = 845372a7ce28f2989aefddd8704343449fce7a10, deletion_comment = False)
"recoveryPointType": {
Use enum here instead of string.
Refers to: specification/recoveryservicessiterecovery/resource-manager/Microsoft.RecoveryServices/stable/2024-02-01/service.json:12438 in a5f8db8. [](commit_id = a5f8db88e71edb888c21fb90410697f22562ff60, deletion_comment = False)
"properties": {
Same here, use TrackedResource or ProxyResource definition from common types.
Refers to: specification/recoveryservicessiterecovery/resource-manager/Microsoft.RecoveryServices/stable/2024-02-01/service.json:23689 in 845372a. [](commit_id = 845372a7ce28f2989aefddd8704343449fce7a10, deletion_comment = False)
"ClusterRecoveryPoint": {[ARMBlockingComment] Please use the definition of resource from here: https://github.com/Azure/azure-rest-api-specs/blob/main/specification/common-types/resource-management/v5/types.json, instead of defining all properties here.
Refers to: specification/recoveryservicessiterecovery/resource-manager/Microsoft.RecoveryServices/stable/2024-02-01/service.json:12390 in 845372a. [](commit_id = 845372a, deletion_comment = False)
Our service is currently not returning SystemData field defined in the proxy resource definition. So, we cannot use this definition.
"type": "string",Why is it not enum then?
Refers to: specification/recoveryservicessiterecovery/resource-manager/Microsoft.RecoveryServices/stable/2024-02-01/service.json:11177 in 845372a. [](commit_id = 845372a, deletion_comment = False)
These errors are thrown by other microservices, there are multiple errors which can be thrown. The management service does not keep track of them and returns these error codes as string.
"type": "string",Should this be an array here?
Refers to: specification/recoveryservicessiterecovery/resource-manager/Microsoft.RecoveryServices/stable/2024-02-01/service.json:11187 in 845372a. [](commit_id = 845372a, deletion_comment = False)
No this is a string, Service returns a single string with all possible causes.
Can you please fix the newly introduced Lint errors here : https://github.com/Azure/azure-rest-api-specs/pull/27514/checks?check_run_id=20809370624
Have resolved all link errors, could not resolve the last linting error(AvoidAdditionalProperties) as we are inheriting an existing model. The existing model has the additionProperties field in it. What is the guidance to fix this? As it is already existing and we just inherited it.
Have fixed all issues except this. Need guidance on this.
Got it. Please apply for suppression for this particular one. See Additional information section above in this PR.
It mentions to ask the PR assignee to apply the suppression.
The PR has multiple LintDiff errors, can you fix them first before starting the review.
Can you please fix the newly introduced Lint errors here : https://github.com/Azure/azure-rest-api-specs/pull/27514/checks?check_run_id=20809370624
Have resolved all link errors, could not resolve the last linting error(AvoidAdditionalProperties) as we are inheriting an existing model. The existing model has the additionProperties field in it. What is the guidance to fix this? As it is already existing and we just inherited it.
Need to suppress the lint diff error as already explained above. Not sure what is failing in the Swagger SDK breaking change error. Need guidance on how to fix these.
PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts.
"name": "resourceName",
I could see A parameter is defined for {resourceName} below. why can't you refer the parameter instead of defining like this every time ?
Refers to: specification/recoveryservicessiterecovery/resource-manager/Microsoft.RecoveryServices/stable/2024-02-01/service.json:4564 in abc63ae. [](commit_id = abc63aef6c2ac8040addc3276f2d70f84fef505e, deletion_comment = False)
"$ref": "../../../../../common-types/resource-management/v2/types.json#/definitions/ErrorResponse"
consider moving to latest common-types i.e v5
Refers to: specification/recoveryservicessiterecovery/resource-manager/Microsoft.RecoveryServices/stable/2024-02-01/service.json:4605 in abc63ae. [](commit_id = abc63aef6c2ac8040addc3276f2d70f84fef505e, deletion_comment = False)
}
you can define them as parameters in once place and ref them where ever needed, instead of defining them every time like this.
Refers to: specification/recoveryservicessiterecovery/resource-manager/Microsoft.RecoveryServices/stable/2024-02-01/service.json:4593 in abc63ae. [](commit_id = abc63aef6c2ac8040addc3276f2d70f84fef505e, deletion_comment = False)