ARM (Control Plane) API Specification Update Pull Request

[!TIP] Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

[!NOTE] As of January 2024 there is no PR assignee. This is expected. See https://aka.ms/azsdk/pr-arm-review.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

diagram

Click here to see the details of Step 1

Breaking changes review (Diagram Step 1)

If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you, you must follow the breaking changes process.
IMPORTANT This applies even if:

The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
You believe there is no need for you to request breaking change approval, for any reason. Such claims must be reviewed, and the process is the same.

Click here to see the details of Step 2

ARM API changes review (Diagram Step 2)

For help with Step 2 / "ARM review", see https://aka.ms/azsdk/pr-arm-review.

Click here to see the diagram footnotes

Diagram footnotes

[1] See ARM review queue (for PR merge queues, see [2]).
[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
The ARM reviewer on-call engineer visits the merge queue twice a day, so the approximate ETA for merges is 12 - 24 hours.

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

[ ] New resource provider.
[ ] New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been generated using OpenAPI Hub).
[ ] Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
[ ] Update existing version to fix OpenAPI spec quality issues in S360.
[ ] Other, please clarify:
- edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood and followed the instructions by checking all the boxes:

[ ] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
[ ] I have reviewed following Resource Provider guidelines, including ARM resource provider contract and REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the suppressions guide to get approval.

Getting help

First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure and https://aka.ms/ci-fix.
For help with PR workflow diagram Step 2 (ARM review), see https://aka.ms/azsdk/pr-arm-review.
If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run. This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

Jan 22 '24 16:01 haagha

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see https://aka.ms/azsdk/specreview/merge.

Jan 22 '24 16:01 openapi-pipeline-app[bot]

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

Compared specs (v0.10.5)	new version	base version
availabilitySet.json	2024-03-01(8dd2c86)	2023-09-01(main)
capacityReservation.json	2024-03-01(8dd2c86)	2023-09-01(main)
computeRPCommon.json	2024-03-01(8dd2c86)	2023-09-01(main)
dedicatedHost.json	2024-03-01(8dd2c86)	2023-09-01(main)
image.json	2024-03-01(8dd2c86)	2023-09-01(main)
logAnalytic.json	2024-03-01(8dd2c86)	2023-09-01(main)
proximityPlacementGroup.json	2024-03-01(8dd2c86)	2023-09-01(main)
restorePoint.json	2024-03-01(8dd2c86)	2023-09-01(main)
runCommand.json	2024-03-01(8dd2c86)	2023-09-01(main)
sshPublicKey.json	2024-03-01(8dd2c86)	2023-09-01(main)
virtualMachine.json	2024-03-01(8dd2c86)	2023-09-01(main)
virtualMachineExtensionImage.json	2024-03-01(8dd2c86)	2023-09-01(main)
virtualMachineImage.json	2024-03-01(8dd2c86)	2023-09-01(main)
virtualMachineScaleSet.json	2024-03-01(8dd2c86)	2023-09-01(main)

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️🔄LintDiff inProgress [Detail]

️⚠️Avocado: 2 Warnings warning [Detail]

Rule	Message
:warning: MULTIPLE_API_VERSION	The default tag contains multiple API versions swaggers. readme: specification/compute/resource-manager/readme.md tag: specification/compute/resource-manager/readme.md#tag-package-2024-03-01
:warning: CIRCULAR_REFERENCE	The JSON file has a circular reference. readme: specification/compute/resource-manager/readme.md json: ComputeRP/stable/2024-03-01/virtualMachine.json

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

️️✔️Automated merging requirements met succeeded [Detail] [Expand]

_{Posted by Swagger Pipeline | How to fix these errors?}

Jan 22 '24 16:01 openapi-pipeline-app[bot]

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌ azure-sdk-for-net-track2 failed [Detail]

❌Failed [Logs] Generate from a7f8c7697cb1b6f9479cea83600daa292d71c91c. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1mGeneratePackage: [0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1m[0m[36;1mLine |[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1m[0m[36;1m[36;1m 714 | [0m         [36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s[0m …[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1m[0m[36;1m[36;1m[0m[36;1m[0m[36;1m     | [31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1m[0m[36;1m[36;1m[0m[36;1m[0m[36;1m[31;1m[31;1m[36;1m     | [31;1mFailed to generate sdk. exit code: False[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1mGet-ChildItem: [0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:807[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1m[0m[36;1mLine |[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1m[0m[36;1m[36;1m 807 | [0m … rtifacts += [36;1mGet-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s[0m …[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1m[0m[36;1m[36;1m[0m[36;1m[0m[36;1m     | [31;1m               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1m[0m[36;1m[36;1m[0m[36;1m[0m[36;1m[31;1m[31;1m[36;1m     | [31;1mCannot find path[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1m[0m[36;1m[36;1m[0m[36;1m[0m[36;1m[31;1m[31;1m[36;1m[31;1m[36;1m     | [31;1m'/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1m[0m[36;1m[36;1m[0m[36;1m[0m[36;1m[31;1m[31;1m[36;1m[31;1m[36;1m[31;1m[36;1m     | [31;1mit does not exist.[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1mGeneratePackage: [0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1m[0m[36;1mLine |[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1m[0m[36;1m[36;1m 714 | [0m         [36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s[0m …[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1m[0m[36;1m[36;1m[0m[36;1m[0m[36;1m     | [31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1m[0m[36;1m[36;1m[0m[36;1m[0m[36;1m[31;1m[31;1m[36;1m     | [31;1mFailed to generate sdk artifact[0m

❌Azure.ResourceManager.Compute [View full logs] [Preview SDK Changes]
```
info	[Changelog]
```

️⚠️ azure-sdk-for-python warning [Detail]

⚠️Warning [Logs] Generate from a7f8c7697cb1b6f9479cea83600daa292d71c91c. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh] npm notice
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 10.2.4 -> 10.5.0
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.5.0>
cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[automation_generate.sh] npm notice
warn	No file changes detected after generation
warn	No package detected after generation

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs] Generate from a7f8c7697cb1b6f9479cea83600daa292d71c91c. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 24.0
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 24.0
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] rd  Average Speed   Time    Time     Time  Current
cmderr	[init.sh]                                  Dload  Upload   Total   Spent    Left  Speed
cmderr	[init.sh] 
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     012k
cmderr	[init.sh]  notice
cmderr	[init.sh] npm notice New minor version of npm available! 10.2.4 -> 10.5.0
cmderr	[init.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.5.0>
cmderr	[init.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[init.sh] npm notice
cmderr	[init.sh] Downloading https://nodejs.org/dist/v18.15.0/node-v18.15.0-linux-x64.tar.xz...
cmderr	[init.sh] ######################################## 100.0%
cmderr	[init.sh] Computing checksum with sha256sum
cmderr	[init.sh] Checksums matched!
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-compute-generated [View full logs] [Preview SDK Changes]

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from a7f8c7697cb1b6f9479cea83600daa292d71c91c. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-compute [View full logs] [Preview SDK Changes]

azure-arm-compute-21.6.0.tgz

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added Interface EventGridAndResourceGraph
info	[Changelog]   - Added Interface ScheduledEventsAdditionalPublishingTargets
info	[Changelog]   - Added Interface ScheduledEventsPolicy
info	[Changelog]   - Added Interface UserInitiatedReboot
info	[Changelog]   - Added Interface UserInitiatedRedeploy
info	[Changelog]   - Added Type Alias ResourceIdOptionsForGetCapacityReservationGroups
info	[Changelog]   - Interface CapacityReservationGroupsListBySubscriptionOptionalParams has a new optional parameter resourceIdsOnly
info	[Changelog]   - Interface DataDisk has a new optional parameter sourceResource
info	[Changelog]   - Interface DataDisksToAttach has a new optional parameter caching
info	[Changelog]   - Interface DataDisksToAttach has a new optional parameter deleteOption
info	[Changelog]   - Interface DataDisksToAttach has a new optional parameter diskEncryptionSet
info	[Changelog]   - Interface DataDisksToAttach has a new optional parameter writeAcceleratorEnabled
info	[Changelog]   - Interface VirtualMachine has a new optional parameter scheduledEventsPolicy
info	[Changelog]   - Interface VirtualMachineScaleSet has a new optional parameter scheduledEventsPolicy
info	[Changelog]   - Interface VirtualMachineScaleSetUpdateOSDisk has a new optional parameter diffDiskSettings
info	[Changelog]   - Interface VirtualMachineScaleSetVMReimageParameters has a new optional parameter forceUpdateOSDiskForEphemeral
info	[Changelog]   - Interface VirtualMachineUpdate has a new optional parameter scheduledEventsPolicy
info	[Changelog]   - Added Enum KnownResourceIdOptionsForGetCapacityReservationGroups
info	[Changelog]   - Enum KnownDiffDiskPlacement has a new value NvmeDisk
info	[Changelog]   - Enum KnownDiskCreateOptionTypes has a new value Copy
info	[Changelog]   - Enum KnownDiskCreateOptionTypes has a new value Restore

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from a7f8c7697cb1b6f9479cea83600daa292d71c91c. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/compute/armcompute [View full logs] [Preview SDK Changes]

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New value `DiffDiskPlacementNvmeDisk` added to enum type `DiffDiskPlacement`
info	[Changelog] - New value `DiskCreateOptionTypesCopy`, `DiskCreateOptionTypesRestore` added to enum type `DiskCreateOptionTypes`
info	[Changelog] - New enum type `ResourceIDOptionsForGetCapacityReservationGroups` with values `ResourceIDOptionsForGetCapacityReservationGroupsAll`, `ResourceIDOptionsForGetCapacityReservationGroupsCreatedInSubscription`, `ResourceIDOptionsForGetCapacityReservationGroupsSharedWithSubscription`
info	[Changelog] - New struct `EventGridAndResourceGraph`
info	[Changelog] - New struct `ScheduledEventsAdditionalPublishingTargets`
info	[Changelog] - New struct `ScheduledEventsPolicy`
info	[Changelog] - New struct `UserInitiatedReboot`
info	[Changelog] - New struct `UserInitiatedRedeploy`
info	[Changelog] - New field `ResourceIDsOnly` in struct `CapacityReservationGroupsClientListBySubscriptionOptions`
info	[Changelog] - New field `SourceResource` in struct `DataDisk`
info	[Changelog] - New field `Caching`, `DeleteOption`, `DiskEncryptionSet`, `WriteAcceleratorEnabled` in struct `DataDisksToAttach`
info	[Changelog] - New field `ScheduledEventsPolicy` in struct `VirtualMachineProperties`
info	[Changelog] - New field `ScheduledEventsPolicy` in struct `VirtualMachineScaleSetProperties`
info	[Changelog] - New field `ForceUpdateOSDiskForEphemeral` in struct `VirtualMachineScaleSetReimageParameters`
info	[Changelog] - New field `DiffDiskSettings` in struct `VirtualMachineScaleSetUpdateOSDisk`
info	[Changelog] - New field `ForceUpdateOSDiskForEphemeral` in struct `VirtualMachineScaleSetVMReimageParameters`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 25 additive change(s).

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs] Generate from a7f8c7697cb1b6f9479cea83600daa292d71c91c. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] npm notice
cmderr	[initScript.sh] npm notice New minor version of npm available! 10.2.4 -> 10.5.0
cmderr	[initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.5.0>
cmderr	[initScript.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[initScript.sh] npm notice
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

️✔️compute [View full logs] [Preview Schema Changes]

️⚠️ azure-powershell warning [Detail]

⚠️Warning [Logs] Generate from a7f8c7697cb1b6f9479cea83600daa292d71c91c. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json

⚠️Az.compute.DefaultTag [View full logs] [Preview SDK Changes]

_{Posted by Swagger Pipeline | How to fix these errors?}

Jan 22 '24 16:01 openapi-pipeline-app[bot]

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/compute/armcompute	https://apiview.dev/Assemblies/Review/08ab188fdab64564bc46944e13addcf9?revisionId=9d6e331ce58542579d183e51ead62950
Java	azure-resourcemanager-compute-generated	https://apiview.dev/Assemblies/Review/eb099b2efb0f4373a854e09003a6b31d?revisionId=39cb268aaa31471bbc68e874f4c28e71
JavaScript	@azure/arm-compute	https://apiview.dev/Assemblies/Review/a802869b6345406cbb6d1e487132d7dd?revisionId=e2477ec71ad84dd5bdc9dd2dd858a0c6
Swagger	Microsoft.Compute	https://apiview.dev/Assemblies/Review/b32a43d6ad48477b9343d7a921e72411?revisionId=bc34c8b2f86d40339778d937d6b589e9

Jan 22 '24 16:01 openapi-pipeline-app[bot]

Hi @haagha! For review efficiency consideration, when creating a new API version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version.
For more details refer to the wiki.

Jan 22 '24 16:01 openapi-workflow-bot[bot]

PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts.

Feb 23 '24 16:02 openapi-pipeline-app[bot]

PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts.

Feb 26 '24 08:02 openapi-pipeline-app[bot]

PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts.

Feb 26 '24 08:02 openapi-pipeline-app[bot]

PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts.

Feb 27 '24 00:02 openapi-pipeline-app[bot]

PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts.

Feb 28 '24 19:02 openapi-pipeline-app[bot]

PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts.

Mar 04 '24 19:03 openapi-pipeline-app[bot]

PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts.

Mar 11 '24 19:03 openapi-pipeline-app[bot]

PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts.

Mar 11 '24 19:03 openapi-pipeline-app[bot]

PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts.

Mar 11 '24 20:03 openapi-pipeline-app[bot]

/azp run

Mar 12 '24 13:03 haagha

PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts.

Mar 12 '24 13:03 openapi-pipeline-app[bot]

Pull request contains merge conflicts.

Mar 12 '24 13:03 azure-pipelines[bot]

This is the Swagger branch for Compute 2024-03-01 release. The branch includes multiple PR's that have been merged and have been signed off by ARM. All PR's into this branch have been reviewed and Signed off by ARM.

#27510 #27734 #27779 #27857 #27957 (Only description change) #27776 #28049 #28074

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

Note

As of January 2024 there is no PR assignee. This is expected. See https://aka.ms/azsdk/pr-arm-review.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

Click here to see the details of Step 1 Click here to see the details of Step 2 Click here to see the diagram footnotes

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

[ ] New resource provider.

[ ] New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been generated using OpenAPI Hub).

[ ] Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)

[ ] Update existing version to fix OpenAPI spec quality issues in S360.

[ ] Other, please clarify:

edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood and followed the instructions by checking all the boxes:

[ ] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.

[ ] I have reviewed following Resource Provider guidelines, including ARM resource provider contract and REST guidelines (estimated time: 4 hours). I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes Suppressing failures

Getting help

First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.

To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.

For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure and https://aka.ms/ci-fix.

For help with PR workflow diagram Step 2 (ARM review), see https://aka.ms/azsdk/pr-arm-review.

If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run. This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.

If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

@haagha Could you please confirm that there is no new changes outside of these PRs that need to be reviewed here right ?

ALso i see a few Lint diff errors from this PR , could you please check : https://github.com/Azure/azure-rest-api-specs/pull/27480/checks?check_run_id=22563150282 ?

Were these not flagged in the original PRs ?

Mar 12 '24 22:03 raosuhas

Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
Please include [ARM Query] in the title of your question to indicate that it is ARM-related.

Mar 12 '24 22:03 openapi-workflow-bot[bot]

PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts.

Mar 18 '24 12:03 openapi-pipeline-app[bot]

@haagha Could you please confirm that there is no new changes outside of these PRs that need to be reviewed here right ?

ALso i see a few Lint diff errors from this PR , could you please check : https://github.com/Azure/azure-rest-api-specs/pull/27480/checks?check_run_id=22563150282 ?

Were these not flagged in the original PRs ?

@raosuhas 2 additional PR's were added (updated in PR description as 9th and 10th PR), and I can confirm there are no other additional changes.

LintDiff error was not flagged in the original PR https://github.com/Azure/azure-rest-api-specs/pull/27779 which introduced a top level property called placement for VirtualMachine. Do I need to suppress this?

Mar 18 '24 13:03 haagha

@raosuhas I generated the .NET SDK for this Swagger and it gave me the error "System.ArgumentException: An item with the same key has already been added. Key: AutomaticallyApprove"

"automaticallyApprove" was added in PR https://github.com/Azure/azure-rest-api-specs/pull/28257 as a boolean as part of 2 different objects. Is this incorrect and what should be the fix?

Mar 18 '24 14:03 haagha

@haagha Could you please confirm that there is no new changes outside of these PRs that need to be reviewed here right ? ALso i see a few Lint diff errors from this PR , could you please check : https://github.com/Azure/azure-rest-api-specs/pull/27480/checks?check_run_id=22563150282 ? Were these not flagged in the original PRs ?

@raosuhas 2 additional PR's were added (updated in PR description as 9th and 10th PR), and I can confirm there are no other additional changes.

LintDiff error was not flagged in the original PR #27779 which introduced a top level property called placement for VirtualMachine. Do I need to suppress this?

@haagha, the error was not found in PR #27779 because the tool was not updated. Please follow the guidance to fix errors in https://github.com/Azure/azure-rest-api-specs/pull/27480/checks?check_run_id=22786211212

Mar 19 '24 01:03 ms-zhenhua

@ms-zhenhua .NET SDK generation CI check fails because there is a bug with flattening in Autorest generator. I added a directive to bypass it and could generate my PR here: https://github.com/Azure/azure-sdk-for-net/pull/42798

Mar 19 '24 14:03 haagha

@ms-zhenhua please refer to the thread by Rotish Singla "Swagger PR for Any Zone Rejection mitigation" to allow for top-level placement property.

Mar 20 '24 13:03 haagha

@haagha - as discussed offline, please wait for 1 day before merging PR in case ARM by passes the rule.

Mar 20 '24 17:03 rosingla

@ms-zhenhua please refer to the thread by Rotish Singla "Swagger PR for Any Zone Rejection mitigation" to allow for top-level placement property.

@haagha, I do not find such thread. Could you double check whether it's sent to me?

Mar 21 '24 00:03 ms-zhenhua

@ms-zhenhua please refer to the thread by Rotish Singla "Swagger PR for Any Zone Rejection mitigation" to allow for top-level placement property.

@haagha, I do not find such thread. Could you double check whether it's sent to me?

@ms-zhenhua No worries, the top-level property has been reverted. This release is ready for merge, all the PR's in this release are ARM SignedOff. All checks except .NET SDK check has passed due to a bug in Autorest, but I was able to generate .NET with SDK team to get around the bug. Here is the generated .NET SDK https://github.com/Azure/azure-sdk-for-net/pull/42798

Mar 21 '24 14:03 haagha

/pr RequestMerge

Mar 21 '24 14:03 haagha

azure-rest-api-specs
azure-rest-api-specs copied to clipboard

[Compute] 2024-03-01

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Breaking changes review (Diagram Step 1)

ARM API changes review (Diagram Step 2)

Diagram footnotes

Purpose of this PR

Due diligence checklist

Additional information

Getting help

Next Steps to Merge

Swagger Validation Report

Swagger Generation Artifacts

Generated ApiView

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Purpose of this PR

Due diligence checklist

Additional information

Getting help

azure-rest-api-specs azure-rest-api-specs copied to clipboard

[Compute] 2024-03-01

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Breaking changes review (Diagram Step 1)

ARM API changes review (Diagram Step 2)

Diagram footnotes

Purpose of this PR

Due diligence checklist

Additional information

Getting help

Next Steps to Merge

Swagger Validation Report

Swagger Generation Artifacts

Generated ApiView

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Purpose of this PR

Due diligence checklist

Additional information

Getting help

azure-rest-api-specs
azure-rest-api-specs copied to clipboard